fix: appengine Node 20 runtime#272
Draft
suztomo wants to merge 6 commits intoGoogleCloudPlatform:mainfrom
Draft
Conversation
Contributor
suztomo
commented
Oct 16, 2025
suztomo
commented
- fix: diagnosing the problem of the missing release tag
- fix lint
- deps: Node12 as of June 27
- deps: App Engine Node 20
- fix: repository validation
- Adding debug message.
The repository field in the incoming package.json should be validated.
chingor13
added
the
kokoro:run
suztomo
commented
Oct 23, 2025
|
|
||
| // Wombat dressing room verifies the repository permission in the last | ||
| // release as well as the one being published. | ||
| const reposToVerifyPermissions = new Set<Repository>(); |
Contributor
Author
There was a problem hiding this comment.
This was not related to Node 20 but about validating the repository permission to prevent putting bad repository metadata.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.