feat: use GitHub Git Refs API for efficient tag validation#296
Open
suztomo wants to merge 3 commits intoGoogleCloudPlatform:mainfrom
Open
feat: use GitHub Git Refs API for efficient tag validation#296suztomo wants to merge 3 commits intoGoogleCloudPlatform:mainfrom
suztomo wants to merge 3 commits intoGoogleCloudPlatform:mainfrom
Conversation
Replaced the 1100-tag scan with a direct lookup using the Git Refs API. This resolves flakiness for large repositories like Genkit and improves efficiency by reducing the number of API calls. BUG=440379162
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced the 1100-tag scan with a direct lookup using the Git Refs API.
This resolves flakiness for large repositories like Genkit and improves
efficiency by reducing the number of API calls.
b/440379162
GitHub API is lenient about the URL encoding
I thought about whether GitHub API needs URL encoding for the tags that have "@" character. It turned out it's not needed.
GitHub API not requiring URL encoding