Skip to content

Conversation

@plumpy
Copy link
Collaborator

@plumpy plumpy commented Jan 16, 2025

Closes #137

@plumpy plumpy requested a review from a team as a code owner January 16, 2025 15:49
@plumpy plumpy requested a review from alphanota January 16, 2025 15:49
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm Gemini, and I'm currently reviewing this pull request. In the meantime, here's a quick summary for you and other reviewers to get up to speed:

This pull request, submitted by plumpy, creates a new file: SECURITY.md. The intent is to establish a clear process for reporting security vulnerabilities.

Summary of Changes:

  • A new file, SECURITY.md, has been added to the container-debug-support repository.
  • This file outlines the procedure for reporting security issues, directing users to use http://g.co/vulnz for reporting and specifying a response time of 5 working days.
  • The file also includes a link to GitHub Security Advisories.

Specific Changes in SECURITY.md:

Line Number Description
1 Header: Reporting Security Issues
3-6 Instructions on how to report security issues using http://g.co/vulnz, including coordination and disclosure on GitHub.
8 Link to GitHub Security Advisory

I'll have a more detailed review shortly.


A little haiku to brighten your day:

Secure code we write,
Vulns reported, swiftly fixed,
Safety's gentle hand.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request adds a SECURITY.md file, which is a good practice. The content is clear and concise, providing essential information for reporting security vulnerabilities. However, it would be beneficial to add more details about the project's security practices and policies. Also, the contributing guidelines should link to this file.

Comment on lines +3 to +6
To report a security issue, please use http://g.co/vulnz. We use
http://g.co/vulnz for our intake, and do coordination and disclosure here on
GitHub (including using [GitHub Security Advisory]). The Google Security Team will
respond within 5 working days of your report on g.co/vulnz.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

While the short link is convenient, it's helpful to also include the full URL for clarity and in case the short link ever breaks. Consider adding both the short link and the full URL.

Suggested change
To report a security issue, please use http://g.co/vulnz. We use
http://g.co/vulnz for our intake, and do coordination and disclosure here on
GitHub (including using [GitHub Security Advisory]). The Google Security Team will
respond within 5 working days of your report on g.co/vulnz.
To report a security issue, please use [http://g.co/vulnz](https://google.com/vulnerability-reward-program). We use
[http://g.co/vulnz](https://google.com/vulnerability-reward-program) for our intake, and do coordination and disclosure here on
GitHub (including using [GitHub Security Advisory]). The Google Security Team will
respond within 5 working days of your report on [g.co/vulnz](https://google.com/vulnerability-reward-program).

Comment on lines +1 to +8
# Reporting Security Issues

To report a security issue, please use http://g.co/vulnz. We use
http://g.co/vulnz for our intake, and do coordination and disclosure here on
GitHub (including using [GitHub Security Advisory]). The Google Security Team will
respond within 5 working days of your report on g.co/vulnz.

[GitHub Security Advisory]: https://github.com/GoogleContainerTools/skaffold/security/advisories
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Consider adding information about:

  • Security Disclosure Policy: Briefly explain the project's commitment to responsible disclosure and how it handles reported vulnerabilities.
  • Supported Versions: Specify which versions of the project receive security updates.
  • Security Audits: If any security audits have been conducted, mention them and link to the reports (if available).
  • Contact Information: Provide an alternative contact method (e.g., email address) for security issues, in addition to the Google Vulnerability Reward Program link.

@plumpy plumpy enabled auto-merge (squash) January 22, 2025 14:40
@plumpy plumpy merged commit f5017c6 into duct-tape Jan 22, 2025
6 checks passed
@plumpy plumpy deleted the plumpy-patch-1 branch January 22, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Security Policy violation SECURITY.md

3 participants