-
Notifications
You must be signed in to change notification settings - Fork 203
chore(bazel): bump version of managed pre-built Go binary #518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @alexeagle, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a routine maintenance update by bumping the version of the pre-built Go binary utilized within the Bazel build configuration. This update ensures that the project leverages the latest stable Go release, incorporating any new features, performance enhancements, or security patches available in version 1.20.0, and maintains build integrity through updated checksums. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request bumps the version of the pre-built container-structure-test Go binary to v1.20.0 and updates the associated checksums. The change is straightforward and appears correct. I have one suggestion regarding a potentially unused hash value for the linux-ppc64le platform, which could improve code maintainability.
| "darwin-arm64": "sha256-WEBmkvHWcZBVqAS4g3wuckdtP+VeSTli8XBapxqL8Ik=", | ||
| "linux-amd64": "sha256-Y30vxXXik+AQW/V7BPaerg6iaNvY3HY38kiWEo/mh4I=", | ||
| "linux-arm64": "sha256-6Atelq/nsqW4OYlXIMqPBR7pFVC4xt8cWtOnNNHUx/8=", | ||
| "linux-ppc64le": "sha256-+6lOsk2RHU4JlQ343JkTH47UTlo6bZWlGs67XEpQqXs=", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The checksum for the linux-ppc64le platform is updated here, but this platform is not defined in the PLATFORMS dictionary in bazel/toolchains_repo.bzl. As a result, this hash is currently unused because the build rules cannot be configured for this platform.
To resolve this inconsistency, you could either:
- Add
linux_ppc64leto thePLATFORMSdictionary inbazel/toolchains_repo.bzlto enable support for it. - Remove this entry from
_HASHESiflinux-ppc64leis not intended to be supported, which would remove unused code.
No description provided.