Skip to content

Update all deps except rules_oci#1853

Merged
loosebazooka merged 1 commit intomainfrom
update-other-deps
Aug 26, 2025
Merged

Update all deps except rules_oci#1853
loosebazooka merged 1 commit intomainfrom
update-other-deps

Conversation

@loosebazooka
Copy link
Member

@loosebazooka loosebazooka commented Aug 25, 2025

bringing rules_oci up to latest might require more significant changes

  • dealing with embedded crane
  • move to use oci_load
  • and more?

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @loosebazooka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on updating various Bazel dependencies to their latest versions, excluding rules_oci and rules_distroless. The primary goal is to ensure the project benefits from the most recent features, bug fixes, and performance improvements offered by these updated dependencies, thereby enhancing the overall build system's stability and capabilities.

Highlights

  • bazel_skylib Update: The bazel_skylib dependency has been upgraded from version 1.7.1 to 1.8.1, bringing minor updates and potential improvements to Bazel's standard library.
  • aspect_bazel_lib Major Update: The aspect_bazel_lib dependency saw a significant jump from version 2.7.9 to 2.21.1, likely introducing many new features, fixes, and performance enhancements.
  • platforms Major Version Update: The platforms dependency has been updated from 0.0.10 to 1.0.0, indicating a stable release and potentially breaking changes or major new functionalities related to platform handling.
  • rules_go Update: The rules_go dependency has been updated from 0.47.0 to 0.57.0, which should provide better support for Go language builds within Bazel.
  • rules_pkg Update: The rules_pkg dependency has been updated from 1.0.1 to 1.1.0, offering minor enhancements for packaging rules.
  • rules_rust Update: The rules_rust dependency has been updated from 0.49.1 to 0.63.0, improving Bazel's capabilities for building Rust projects.
  • container_structure_test Update: The container_structure_test dependency has been updated from 1.16.0 to 1.19.1, enhancing the ability to test container images.
  • rules_python Major Update: The rules_python dependency has been updated from 0.35.0 to 1.5.3, a substantial version bump that will likely bring significant improvements and new features for Python builds.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several Bazel dependencies. While most of these are minor or patch version bumps, the update for rules_python from 0.35.0 to 1.5.3 is a significant major version upgrade. This introduces a breaking change related to the path of the module extension, which will cause the build to fail. I have provided a critical comment detailing the necessary fix in MODULE.bazel.

bazel_dep(name = "rules_oci", version = "1.7.5")
bazel_dep(name = "rules_distroless", version = "0.3.8")
bazel_dep(name = "rules_python", version = "0.35.0")
bazel_dep(name = "rules_python", version = "1.5.3")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The update to rules_python v1.5.3 is a major version bump that introduces breaking changes. The path to the module extension has changed, and the use_extension call on line 24 must be updated to prevent a build failure.

Please update line 24 to use the correct path for the extension:

Current (incorrect):

python = use_extension("@rules_python//python/extensions:python.bzl", "python")

Required (correct):

python = use_extension("@rules_python//python:extensions.bzl", "python")

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2025

🌳 🔄 Image Check
This pull request doesn't make any changes to the images. 👍
You can check the details in the report here

@loosebazooka loosebazooka changed the title Update all deps except oci and distroless Update all deps Aug 25, 2025
Signed-off-by: Appu Goundan <appu@google.com>
@loosebazooka loosebazooka changed the title Update all deps Update all deps except rules_oci Aug 26, 2025
@loosebazooka loosebazooka merged commit af7e4bb into main Aug 26, 2025
11 checks passed
@loosebazooka loosebazooka deleted the update-other-deps branch August 26, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants