Skip to content

Bumping node archives to latest stable versions#1866

Merged
bobcallaway merged 1 commit intomainfrom
update-node-archives
Sep 10, 2025
Merged

Bumping node archives to latest stable versions#1866
bobcallaway merged 1 commit intomainfrom
update-node-archives

Conversation

@distroless-bot
Copy link
Collaborator

Signed-off-by: Distroless Bot distroless-bot@google.com

Signed-off-by: Distroless Bot <distroless-bot@google.com>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @distroless-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a routine maintenance update, upgrading the Node.js runtime to its latest stable patch version. This ensures that the project utilizes the most current and secure version of Node.js, incorporating any bug fixes or minor improvements released in the new patch. The changes primarily involve updating version numbers and corresponding checksums in the build system's dependency definitions and associated test configurations.

Highlights

  • Node.js Version Update: The pull request updates the Node.js version from 24.7.0 to 24.8.0 across all supported architectures (amd64, arm64, ppc64le, s390x).
  • Dependency Lock File Update: The MODULE.bazel.lock file has been updated to reflect the new Node.js version, including updated SHA256 hashes and URLs for the new archives.
  • Bazel Build File Configuration: The private/extensions/node.bzl file, which defines the Node.js archives for Bazel, has been updated with the new version, SHA256 hashes, and download URLs.
  • Test Data Adjustment: A test configuration file (nodejs/testdata/nodejs24.yaml) was updated to expect the new Node.js version, ensuring tests pass with the bumped dependency.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Node.js archives for version 24 from v24.7.0 to the latest stable version, v24.8.0. The changes correctly update the versions, SHA256 checksums, and URLs in MODULE.bazel.lock, private/extensions/node.bzl, and the corresponding test file. My review includes a suggestion to refactor the node.bzl file to improve maintainability by reducing code duplication, which will make future updates easier.

Comment on lines 200 to 238
node_archive(
name = "nodejs24_amd64",
sha256 = "8cf85258402e056efa041168c9b162a4e3b229ebfad5000850b8941c974e9d5a",
strip_prefix = "node-v24.7.0-linux-x64/",
urls = ["https://nodejs.org/dist/v24.7.0/node-v24.7.0-linux-x64.tar.gz"],
version = "24.7.0",
sha256 = "daf68404b478b4c3616666580d02500a24148c0f439e4d0134d65ce70e90e655",
strip_prefix = "node-v24.8.0-linux-x64/",
urls = ["https://nodejs.org/dist/v24.8.0/node-v24.8.0-linux-x64.tar.gz"],
version = "24.8.0",
architecture = "amd64",
control = "//nodejs:control",
)

node_archive(
name = "nodejs24_arm64",
sha256 = "04df0283d2a8a06271a690fbe2528661527b3a09f0f28c8bb63327d8888be184",
strip_prefix = "node-v24.7.0-linux-arm64/",
urls = ["https://nodejs.org/dist/v24.7.0/node-v24.7.0-linux-arm64.tar.gz"],
version = "24.7.0",
sha256 = "5eb16b14af5a5f494ed54770822144e847c744fe590f8df093ad4927cf3dd7fd",
strip_prefix = "node-v24.8.0-linux-arm64/",
urls = ["https://nodejs.org/dist/v24.8.0/node-v24.8.0-linux-arm64.tar.gz"],
version = "24.8.0",
architecture = "arm64",
control = "//nodejs:control",
)

node_archive(
name = "nodejs24_ppc64le",
sha256 = "85378129414ca95c509317360c519328ae98d34160fc852408ba0209033e5f82",
strip_prefix = "node-v24.7.0-linux-ppc64le/",
urls = ["https://nodejs.org/dist/v24.7.0/node-v24.7.0-linux-ppc64le.tar.gz"],
version = "24.7.0",
sha256 = "20a0856e7b152a5e83b4fd6fe3d509aa54b75d6170cd89066c341d56f6c5de76",
strip_prefix = "node-v24.8.0-linux-ppc64le/",
urls = ["https://nodejs.org/dist/v24.8.0/node-v24.8.0-linux-ppc64le.tar.gz"],
version = "24.8.0",
architecture = "ppc64le",
control = "//nodejs:control",
)

node_archive(
name = "nodejs24_s390x",
sha256 = "d5b26b197795872dbd69f4dd8c275e8a08ca1be69c9e013e3cd9a6f68939e59d",
strip_prefix = "node-v24.7.0-linux-s390x/",
urls = ["https://nodejs.org/dist/v24.7.0/node-v24.7.0-linux-s390x.tar.gz"],
version = "24.7.0",
sha256 = "708d4edfafca2218fa98e0e8b8c20dc148334f2f882fcea1237c6536e8586d06",
strip_prefix = "node-v24.8.0-linux-s390x/",
urls = ["https://nodejs.org/dist/v24.8.0/node-v24.8.0-linux-s390x.tar.gz"],
version = "24.8.0",
architecture = "s390x",
control = "//nodejs:control",
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and reduce code duplication, consider refactoring the nodejs24 archive definitions. You can define the version and architecture-specific details in a data structure (like a dictionary) and then use a loop to generate the node_archive calls. This will make future version bumps easier and less error-prone. A similar refactoring could be applied to the other Node.js versions as well.

If this file is auto-generated, consider updating the generation script to produce this more compact and maintainable output.

    _NODE24_VERSION = "24.8.0"
    _NODE24_ARCHES = {
        "amd64": ("x64", "daf68404b478b4c3616666580d02500a24148c0f439e4d0134d65ce70e90e655"),
        "arm64": ("arm64", "5eb16b14af5a5f494ed54770822144e847c744fe590f8df093ad4927cf3dd7fd"),
        "ppc64le": ("ppc64le", "20a0856e7b152a5e83b4fd6fe3d509aa54b75d6170cd89066c341d56f6c5de76"),
        "s390x": ("s390x", "708d4edfafca2218fa98e0e8b8c20dc148334f2f882fcea1237c6536e8586d06"),
    }

    for arch, (platform, sha256) in _NODE24_ARCHES.items():
        node_archive(
            name = "nodejs24_{}".format(arch),
            sha256 = sha256,
            strip_prefix = "node-v{v}-linux-{p}/".format(v=_NODE24_VERSION, p=platform),
            urls = ["https://nodejs.org/dist/v{v}/node-v{v}-linux-{p}.tar.gz".format(v=_NODE24_VERSION, p=platform)],
            version = _NODE24_VERSION,
            architecture = arch,
            control = "//nodejs:control",
        )

@github-actions
Copy link
Contributor

🌳 🔄 Image Check

This pull request has modified the following images:

//nodejs:nodejs24_root_amd64_debian12
//nodejs:nodejs24_debug_root_arm64_debian12
//nodejs:nodejs24_debug_nonroot_amd64_debian12
//nodejs:nodejs24_root_arm64_debian12
//nodejs:nodejs24_root_s390x_debian12
//nodejs:nodejs24_root_s390x_debian12
//nodejs:nodejs24_nonroot_arm64_debian12
//nodejs:nodejs24_debug_nonroot_arm64_debian12
//nodejs:nodejs24_root_amd64_debian12
//nodejs:nodejs24_nonroot_s390x_debian12
//nodejs:nodejs24_debug_root_amd64_debian12
//nodejs:nodejs24_debug_root_ppc64le_debian12
//nodejs:nodejs24_root_ppc64le_debian12
//nodejs:nodejs24_debug_nonroot_arm64_debian12
//nodejs:nodejs24_nonroot_ppc64le_debian12
//nodejs:nodejs24_nonroot_s390x_debian12
//nodejs:nodejs24_debug_root_arm64_debian12
//nodejs:nodejs24_debug_nonroot_s390x_debian12
//nodejs:nodejs24_debug_root_amd64_debian12
//nodejs:nodejs24_nonroot_ppc64le_debian12
//nodejs:nodejs24_debug_nonroot_s390x_debian12
//nodejs:nodejs24_nonroot_amd64_debian12
//nodejs:nodejs24_root_arm64_debian12
//nodejs:nodejs24_debug_nonroot_amd64_debian12
//nodejs:nodejs24_nonroot_arm64_debian12
//nodejs:nodejs24_debug_nonroot_ppc64le_debian12
//nodejs:nodejs24_nonroot_amd64_debian12
//nodejs:nodejs24_debug_root_s390x_debian12
//nodejs:nodejs24_debug_nonroot_ppc64le_debian12
//nodejs:nodejs24_root_ppc64le_debian12
//nodejs:nodejs24_debug_root_s390x_debian12
//nodejs:nodejs24_debug_root_ppc64le_debian12

You can check the details in the report here

@bobcallaway bobcallaway merged commit 52f6d8c into main Sep 10, 2025
11 checks passed
@bobcallaway bobcallaway deleted the update-node-archives branch September 10, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants