Skip to content

Bump some of the dependencies #1868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
harryzcy wants to merge 6 commits into from
Closed

Bump some of the dependencies #1868

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ac56279
Bump gazelle to 0.45.0
harryzcy Sep 15, 2025
ff21840
Bump rules_rust to 0.64.0
harryzcy Sep 15, 2025
a0bf63f
Bump rules_cc to 0.2.8
harryzcy Sep 15, 2025
afdde5a
Bump rules_python to 1.6.1
harryzcy Sep 15, 2025
20462dc
Run `bazel mod tidy` and update lock file
harryzcy Sep 15, 2025
10576e1
Revert `use_repo` for `oci_crane_toolchains`
harryzcy Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,14 @@ bazel_dep(name = "bazel_skylib", version = "1.8.1")
bazel_dep(name = "aspect_bazel_lib", version = "2.21.1")
bazel_dep(name = "platforms", version = "1.0.0")
bazel_dep(name = "rules_go", version = "0.57.0")
bazel_dep(name = "gazelle", version = "0.38.0")
bazel_dep(name = "gazelle", version = "0.45.0")
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This update for Gazelle from 0.38.0 to 0.45.0 is a large version jump across seven minor versions for a pre-1.0 dependency. This significantly increases the risk of introducing breaking changes that could affect the go_deps extension. Given the empty pull request description, it's unclear if this has been validated. It is highly recommended to review the release notes for breaking changes. For such significant upgrades, consider smaller, incremental updates to reduce risk and simplify debugging.

bazel_dep(name = "rules_pkg", version = "1.1.0")
bazel_dep(name = "rules_rust", version = "0.63.0")
bazel_dep(name = "rules_rust", version = "0.64.0")
bazel_dep(name = "container_structure_test", version = "1.19.1")
bazel_dep(name = "rules_oci", version = "1.8.0")
bazel_dep(name = "rules_distroless", version = "0.5.3")
bazel_dep(name = "rules_python", version = "1.5.3")
bazel_dep(name = "rules_cc", version = "0.2.0")
bazel_dep(name = "rules_python", version = "1.6.1")
bazel_dep(name = "rules_cc", version = "0.2.8")
Comment on lines +9 to +16
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Updating four different dependencies in a single pull request makes it difficult to trace the source of any potential issues and complicates rollbacks. It's a best practice to update each dependency in a separate pull request. This allows for isolated testing and a clearer commit history, which is especially important when dealing with multiple pre-1.0 dependencies as is the case here.


### OCI ###
oci = use_extension("@rules_oci//oci:extensions.bzl", "oci")
Expand Down
44 changes: 24 additions & 20 deletions MODULE.bazel.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion private/repos/java_temurin/java.MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
"repositories for java"

include("//private/repos/java_temurin:java_17.MODULE.bazel")

include("//private/repos/java_temurin:java_21.MODULE.bazel")

java = use_extension("//private/extensions:java.bzl", "java")
Expand All @@ -18,5 +19,5 @@ use_repo(
"temurin21_jdk_ppc64le",
"temurin21_jre_amd64",
"temurin21_jre_arm64",
"temurin21_jre_ppc64le"
"temurin21_jre_ppc64le",
)
Loading