Skip to content

Bumping node archives to latest stable versions#1873

Merged
bobcallaway merged 1 commit intomainfrom
update-node-archives
Sep 25, 2025
Merged

Bumping node archives to latest stable versions#1873
bobcallaway merged 1 commit intomainfrom
update-node-archives

Conversation

@distroless-bot
Copy link
Collaborator

Signed-off-by: Distroless Bot distroless-bot@google.com

Signed-off-by: Distroless Bot <distroless-bot@google.com>
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @distroless-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a routine update of the Node.js 24 archives to their latest stable version, 24.9.0. This ensures that the project's Node.js dependencies are current and secure across various system architectures. The changes involve updating the core build definitions and associated dependency lock files, along with corresponding test adjustments to reflect the new version.

Highlights

  • Node.js Version Bump: The Node.js 24 archives have been updated from version 24.8.0 to 24.9.0 to incorporate the latest stable release.
  • Multi-architecture Support: The version updates apply consistently across multiple architectures, including amd64, arm64, ppc64le, and s390x.
  • Dependency Lock File Update: The MODULE.bazel.lock file has been updated to reflect the new Node.js archive details, including updated SHA256 digests and URLs.
  • Test Case Alignment: A test case in nodejs/testdata/nodejs24.yaml was updated to correctly verify the new v24.9.0 version output.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Node.js v24 archives from version 24.8.0 to the latest stable version, 24.9.0. The changes are consistent across all relevant files, including the Bazel build files, lock file, and test data. The version numbers, URLs, and SHA256 checksums have been correctly updated. I've added one suggestion to refactor the node_archive definitions in private/extensions/node.bzl to improve maintainability and reduce code duplication, which will simplify future updates.

Comment on lines 200 to 238
node_archive(
name = "nodejs24_amd64",
sha256 = "daf68404b478b4c3616666580d02500a24148c0f439e4d0134d65ce70e90e655",
strip_prefix = "node-v24.8.0-linux-x64/",
urls = ["https://nodejs.org/dist/v24.8.0/node-v24.8.0-linux-x64.tar.gz"],
version = "24.8.0",
sha256 = "d57d6c28a35785f58f33899a0aa0bfc83f7a8ef4448b6cf3f7d0961efc7b9189",
strip_prefix = "node-v24.9.0-linux-x64/",
urls = ["https://nodejs.org/dist/v24.9.0/node-v24.9.0-linux-x64.tar.gz"],
version = "24.9.0",
architecture = "amd64",
control = "//nodejs:control",
)

node_archive(
name = "nodejs24_arm64",
sha256 = "5eb16b14af5a5f494ed54770822144e847c744fe590f8df093ad4927cf3dd7fd",
strip_prefix = "node-v24.8.0-linux-arm64/",
urls = ["https://nodejs.org/dist/v24.8.0/node-v24.8.0-linux-arm64.tar.gz"],
version = "24.8.0",
sha256 = "dab232a90169737a48149149dd6707e7fdcbaefbaa94b4871047a38e93db947f",
strip_prefix = "node-v24.9.0-linux-arm64/",
urls = ["https://nodejs.org/dist/v24.9.0/node-v24.9.0-linux-arm64.tar.gz"],
version = "24.9.0",
architecture = "arm64",
control = "//nodejs:control",
)

node_archive(
name = "nodejs24_ppc64le",
sha256 = "20a0856e7b152a5e83b4fd6fe3d509aa54b75d6170cd89066c341d56f6c5de76",
strip_prefix = "node-v24.8.0-linux-ppc64le/",
urls = ["https://nodejs.org/dist/v24.8.0/node-v24.8.0-linux-ppc64le.tar.gz"],
version = "24.8.0",
sha256 = "557d4e3f779f5af4fc29944647e6afd76901c5be7bc0c2bd8785a199a1bc0271",
strip_prefix = "node-v24.9.0-linux-ppc64le/",
urls = ["https://nodejs.org/dist/v24.9.0/node-v24.9.0-linux-ppc64le.tar.gz"],
version = "24.9.0",
architecture = "ppc64le",
control = "//nodejs:control",
)

node_archive(
name = "nodejs24_s390x",
sha256 = "708d4edfafca2218fa98e0e8b8c20dc148334f2f882fcea1237c6536e8586d06",
strip_prefix = "node-v24.8.0-linux-s390x/",
urls = ["https://nodejs.org/dist/v24.8.0/node-v24.8.0-linux-s390x.tar.gz"],
version = "24.8.0",
sha256 = "9baab2eb6b8d9efd2e3533ac79b572e697510f6582fdb572ba636c4d7b01d2b1",
strip_prefix = "node-v24.9.0-linux-s390x/",
urls = ["https://nodejs.org/dist/v24.9.0/node-v24.9.0-linux-s390x.tar.gz"],
version = "24.9.0",
architecture = "s390x",
control = "//nodejs:control",
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and reduce duplication, consider refactoring this block to define the version and architecture-specific data in a structure, and then loop over it to generate the node_archive repositories. This will make future version updates much simpler and less prone to copy-paste errors. A similar refactoring could be applied to the definitions for Node.js 20 and 22.

    NODE24_VERSION = "24.9.0"
    NODE24_ARCHS = {
        "amd64": ("linux-x64", "d57d6c28a35785f58f33899a0aa0bfc83f7a8ef4448b6cf3f7d0961efc7b9189"),
        "arm64": ("linux-arm64", "dab232a90169737a48149149dd6707e7fdcbaefbaa94b4871047a38e93db947f"),
        "ppc64le": ("linux-ppc64le", "557d4e3f779f5af4fc29944647e6afd76901c5be7bc0c2bd8785a199a1bc0271"),
        "s390x": ("linux-s390x", "9baab2eb6b8d9efd2e3533ac79b572e697510f6582fdb572ba636c4d7b01d2b1"),
    }

    for arch, (platform, sha256) in NODE24_ARCHS.items():
        node_archive(
            name = "nodejs24_" + arch,
            sha256 = sha256,
            strip_prefix = "node-v{version}-{platform}/".format(version = NODE24_VERSION, platform = platform),
            urls = ["https://nodejs.org/dist/v{version}/node-v{version}-{platform}.tar.gz".format(version = NODE24_VERSION, platform = platform)],
            version = NODE24_VERSION,
            architecture = arch,
            control = "//nodejs:control",
        )

@github-actions
Copy link
Contributor

🌳 🔄 Image Check

This pull request has modified the following images:

//nodejs:nodejs24_debug_root_amd64_debian12
//nodejs:nodejs24_debug_nonroot_amd64_debian12
//nodejs:nodejs24_nonroot_arm64_debian12
//nodejs:nodejs24_debug_root_arm64_debian12
//nodejs:nodejs24_debug_root_arm64_debian12
//nodejs:nodejs24_nonroot_amd64_debian12
//nodejs:nodejs24_nonroot_arm64_debian12
//nodejs:nodejs24_root_s390x_debian12
//nodejs:nodejs24_debug_root_ppc64le_debian12
//nodejs:nodejs24_root_arm64_debian12
//nodejs:nodejs24_root_amd64_debian12
//nodejs:nodejs24_debug_nonroot_s390x_debian12
//nodejs:nodejs24_nonroot_ppc64le_debian12
//nodejs:nodejs24_debug_nonroot_arm64_debian12
//nodejs:nodejs24_root_ppc64le_debian12
//nodejs:nodejs24_root_ppc64le_debian12
//nodejs:nodejs24_debug_nonroot_s390x_debian12
//nodejs:nodejs24_debug_root_ppc64le_debian12
//nodejs:nodejs24_debug_nonroot_ppc64le_debian12
//nodejs:nodejs24_debug_root_amd64_debian12
//nodejs:nodejs24_debug_nonroot_ppc64le_debian12
//nodejs:nodejs24_root_s390x_debian12
//nodejs:nodejs24_debug_nonroot_arm64_debian12
//nodejs:nodejs24_root_amd64_debian12
//nodejs:nodejs24_nonroot_ppc64le_debian12
//nodejs:nodejs24_root_arm64_debian12
//nodejs:nodejs24_debug_nonroot_amd64_debian12
//nodejs:nodejs24_debug_root_s390x_debian12
//nodejs:nodejs24_debug_root_s390x_debian12
//nodejs:nodejs24_nonroot_s390x_debian12
//nodejs:nodejs24_nonroot_s390x_debian12
//nodejs:nodejs24_nonroot_amd64_debian12

You can check the details in the report here

@bobcallaway bobcallaway merged commit 297ad51 into main Sep 25, 2025
11 checks passed
@bobcallaway bobcallaway deleted the update-node-archives branch September 25, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants