-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add cc builds for debian13 #1886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @loosebazooka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces support for building C/C++ images for Debian 13. It updates the build system to include Debian 13 in the distribution list, specifically migrating its C/C++ toolchain from GCC 12 to GCC 14. The changes involve modifying Bazel build files to handle preview distributions and dynamic GCC versions, updating the dependency lock file with the new GCC 14 packages and their checksums for Debian 13, and adjusting the package manifest for Debian 13 to reflect this change. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Signed-off-by: Appu Goundan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
Overall, the changes in this pull request are well-implemented and align with the goal of adding cc builds for Debian 13. The introduction of the GCC_BASE map in cc/BUILD is a good improvement for managing GCC versions across different distributions. I have one suggestion to further improve the maintainability of the compiler package dependencies.
|
🌳 🔄 Image Check |
|
looks all good to me |
No description provided.