Skip to content

Conversation

@loosebazooka
Copy link
Member

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @loosebazooka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces support for building C/C++ images for Debian 13. It updates the build system to include Debian 13 in the distribution list, specifically migrating its C/C++ toolchain from GCC 12 to GCC 14. The changes involve modifying Bazel build files to handle preview distributions and dynamic GCC versions, updating the dependency lock file with the new GCC 14 packages and their checksums for Debian 13, and adjusting the package manifest for Debian 13 to reflect this change.

Highlights

  • Intent: This pull request aims to add support for building C/C++ images specifically for Debian 13 (codenamed 'trixie').
  • Key Changes: The core changes involve extending the build configurations to include Debian 13, updating the GCC base package from version 12 to 14 for Debian 13, and refreshing the Bazel module lock file to reflect these new dependencies.
  • Detailed Changes: 1. BUILD: Modified the CC and oci_image_index rules to iterate over DISTROS + PREVIEW_DISTROS, enabling the inclusion of preview distributions like Debian 13 in the build process.
  1. MODULE.bazel.lock: Updated the hash for trixie.lock.json and, more significantly, changed the gcc-12-base package to gcc-14-base for the trixie distribution across all architectures (amd64, arm64, armhf, ppc64el, s390x), along with their new versions and SHA256 checksums.
  2. cc/BUILD: Imported PREVIEW_DISTROS and introduced a GCC_BASE dictionary to dynamically select the appropriate gcc-base package version based on the Debian distribution (e.g., debian12 uses gcc-12-base, debian13 uses gcc-14-base). The oci_image rule was updated to use this dynamic selection.
  3. private/repos/deb/trixie.yaml: Explicitly updated the C++ package list for trixie to use gcc-14-base instead of gcc-12-base.
  • Reviewer Notes: Reviewers should verify that the transition to GCC 14 for Debian 13 is correct and that all necessary dependencies are properly updated in the lock file. Also, confirm that the inclusion of PREVIEW_DISTROS aligns with the intended distribution strategy.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Signed-off-by: Appu Goundan <[email protected]>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

Overall, the changes in this pull request are well-implemented and align with the goal of adding cc builds for Debian 13. The introduction of the GCC_BASE map in cc/BUILD is a good improvement for managing GCC versions across different distributions. I have one suggestion to further improve the maintainability of the compiler package dependencies.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025

🌳 🔄 Image Check
This pull request doesn't make any changes to the images. 👍
You can check the details in the report here

@loosebazooka loosebazooka merged commit a56e4de into main Oct 8, 2025
11 checks passed
@loosebazooka loosebazooka deleted the cc-deb13 branch October 8, 2025 20:06
@thesayyn
Copy link
Collaborator

thesayyn commented Oct 8, 2025

looks all good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants