Skip to content

Conversation

@loosebazooka
Copy link
Member

@loosebazooka loosebazooka commented Oct 13, 2025

fixes #1887

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @loosebazooka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates the zlib1g compression library into the cc build system, specifically for the debian13 distribution. The changes involve updating the build configuration to dynamically include distro-specific libraries and adding the necessary dependency information for zlib1g across multiple architectures in the lock files. This enhancement aims to provide compression capabilities for C/C++ applications built within this environment.

Highlights

  • Build Configuration Refactoring: The cc/BUILD file has been refactored to replace the GCC_BASE variable with a more flexible DISTRO_SPECIFIC_LIBRARIES map, allowing for the inclusion of multiple libraries per distribution.
  • Zlib Integration for Debian 13: The zlib1g compression library has been explicitly added as a required dependency for the debian13 distribution within the cc build process.
  • Dependency Lock File Updates: The private/repos/deb/trixie.lock.json file has been updated to include detailed entries for the zlib1g package across various architectures (amd64, arm64, armhf, s390x, ppc64el), specifying their SHA256 hashes, download URLs, and versions.
  • Package Declaration: The zlib1g package has been added to the list of required packages in private/repos/deb/trixie.yaml.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Signed-off-by: Appu Goundan <[email protected]>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the zlib1g compression library to the C/C++ images for the debian13 distribution. This is achieved by refactoring the package list in cc/BUILD to support multiple distro-specific libraries and updating the Debian package configurations. The changes look good, but I have one suggestion to improve the readability of the package list construction in the BUILD file.

@github-actions
Copy link
Contributor

🌳 🔄 Image Check

This pull request has modified the following images:

//cc:debug_root_amd64_debian12
//cc:debug_nonroot_amd64_debian12
//cc:cc_root_amd64_debian12
//cc:cc_nonroot_arm64_debian12
//cc:debug_root_arm64_debian12
//cc:cc_root_arm64_debian12
//cc:debug_nonroot_arm64_debian12
//cc:cc_nonroot_amd64_debian12
//cc:cc_root_arm_debian12
//cc:cc_nonroot_arm64_debian12
//cc:debug_nonroot_amd64_debian12
//cc:cc_root_s390x_debian12
//cc:debug_root_amd64_debian12
//cc:cc_root_arm64_debian12
//cc:debug_nonroot_arm_debian12
//cc:cc_nonroot_ppc64le_debian12
//cc:debug_nonroot_ppc64le_debian12
//cc:debug_root_s390x_debian12
//cc:debug_nonroot_s390x_debian12
//cc:debug_root_ppc64le_debian12
//cc:cc_nonroot_arm_debian12
//cc:debug_nonroot_amd64_debian13
//cc:cc_root_s390x_debian12
//cc:debug_root_arm64_debian12
//cc:debug_root_s390x_debian12
//cc:debug_root_ppc64le_debian12
//cc:debug_nonroot_arm_debian12
//cc:debug_nonroot_arm64_debian13
//cc:cc_nonroot_arm64_debian13
//cc:cc_nonroot_s390x_debian12
//cc:cc_root_arm64_debian13
//cc:debug_nonroot_arm_debian13
//cc:cc_nonroot_arm_debian13
//cc:cc_nonroot_amd64_debian12
//cc:debug_root_ppc64le_debian13
//cc:debug_root_arm_debian12
//cc:cc_nonroot_s390x_debian12
//cc:cc_nonroot_amd64_debian13
//cc:debug_root_arm64_debian13
//cc:cc_nonroot_s390x_debian13
//cc:cc_root_ppc64le_debian13
//cc:cc_nonroot_ppc64le_debian12
//cc:cc_root_arm_debian13
//cc:debug_root_s390x_debian13
//cc:debug_root_arm_debian13
//python3:python3_nonroot_amd64_debian12
//cc:debug_nonroot_s390x_debian12
//python3:debug_root_amd64_debian12
//python3:debug_root_arm64_debian12
//python3:debug_nonroot_arm64_debian12
//python3:python3_nonroot_arm64_debian12
//python3:debug_nonroot_amd64_debian12
//python3:debug_nonroot_amd64_debian12
//cc:debug_nonroot_s390x_debian13
//python3:python3_root_arm64_debian12
//cc:debug_nonroot_ppc64le_debian12
//cc:cc_nonroot_ppc64le_debian13
//python3:debug_root_amd64_debian12
//nodejs:nodejs20_debug_root_amd64_debian12
//python3:python3_nonroot_amd64_debian12
//cc:cc_root_amd64_debian12
//cc:cc_root_amd64_debian13
//cc:debug_root_amd64_debian13
//python3:python3_root_amd64_debian12
//cc:cc_root_s390x_debian13
//nodejs:nodejs20_debug_root_arm64_debian12
//python3:python3_root_amd64_debian12
//cc:cc_nonroot_arm_debian12
//cc:debug_nonroot_ppc64le_debian13
//python3:debug_root_arm64_debian12
//cc:cc_root_ppc64le_debian12
//cc:cc_root_ppc64le_debian12
//nodejs:nodejs20_debug_nonroot_arm64_debian12
//python3:python3_nonroot_arm64_debian12
//cc:debug_nonroot_arm64_debian12
//nodejs:nodejs20_root_amd64_debian12
//nodejs:nodejs20_nonroot_arm64_debian12
//python3:python3_root_arm64_debian12
//nodejs:nodejs20_debug_nonroot_arm_debian12
//nodejs:nodejs20_debug_nonroot_amd64_debian12
//nodejs:nodejs20_debug_root_arm64_debian12
//nodejs:nodejs20_debug_nonroot_arm_debian12
//nodejs:nodejs20_root_arm_debian12
//nodejs:nodejs20_nonroot_amd64_debian12
//nodejs:nodejs20_debug_nonroot_s390x_debian12
//nodejs:nodejs20_debug_root_amd64_debian12
//nodejs:nodejs20_nonroot_amd64_debian12
//nodejs:nodejs20_nonroot_arm_debian12
//cc:debug_root_arm_debian12
//nodejs:nodejs20_debug_nonroot_arm64_debian12
//python3:debug_nonroot_arm64_debian12
//nodejs:nodejs20_root_ppc64le_debian12
//nodejs:nodejs20_debug_root_ppc64le_debian12
//nodejs:nodejs20_root_arm64_debian12
//nodejs:nodejs20_nonroot_arm64_debian12
//nodejs:nodejs20_root_amd64_debian12
//nodejs:nodejs20_debug_nonroot_ppc64le_debian12
//nodejs:nodejs20_root_arm64_debian12
//nodejs:nodejs20_debug_nonroot_s390x_debian12
//cc:cc_root_arm_debian12
//nodejs:nodejs22_root_amd64_debian12
//nodejs:nodejs22_debug_root_amd64_debian12
//nodejs:nodejs20_nonroot_arm_debian12
//nodejs:nodejs20_nonroot_s390x_debian12
//nodejs:nodejs20_nonroot_ppc64le_debian12
//nodejs:nodejs20_nonroot_s390x_debian12
//nodejs:nodejs22_debug_nonroot_amd64_debian12
//nodejs:nodejs20_root_s390x_debian12
//nodejs:nodejs22_nonroot_amd64_debian12
//nodejs:nodejs22_debug_root_arm_debian12
//nodejs:nodejs20_debug_root_s390x_debian12
//nodejs:nodejs22_nonroot_amd64_debian12
//nodejs:nodejs22_root_arm_debian12
//nodejs:nodejs20_debug_root_s390x_debian12
//nodejs:nodejs22_root_arm64_debian12
//nodejs:nodejs22_debug_nonroot_arm64_debian12
//nodejs:nodejs20_root_ppc64le_debian12
//nodejs:nodejs20_debug_nonroot_amd64_debian12
//nodejs:nodejs22_nonroot_arm_debian12
//nodejs:nodejs22_debug_root_arm64_debian12
//nodejs:nodejs20_debug_root_ppc64le_debian12
//nodejs:nodejs22_debug_root_s390x_debian12
//nodejs:nodejs22_root_ppc64le_debian12
//nodejs:nodejs22_debug_nonroot_s390x_debian12
//nodejs:nodejs22_nonroot_arm_debian12
//nodejs:nodejs22_root_s390x_debian12
//nodejs:nodejs22_nonroot_arm64_debian12
//nodejs:nodejs22_debug_root_arm64_debian12
//nodejs:nodejs22_nonroot_s390x_debian12
//nodejs:nodejs20_debug_nonroot_ppc64le_debian12
//nodejs:nodejs22_debug_nonroot_s390x_debian12
//nodejs:nodejs22_debug_nonroot_amd64_debian12
//nodejs:nodejs22_debug_nonroot_arm64_debian12
//nodejs:nodejs22_debug_nonroot_arm_debian12
//nodejs:nodejs22_nonroot_arm64_debian12
//nodejs:nodejs24_root_amd64_debian12
//nodejs:nodejs22_nonroot_ppc64le_debian12
//nodejs:nodejs20_debug_root_arm_debian12
//nodejs:nodejs22_debug_root_arm_debian12
//nodejs:nodejs20_root_arm_debian12
//nodejs:nodejs24_nonroot_amd64_debian12
//nodejs:nodejs22_debug_root_amd64_debian12
//nodejs:nodejs22_debug_nonroot_arm_debian12
//nodejs:nodejs24_root_arm64_debian12
//nodejs:nodejs22_debug_nonroot_ppc64le_debian12
//nodejs:nodejs24_nonroot_arm64_debian12
//nodejs:nodejs20_nonroot_ppc64le_debian12
//nodejs:nodejs24_nonroot_amd64_debian12
//nodejs:nodejs22_root_arm64_debian12
//nodejs:nodejs24_debug_nonroot_amd64_debian12
//nodejs:nodejs24_debug_nonroot_amd64_debian12
//nodejs:nodejs24_debug_nonroot_arm64_debian12
//nodejs:nodejs24_root_s390x_debian12
//nodejs:nodejs24_debug_nonroot_arm64_debian12
//nodejs:nodejs24_root_amd64_debian12
//nodejs:nodejs24_root_s390x_debian12
//nodejs:nodejs22_root_arm_debian12
//nodejs:nodejs24_nonroot_arm64_debian12
//nodejs:nodejs24_debug_root_amd64_debian12
//nodejs:nodejs24_debug_root_ppc64le_debian12
//nodejs:nodejs24_nonroot_ppc64le_debian12
//nodejs:nodejs24_debug_nonroot_ppc64le_debian12
//nodejs:nodejs22_debug_root_ppc64le_debian12
//nodejs:nodejs24_debug_root_s390x_debian12
//nodejs:nodejs24_debug_nonroot_ppc64le_debian12
//nodejs:nodejs22_debug_nonroot_ppc64le_debian12
//nodejs:nodejs24_root_arm64_debian12
//nodejs:nodejs22_debug_root_s390x_debian12
//nodejs:nodejs24_nonroot_s390x_debian12
//nodejs:nodejs24_debug_root_s390x_debian12
//nodejs:nodejs24_debug_root_ppc64le_debian12
//nodejs:nodejs22_root_s390x_debian12
//nodejs:nodejs24_debug_root_arm64_debian12
//nodejs:nodejs24_debug_nonroot_s390x_debian12
//nodejs:nodejs20_debug_root_arm_debian12
//nodejs:nodejs22_root_amd64_debian12
//nodejs:nodejs22_debug_root_ppc64le_debian12
//nodejs:nodejs22_nonroot_ppc64le_debian12
//nodejs:nodejs24_root_ppc64le_debian12
//nodejs:nodejs24_debug_root_amd64_debian12
//nodejs:nodejs24_debug_nonroot_s390x_debian12
//nodejs:nodejs22_root_ppc64le_debian12
//nodejs:nodejs24_debug_root_arm64_debian12
//nodejs:nodejs24_root_ppc64le_debian12
//nodejs:nodejs24_nonroot_s390x_debian12
//nodejs:nodejs20_root_s390x_debian12
//nodejs:nodejs24_nonroot_ppc64le_debian12
//nodejs:nodejs22_nonroot_s390x_debian12

You can check the details in the report here

@bobcallaway bobcallaway merged commit b79d6d4 into main Oct 13, 2025
11 checks passed
@bobcallaway bobcallaway deleted the compression branch October 13, 2025 15:38
@loosebazooka
Copy link
Member Author

Oh right I changed the order of some things

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

compression lib for cc image debian13

2 participants