-
Notifications
You must be signed in to change notification settings - Fork 1.3k
add compression to cc #1890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add compression to cc #1890
Conversation
Summary of ChangesHello @loosebazooka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Signed-off-by: Appu Goundan <[email protected]>
b25f073 to
cd3a92e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds the zlib1g compression library to the C/C++ images for the debian13 distribution. This is achieved by refactoring the package list in cc/BUILD to support multiple distro-specific libraries and updating the Debian package configurations. The changes look good, but I have one suggestion to improve the readability of the package list construction in the BUILD file.
|
🌳 🔄 Image Check This pull request has modified the following images: //cc:debug_root_amd64_debian12
//cc:debug_nonroot_amd64_debian12
//cc:cc_root_amd64_debian12
//cc:cc_nonroot_arm64_debian12
//cc:debug_root_arm64_debian12
//cc:cc_root_arm64_debian12
//cc:debug_nonroot_arm64_debian12
//cc:cc_nonroot_amd64_debian12
//cc:cc_root_arm_debian12
//cc:cc_nonroot_arm64_debian12
//cc:debug_nonroot_amd64_debian12
//cc:cc_root_s390x_debian12
//cc:debug_root_amd64_debian12
//cc:cc_root_arm64_debian12
//cc:debug_nonroot_arm_debian12
//cc:cc_nonroot_ppc64le_debian12
//cc:debug_nonroot_ppc64le_debian12
//cc:debug_root_s390x_debian12
//cc:debug_nonroot_s390x_debian12
//cc:debug_root_ppc64le_debian12
//cc:cc_nonroot_arm_debian12
//cc:debug_nonroot_amd64_debian13
//cc:cc_root_s390x_debian12
//cc:debug_root_arm64_debian12
//cc:debug_root_s390x_debian12
//cc:debug_root_ppc64le_debian12
//cc:debug_nonroot_arm_debian12
//cc:debug_nonroot_arm64_debian13
//cc:cc_nonroot_arm64_debian13
//cc:cc_nonroot_s390x_debian12
//cc:cc_root_arm64_debian13
//cc:debug_nonroot_arm_debian13
//cc:cc_nonroot_arm_debian13
//cc:cc_nonroot_amd64_debian12
//cc:debug_root_ppc64le_debian13
//cc:debug_root_arm_debian12
//cc:cc_nonroot_s390x_debian12
//cc:cc_nonroot_amd64_debian13
//cc:debug_root_arm64_debian13
//cc:cc_nonroot_s390x_debian13
//cc:cc_root_ppc64le_debian13
//cc:cc_nonroot_ppc64le_debian12
//cc:cc_root_arm_debian13
//cc:debug_root_s390x_debian13
//cc:debug_root_arm_debian13
//python3:python3_nonroot_amd64_debian12
//cc:debug_nonroot_s390x_debian12
//python3:debug_root_amd64_debian12
//python3:debug_root_arm64_debian12
//python3:debug_nonroot_arm64_debian12
//python3:python3_nonroot_arm64_debian12
//python3:debug_nonroot_amd64_debian12
//python3:debug_nonroot_amd64_debian12
//cc:debug_nonroot_s390x_debian13
//python3:python3_root_arm64_debian12
//cc:debug_nonroot_ppc64le_debian12
//cc:cc_nonroot_ppc64le_debian13
//python3:debug_root_amd64_debian12
//nodejs:nodejs20_debug_root_amd64_debian12
//python3:python3_nonroot_amd64_debian12
//cc:cc_root_amd64_debian12
//cc:cc_root_amd64_debian13
//cc:debug_root_amd64_debian13
//python3:python3_root_amd64_debian12
//cc:cc_root_s390x_debian13
//nodejs:nodejs20_debug_root_arm64_debian12
//python3:python3_root_amd64_debian12
//cc:cc_nonroot_arm_debian12
//cc:debug_nonroot_ppc64le_debian13
//python3:debug_root_arm64_debian12
//cc:cc_root_ppc64le_debian12
//cc:cc_root_ppc64le_debian12
//nodejs:nodejs20_debug_nonroot_arm64_debian12
//python3:python3_nonroot_arm64_debian12
//cc:debug_nonroot_arm64_debian12
//nodejs:nodejs20_root_amd64_debian12
//nodejs:nodejs20_nonroot_arm64_debian12
//python3:python3_root_arm64_debian12
//nodejs:nodejs20_debug_nonroot_arm_debian12
//nodejs:nodejs20_debug_nonroot_amd64_debian12
//nodejs:nodejs20_debug_root_arm64_debian12
//nodejs:nodejs20_debug_nonroot_arm_debian12
//nodejs:nodejs20_root_arm_debian12
//nodejs:nodejs20_nonroot_amd64_debian12
//nodejs:nodejs20_debug_nonroot_s390x_debian12
//nodejs:nodejs20_debug_root_amd64_debian12
//nodejs:nodejs20_nonroot_amd64_debian12
//nodejs:nodejs20_nonroot_arm_debian12
//cc:debug_root_arm_debian12
//nodejs:nodejs20_debug_nonroot_arm64_debian12
//python3:debug_nonroot_arm64_debian12
//nodejs:nodejs20_root_ppc64le_debian12
//nodejs:nodejs20_debug_root_ppc64le_debian12
//nodejs:nodejs20_root_arm64_debian12
//nodejs:nodejs20_nonroot_arm64_debian12
//nodejs:nodejs20_root_amd64_debian12
//nodejs:nodejs20_debug_nonroot_ppc64le_debian12
//nodejs:nodejs20_root_arm64_debian12
//nodejs:nodejs20_debug_nonroot_s390x_debian12
//cc:cc_root_arm_debian12
//nodejs:nodejs22_root_amd64_debian12
//nodejs:nodejs22_debug_root_amd64_debian12
//nodejs:nodejs20_nonroot_arm_debian12
//nodejs:nodejs20_nonroot_s390x_debian12
//nodejs:nodejs20_nonroot_ppc64le_debian12
//nodejs:nodejs20_nonroot_s390x_debian12
//nodejs:nodejs22_debug_nonroot_amd64_debian12
//nodejs:nodejs20_root_s390x_debian12
//nodejs:nodejs22_nonroot_amd64_debian12
//nodejs:nodejs22_debug_root_arm_debian12
//nodejs:nodejs20_debug_root_s390x_debian12
//nodejs:nodejs22_nonroot_amd64_debian12
//nodejs:nodejs22_root_arm_debian12
//nodejs:nodejs20_debug_root_s390x_debian12
//nodejs:nodejs22_root_arm64_debian12
//nodejs:nodejs22_debug_nonroot_arm64_debian12
//nodejs:nodejs20_root_ppc64le_debian12
//nodejs:nodejs20_debug_nonroot_amd64_debian12
//nodejs:nodejs22_nonroot_arm_debian12
//nodejs:nodejs22_debug_root_arm64_debian12
//nodejs:nodejs20_debug_root_ppc64le_debian12
//nodejs:nodejs22_debug_root_s390x_debian12
//nodejs:nodejs22_root_ppc64le_debian12
//nodejs:nodejs22_debug_nonroot_s390x_debian12
//nodejs:nodejs22_nonroot_arm_debian12
//nodejs:nodejs22_root_s390x_debian12
//nodejs:nodejs22_nonroot_arm64_debian12
//nodejs:nodejs22_debug_root_arm64_debian12
//nodejs:nodejs22_nonroot_s390x_debian12
//nodejs:nodejs20_debug_nonroot_ppc64le_debian12
//nodejs:nodejs22_debug_nonroot_s390x_debian12
//nodejs:nodejs22_debug_nonroot_amd64_debian12
//nodejs:nodejs22_debug_nonroot_arm64_debian12
//nodejs:nodejs22_debug_nonroot_arm_debian12
//nodejs:nodejs22_nonroot_arm64_debian12
//nodejs:nodejs24_root_amd64_debian12
//nodejs:nodejs22_nonroot_ppc64le_debian12
//nodejs:nodejs20_debug_root_arm_debian12
//nodejs:nodejs22_debug_root_arm_debian12
//nodejs:nodejs20_root_arm_debian12
//nodejs:nodejs24_nonroot_amd64_debian12
//nodejs:nodejs22_debug_root_amd64_debian12
//nodejs:nodejs22_debug_nonroot_arm_debian12
//nodejs:nodejs24_root_arm64_debian12
//nodejs:nodejs22_debug_nonroot_ppc64le_debian12
//nodejs:nodejs24_nonroot_arm64_debian12
//nodejs:nodejs20_nonroot_ppc64le_debian12
//nodejs:nodejs24_nonroot_amd64_debian12
//nodejs:nodejs22_root_arm64_debian12
//nodejs:nodejs24_debug_nonroot_amd64_debian12
//nodejs:nodejs24_debug_nonroot_amd64_debian12
//nodejs:nodejs24_debug_nonroot_arm64_debian12
//nodejs:nodejs24_root_s390x_debian12
//nodejs:nodejs24_debug_nonroot_arm64_debian12
//nodejs:nodejs24_root_amd64_debian12
//nodejs:nodejs24_root_s390x_debian12
//nodejs:nodejs22_root_arm_debian12
//nodejs:nodejs24_nonroot_arm64_debian12
//nodejs:nodejs24_debug_root_amd64_debian12
//nodejs:nodejs24_debug_root_ppc64le_debian12
//nodejs:nodejs24_nonroot_ppc64le_debian12
//nodejs:nodejs24_debug_nonroot_ppc64le_debian12
//nodejs:nodejs22_debug_root_ppc64le_debian12
//nodejs:nodejs24_debug_root_s390x_debian12
//nodejs:nodejs24_debug_nonroot_ppc64le_debian12
//nodejs:nodejs22_debug_nonroot_ppc64le_debian12
//nodejs:nodejs24_root_arm64_debian12
//nodejs:nodejs22_debug_root_s390x_debian12
//nodejs:nodejs24_nonroot_s390x_debian12
//nodejs:nodejs24_debug_root_s390x_debian12
//nodejs:nodejs24_debug_root_ppc64le_debian12
//nodejs:nodejs22_root_s390x_debian12
//nodejs:nodejs24_debug_root_arm64_debian12
//nodejs:nodejs24_debug_nonroot_s390x_debian12
//nodejs:nodejs20_debug_root_arm_debian12
//nodejs:nodejs22_root_amd64_debian12
//nodejs:nodejs22_debug_root_ppc64le_debian12
//nodejs:nodejs22_nonroot_ppc64le_debian12
//nodejs:nodejs24_root_ppc64le_debian12
//nodejs:nodejs24_debug_root_amd64_debian12
//nodejs:nodejs24_debug_nonroot_s390x_debian12
//nodejs:nodejs22_root_ppc64le_debian12
//nodejs:nodejs24_debug_root_arm64_debian12
//nodejs:nodejs24_root_ppc64le_debian12
//nodejs:nodejs24_nonroot_s390x_debian12
//nodejs:nodejs20_root_s390x_debian12
//nodejs:nodejs24_nonroot_ppc64le_debian12
//nodejs:nodejs22_nonroot_s390x_debian12You can check the details in the report here |
|
Oh right I changed the order of some things |
fixes #1887