Rework build into reusable pieces

[loosebazooka]

• only static, base and cc
• standardize their debug image naming (//image:image_debug instead of //image:debug)

Summary

First step at organizing the build into reusable parts. Still need to rework java, node, python.
It might even make sense to pull out the deb list from each and push that through the defs in the BUILD, but this should be a decent start.

[gemini-code-assist]

Summary of Changes

Hello @loosebazooka, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request initiates a significant refactoring of the project's build system, aiming to enhance modularity and reusability. The primary focus of this initial phase is on the static, base, and cc image types, where build logic has been broken down into more granular, dedicated .bzl files. This change also standardizes the naming convention for debug images, contributing to a more consistent and maintainable build process. Future work is planned to extend this modularization to other language-specific builds like Java, Node.js, and Python.

Highlights

• Build System Rework: The build system has been refactored into more reusable and modular pieces, starting with the static, base, and cc image definitions.
• Standardized Debug Image Naming: Debug image naming conventions have been standardized to follow the pattern //image:image_debug instead of the previous //image:debug.
• New Build Files and Structure: New .bzl and BUILD files have been introduced for static and cc images, centralizing their definitions and improving organization. The distro.bzl file has been moved to the root directory for broader accessibility.

Ignored Files

• Ignored by pattern: .github/workflows/** (1)
  • .github/workflows/image-check.yaml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the build process into reusable components, focusing on static, base, and cc images. It standardizes debug image naming and aims to organize the build for better maintainability. The changes involve moving definitions to separate .bzl files and adjusting image configurations.

[github-actions]

🌳 🔄 Image Check

This pull request has modified the following images:

//base:base_debug_root_amd64_debian12
//base:base_debug_root_arm64_debian12
//base:base_debug_nonroot_amd64_debian12
//base:base_debug_root_arm64_debian12
//base:base_debug_root_amd64_debian12
//base:base_debug_root_arm_debian12
//base:base_debug_nonroot_s390x_debian12
//base:base_debug_nonroot_arm64_debian12
//base:base_debug_root_s390x_debian12
//base:base_debug_root_ppc64le_debian12
//base:base_debug_nonroot_ppc64le_debian12
//base:base_debug_nonroot_ppc64le_debian12
//base:base_debug_root_arm_debian12
//base:base_debug_nonroot_arm_debian12
//base:base_debug_nonroot_amd64_debian12
//base:base_debug_root_s390x_debian12
//base:base_debug_nonroot_s390x_debian13
//base:base_debug_nonroot_arm64_debian13
//base:base_debug_nonroot_arm64_debian12
//base:base_debug_nonroot_arm_debian12
//base:base_nossl_debug_nonroot_amd64_debian12
//base:base_debug_root_ppc64le_debian12
//base:base_nossl_debug_root_arm64_debian12
//base:base_debug_root_amd64_debian13
//base:base_debug_nonroot_amd64_debian13
//base:base_debug_root_arm64_debian13
//base:base_debug_nonroot_s390x_debian12
//base:base_nossl_debug_nonroot_arm_debian12
//base:base_debug_root_arm_debian13
//base:base_nossl_debug_root_arm_debian12
//base:base_nossl_debug_nonroot_arm64_debian12
//base:base_nossl_debug_nonroot_ppc64le_debian12
//base:base_nossl_debug_nonroot_amd64_debian12
//base:base_nossl_debug_root_ppc64le_debian12
//base:base_nossl_debug_nonroot_arm_debian12
//base:base_nossl_debug_root_ppc64le_debian12
//base:base_debug_nonroot_arm_debian13
//base:base_nossl_debug_nonroot_arm64_debian12
//base:base_nossl_debug_root_amd64_debian12
//base:base_nossl_debug_root_arm_debian12
//base:base_nossl_debug_nonroot_amd64_debian13
//base:base_nossl_debug_root_s390x_debian13
//base:base_nossl_debug_root_amd64_debian13
//base:base_nossl_debug_root_ppc64le_debian13
//base:base_nossl_debug_nonroot_ppc64le_debian13
//base:base_nossl_debug_nonroot_arm_debian13
//base:base_nossl_debug_root_arm64_debian12
//base:base_debug_root_ppc64le_debian13
//base:base_nossl_debug_nonroot_ppc64le_debian12
//cc:cc_debug_root_amd64_debian12
//base:base_debug_nonroot_ppc64le_debian13
//base:base_nossl_debug_nonroot_s390x_debian12
//base:base_nossl_debug_nonroot_s390x_debian12
//base:base_nossl_debug_root_s390x_debian12
//base:base_nossl_debug_nonroot_arm64_debian13
//cc:cc_debug_nonroot_amd64_debian12
//cc:cc_debug_nonroot_amd64_debian12
//cc:cc_debug_root_arm64_debian12
//cc:cc_debug_nonroot_arm64_debian12
//cc:cc_debug_nonroot_arm64_debian12
//cc:cc_debug_root_s390x_debian12
//base:base_nossl_debug_root_amd64_debian12
//cc:cc_debug_nonroot_arm_debian12
//cc:cc_debug_root_arm_debian12
//base:base_nossl_debug_root_arm64_debian13
//cc:cc_debug_root_ppc64le_debian12
//cc:cc_debug_root_ppc64le_debian12
//cc:cc_debug_root_amd64_debian12
//cc:cc_debug_nonroot_s390x_debian12
//cc:cc_debug_root_arm_debian13
//base:base_nossl_debug_root_arm_debian13
//base:base_debug_root_s390x_debian13
//cc:cc_debug_root_arm64_debian13
//cc:cc_debug_nonroot_ppc64le_debian12
//cc:cc_debug_root_amd64_debian13
//cc:cc_debug_nonroot_ppc64le_debian12
//python3:debug_nonroot_amd64_debian12
//python3:debug_root_amd64_debian12
//cc:cc_debug_nonroot_arm_debian12
//cc:cc_debug_root_arm_debian12
//cc:cc_debug_nonroot_amd64_debian13
//cc:cc_debug_nonroot_s390x_debian12
//cc:cc_debug_nonroot_s390x_debian13
//cc:cc_debug_nonroot_arm_debian13
//python3:debug_root_arm64_debian12
//base:base_nossl_debug_root_s390x_debian12
//python3:debug_nonroot_arm64_debian12
//cc:cc_debug_root_arm64_debian12
//cc:cc_debug_nonroot_ppc64le_debian13
//cc:cc_debug_nonroot_arm64_debian13
//cc:cc_debug_root_s390x_debian13
//python3:debug_nonroot_amd64_debian12
//base:base_nossl_debug_nonroot_s390x_debian13
//python3:debug_nonroot_arm64_debian12
//nodejs:nodejs20_debug_nonroot_arm64_debian12
//nodejs:nodejs20_debug_root_arm64_debian12
//nodejs:nodejs20_debug_nonroot_arm64_debian12
//nodejs:nodejs20_debug_root_arm64_debian12
//nodejs:nodejs20_debug_root_amd64_debian12
//cc:cc_debug_root_ppc64le_debian13
//nodejs:nodejs20_debug_nonroot_s390x_debian12
//nodejs:nodejs20_debug_nonroot_arm_debian12
//nodejs:nodejs20_debug_root_s390x_debian12
//nodejs:nodejs20_debug_nonroot_arm_debian12
//nodejs:nodejs20_debug_root_arm_debian12
//nodejs:nodejs20_debug_nonroot_ppc64le_debian12
//nodejs:nodejs20_debug_root_arm_debian12
//nodejs:nodejs22_debug_root_amd64_debian12
//nodejs:nodejs20_debug_root_amd64_debian12
//nodejs:nodejs22_debug_nonroot_arm64_debian12
//nodejs:nodejs20_debug_root_ppc64le_debian12
//nodejs:nodejs22_debug_nonroot_arm64_debian12
//nodejs:nodejs22_debug_root_amd64_debian12
//nodejs:nodejs22_debug_root_arm_debian12
//cc:cc_debug_root_s390x_debian12
//nodejs:nodejs20_debug_nonroot_s390x_debian12
//nodejs:nodejs22_debug_nonroot_arm_debian12
//nodejs:nodejs22_debug_root_arm_debian12
//nodejs:nodejs22_debug_root_arm64_debian12
//python3:debug_root_arm64_debian12
//nodejs:nodejs20_debug_nonroot_amd64_debian12
//nodejs:nodejs22_debug_nonroot_arm_debian12
//nodejs:nodejs20_debug_nonroot_ppc64le_debian12
//nodejs:nodejs22_debug_root_s390x_debian12
//nodejs:nodejs20_debug_nonroot_amd64_debian12
//nodejs:nodejs22_debug_root_s390x_debian12
//nodejs:nodejs22_debug_nonroot_s390x_debian12
//nodejs:nodejs22_debug_nonroot_ppc64le_debian12
//nodejs:nodejs24_debug_nonroot_amd64_debian12
//nodejs:nodejs22_debug_root_arm64_debian12
//nodejs:nodejs24_debug_nonroot_arm64_debian12
//nodejs:nodejs24_debug_root_amd64_debian12
//nodejs:nodejs22_debug_nonroot_amd64_debian12
//nodejs:nodejs20_debug_root_s390x_debian12
//nodejs:nodejs24_debug_root_s390x_debian12
//nodejs:nodejs20_debug_root_ppc64le_debian12
//nodejs:nodejs24_debug_root_arm64_debian12
//python3:debug_root_amd64_debian12
//nodejs:nodejs22_debug_root_ppc64le_debian12
//nodejs:nodejs24_debug_root_amd64_debian12
//nodejs:nodejs22_debug_nonroot_ppc64le_debian12
//nodejs:nodejs22_debug_nonroot_s390x_debian12
//nodejs:nodejs24_debug_root_s390x_debian12
//nodejs:nodejs24_debug_root_ppc64le_debian12
//nodejs:nodejs22_debug_root_ppc64le_debian12
//nodejs:nodejs24_debug_nonroot_ppc64le_debian12
//nodejs:nodejs24_debug_nonroot_amd64_debian12
//nodejs:nodejs24_debug_nonroot_s390x_debian12
//java:java_base_debug_nonroot_ppc64le_debian12
//java:java_base_debug_root_ppc64le_debian12
//java:java_base_debug_root_s390x_debian12
//java:java_base_debug_root_amd64_debian12
//java:java_base_debug_root_amd64_debian12
//nodejs:nodejs24_debug_nonroot_ppc64le_debian12
//nodejs:nodejs24_debug_nonroot_s390x_debian12
//java:java_base_debug_nonroot_s390x_debian12
//java:java_base_debug_nonroot_arm64_debian12
//java:java_base_debug_nonroot_amd64_debian12
//nodejs:nodejs24_debug_nonroot_arm64_debian12
//java:java_base_debug_nonroot_amd64_debian12
//java:java_base_debug_root_arm64_debian12
//nodejs:nodejs24_debug_root_ppc64le_debian12
//nodejs:nodejs22_debug_nonroot_amd64_debian12
//nodejs:nodejs24_debug_root_arm64_debian12
//java:java17_debug_nonroot_amd64_debian12
//java:java21_debug_root_amd64_debian12
//java:java17_debug_nonroot_ppc64le_debian12
//java:java21_debug_root_ppc64le_debian12
//java:java17_debug_root_ppc64le_debian12
//java:java21_debug_root_s390x_debian12
//java:java21_debug_nonroot_ppc64le_debian12
//java:java17_debug_nonroot_s390x_debian12
//java:java25_debug_root_amd64_debian13
//java:java21_debug_nonroot_arm64_debian12
//java:java25_debug_nonroot_ppc64le_debian13
//java:java25_debug_root_ppc64le_debian13
//java:java17_debug_root_s390x_debian12
//java:java17_debug_nonroot_amd64_debian12
//java:java17_debug_root_amd64_debian12
//java:java25_debug_nonroot_s390x_debian13
//java:java25_debug_root_s390x_debian13
//java:java25_debug_root_arm64_debian13
//java:java21_debug_nonroot_amd64_debian12
//java:java17_debug_root_amd64_debian12
//java:java17_debug_nonroot_arm64_debian12
//java:java25_debug_nonroot_amd64_debian13
//java:java21_debug_nonroot_s390x_debian12
//java:java25_debug_nonroot_arm64_debian13
//java:java21_debug_root_arm64_debian12
//java:java17_debug_root_arm64_debian12

You can check the details in the report here

[loosebazooka]

hrmm... we shouldn't have image changes

oh it's the order of busybox because we build base_debug off static_debug now (so we only see diffs in debug images)