-
Notifications
You must be signed in to change notification settings - Fork 1.3k
rework python build #1918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rework python build #1918
Conversation
this doesn't add debian13 support, that will require some work to get builds from somewhere else Signed-off-by: Appu Goundan <[email protected]>
Summary of ChangesHello @loosebazooka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request undertakes a significant refactoring of the Python build system. It extracts the detailed definitions for Python OCI images, image indices, and container structure tests into a dedicated Starlark file, Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the Python build logic by extracting it into a new python.bzl file, which significantly improves modularity and cleans up the BUILD file. The overall change is a positive step. My review includes suggestions to align the new Starlark code with best practices, such as preferring for loops over list comprehensions for generating rules, and a more critical fix to add missing tests for the newly created debug image variants.
|
🌳 🔄 Image Check |
this doesn't add debian13 support, that will require some work to get builds from somewhere else