Skip to content

Conversation

@loosebazooka
Copy link
Member

this doesn't add debian13 support, that will require some work to get builds from somewhere else

this doesn't add debian13 support, that will require some work to
get builds from somewhere else

Signed-off-by: Appu Goundan <[email protected]>
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @loosebazooka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request undertakes a significant refactoring of the Python build system. It extracts the detailed definitions for Python OCI images, image indices, and container structure tests into a dedicated Starlark file, python3/python.bzl. This modularization simplifies the main python3/BUILD file, making it more readable and maintainable by abstracting away the complex rule generation logic into reusable functions. The change also includes an update to how debug Python variants are named within the build configuration.

Highlights

  • Refactoring Python Build Logic: The core logic for building Python OCI images and their associated tests has been moved from python3/BUILD into a new Starlark file, python3/python.bzl.
  • Modularization: This change significantly cleans up python3/BUILD by replacing verbose rule definitions with calls to helper functions defined in python3/python.bzl, improving readability and maintainability.
  • Debug Variant Naming Consistency: The main BUILD file now correctly references python3_debug for debug Python variations, aligning with the new modular structure and naming conventions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the Python build logic by extracting it into a new python.bzl file, which significantly improves modularity and cleans up the BUILD file. The overall change is a positive step. My review includes suggestions to align the new Starlark code with best practices, such as preferring for loops over list comprehensions for generating rules, and a more critical fix to add missing tests for the newly created debug image variants.

@github-actions
Copy link
Contributor

🌳 🔄 Image Check
This pull request doesn't make any changes to the images. 👍
You can check the details in the report here

@loosebazooka loosebazooka merged commit 48b385c into main Nov 3, 2025
11 checks passed
@loosebazooka loosebazooka deleted the rework_python branch November 3, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants