-
Notifications
You must be signed in to change notification settings - Fork 1.3k
fix java21-debian13 tagging #1919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Appu Goundan <[email protected]>
Summary of ChangesHello @loosebazooka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue where Java 21 image tags were incorrectly hardcoded to Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request correctly updates the tagging for Java 21 images to dynamically include the distro in the image name, moving away from the hardcoded debian12. This change improves the flexibility and maintainability of the image tagging system, especially with the introduction of debian13 as a preview distro. The changes are well-targeted and address the issue effectively.
Signed-off-by: Appu Goundan <[email protected]>
|
🌳 🔄 Image Check This pull request has modified the following images: //java:java21_root_amd64_debian13 (new)
//java:java21_root_arm64_debian13 (new)
//java:java21_root_s390x_debian13 (new)
//java:java21_root_ppc64le_debian13 (new)
//java:java21_nonroot_amd64_debian13 (new)
//java:java21_nonroot_arm64_debian13 (new)
//java:java21_nonroot_s390x_debian13 (new)
//java:java21_nonroot_ppc64le_debian13 (new)
//java:java21_debug_root_amd64_debian13 (new)
//java:java21_debug_root_arm64_debian13 (new)
//java:java21_debug_root_s390x_debian13 (new)
//java:java21_debug_root_ppc64le_debian13 (new)
//java:java21_debug_nonroot_amd64_debian13 (new)
//java:java21_debug_nonroot_arm64_debian13 (new)
//java:java21_debug_nonroot_s390x_debian13 (new)
//java:java21_debug_nonroot_ppc64le_debian13 (new)
//java:java21_root_debian13 (new)
//java:java21_nonroot_debian13 (new)
//java:java21_debug_root_debian13 (new)
//java:java21_debug_nonroot_debian13 (new)
//java:java21_debug_nonroot_s390x_debian12
//java:java21_debug_root_amd64_debian12
//java:java21_root_ppc64le_debian12
//java:java21_debug_nonroot_amd64_debian12
//java:java21_debug_root_ppc64le_debian12
//java:java21_debug_nonroot_ppc64le_debian12
//java:java21_root_amd64_debian12
//java:java21_debug_root_arm64_debian12
//java:java21_nonroot_amd64_debian12
//java:java21_debug_nonroot_arm64_debian12
//java:java21_root_arm64_debian12
//java:java21_nonroot_arm64_debian12
//java:java21_nonroot_ppc64le_debian12
//java:java21_debug_root_s390x_debian12
//java:java21_root_s390x_debian12
//java:java21_nonroot_s390x_debian12You can check the details in the report here |
No description provided.