Skip to content

Conversation

@loosebazooka
Copy link
Member

No description provided.

Signed-off-by: Appu Goundan <[email protected]>
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @loosebazooka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where Java 21 image tags were incorrectly hardcoded to debian12 within the build configuration. The change introduces a dynamic distro variable into the tagging logic, ensuring that image tags accurately reflect the target distribution. This improves the correctness and flexibility of the build process for Java 21 images across various Debian versions.

Highlights

  • Java 21 Image Tagging: Updated the BUILD file to dynamically include the distribution name (e.g., debian13) in the java21 image tags, replacing the previously hardcoded debian12.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request correctly updates the tagging for Java 21 images to dynamically include the distro in the image name, moving away from the hardcoded debian12. This change improves the flexibility and maintainability of the image tagging system, especially with the introduction of debian13 as a preview distro. The changes are well-targeted and address the issue effectively.

@loosebazooka loosebazooka merged commit 40f9b1e into main Nov 4, 2025
11 checks passed
@loosebazooka loosebazooka deleted the fix_java21_tagging branch November 4, 2025 15:26
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

🌳 🔄 Image Check

This pull request has modified the following images:

//java:java21_root_amd64_debian13 (new)
//java:java21_root_arm64_debian13 (new)
//java:java21_root_s390x_debian13 (new)
//java:java21_root_ppc64le_debian13 (new)
//java:java21_nonroot_amd64_debian13 (new)
//java:java21_nonroot_arm64_debian13 (new)
//java:java21_nonroot_s390x_debian13 (new)
//java:java21_nonroot_ppc64le_debian13 (new)
//java:java21_debug_root_amd64_debian13 (new)
//java:java21_debug_root_arm64_debian13 (new)
//java:java21_debug_root_s390x_debian13 (new)
//java:java21_debug_root_ppc64le_debian13 (new)
//java:java21_debug_nonroot_amd64_debian13 (new)
//java:java21_debug_nonroot_arm64_debian13 (new)
//java:java21_debug_nonroot_s390x_debian13 (new)
//java:java21_debug_nonroot_ppc64le_debian13 (new)
//java:java21_root_debian13 (new)
//java:java21_nonroot_debian13 (new)
//java:java21_debug_root_debian13 (new)
//java:java21_debug_nonroot_debian13 (new)
//java:java21_debug_nonroot_s390x_debian12
//java:java21_debug_root_amd64_debian12
//java:java21_root_ppc64le_debian12
//java:java21_debug_nonroot_amd64_debian12
//java:java21_debug_root_ppc64le_debian12
//java:java21_debug_nonroot_ppc64le_debian12
//java:java21_root_amd64_debian12
//java:java21_debug_root_arm64_debian12
//java:java21_nonroot_amd64_debian12
//java:java21_debug_nonroot_arm64_debian12
//java:java21_root_arm64_debian12
//java:java21_nonroot_arm64_debian12
//java:java21_nonroot_ppc64le_debian12
//java:java21_debug_root_s390x_debian12
//java:java21_root_s390x_debian12
//java:java21_nonroot_s390x_debian12

You can check the details in the report here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants