-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Bumping node archives to latest stable versions #1926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Distroless Bot <[email protected]>
Summary of ChangesHello @distroless-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the project's Node.js dependencies to the latest stable patch release, version 24.11.1. This ensures that the build system utilizes the most current and stable Node.js runtime, incorporating any recent bug fixes or security enhancements for all supported architectures. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
🌳 🔧 Config Check This pull request has not modified the root BUILD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Node.js archives to version 24.11.1. The changes are consistent across the Bazel extension file, the lock file, and the test data. I've suggested a refactoring in private/extensions/node.bzl to improve maintainability by reducing code duplication for the Node.js 24 archive definitions. This will make future updates easier to manage.
| node_archive( | ||
| name = "nodejs24_amd64", | ||
| sha256 = "b3c071cdf47aab867c3b2aa287257df12ec5d7c962bf922b32fd33226c4295fd", | ||
| strip_prefix = "node-v24.11.0-linux-x64/", | ||
| urls = ["https://nodejs.org/dist/v24.11.0/node-v24.11.0-linux-x64.tar.gz"], | ||
| version = "24.11.0", | ||
| sha256 = "58a5ff5cc8f2200e458bea22e329d5c1994aa1b111d499ca46ec2411d58239ca", | ||
| strip_prefix = "node-v24.11.1-linux-x64/", | ||
| urls = ["https://nodejs.org/dist/v24.11.1/node-v24.11.1-linux-x64.tar.gz"], | ||
| version = "24.11.1", | ||
| architecture = "amd64", | ||
| control = "//nodejs:control", | ||
| ) | ||
|
|
||
| node_archive( | ||
| name = "nodejs24_arm64", | ||
| sha256 = "4786d00c4d259d3ff0b2328307f764ef3ced65f2d6e9502d433e68d66238509d", | ||
| strip_prefix = "node-v24.11.0-linux-arm64/", | ||
| urls = ["https://nodejs.org/dist/v24.11.0/node-v24.11.0-linux-arm64.tar.gz"], | ||
| version = "24.11.0", | ||
| sha256 = "0dc93ec5c798b0d347f068db6d205d03dea9a71765e6a53922b682b91265d71f", | ||
| strip_prefix = "node-v24.11.1-linux-arm64/", | ||
| urls = ["https://nodejs.org/dist/v24.11.1/node-v24.11.1-linux-arm64.tar.gz"], | ||
| version = "24.11.1", | ||
| architecture = "arm64", | ||
| control = "//nodejs:control", | ||
| ) | ||
|
|
||
| node_archive( | ||
| name = "nodejs24_ppc64le", | ||
| sha256 = "7e7ba4326fe8588f11e763c55217bcf45f5e0b7bcbf1e26bbbbb2225a9ae4721", | ||
| strip_prefix = "node-v24.11.0-linux-ppc64le/", | ||
| urls = ["https://nodejs.org/dist/v24.11.0/node-v24.11.0-linux-ppc64le.tar.gz"], | ||
| version = "24.11.0", | ||
| sha256 = "cd41407f3352de2f066ea26c5c5d0ea9b6362374d6b618385a9f2e9dad220616", | ||
| strip_prefix = "node-v24.11.1-linux-ppc64le/", | ||
| urls = ["https://nodejs.org/dist/v24.11.1/node-v24.11.1-linux-ppc64le.tar.gz"], | ||
| version = "24.11.1", | ||
| architecture = "ppc64le", | ||
| control = "//nodejs:control", | ||
| ) | ||
|
|
||
| node_archive( | ||
| name = "nodejs24_s390x", | ||
| sha256 = "7af0d92e74b07a2b8e91089ee4fccc7b5433fd8b63259bced3a34668998cbdf7", | ||
| strip_prefix = "node-v24.11.0-linux-s390x/", | ||
| urls = ["https://nodejs.org/dist/v24.11.0/node-v24.11.0-linux-s390x.tar.gz"], | ||
| version = "24.11.0", | ||
| sha256 = "5d4c8bca5f8f2593f9081dee39834760e85a16fa61c950f3e86ec85996f00550", | ||
| strip_prefix = "node-v24.11.1-linux-s390x/", | ||
| urls = ["https://nodejs.org/dist/v24.11.1/node-v24.11.1-linux-s390x.tar.gz"], | ||
| version = "24.11.1", | ||
| architecture = "s390x", | ||
| control = "//nodejs:control", | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To improve maintainability and reduce code duplication, you can define the version and architecture-specific data in a dictionary and use a loop to generate the node_archive calls. This will make future version bumps for Node.js 24 easier and less error-prone.
_NODE24_VERSION = "24.11.1"
_NODE24_ARCHS = {
"amd64": ("x64", "58a5ff5cc8f2200e458bea22e329d5c1994aa1b111d499ca46ec2411d58239ca"),
"arm64": ("arm64", "0dc93ec5c798b0d347f068db6d205d03dea9a71765e6a53922b682b91265d71f"),
"ppc64le": ("ppc64le", "cd41407f3352de2f066ea26c5c5d0ea9b6362374d6b618385a9f2e9dad220616"),
"s390x": ("s390x", "5d4c8bca5f8f2593f9081dee39834760e85a16fa61c950f3e86ec85996f00550"),
}
for _arch, (_suffix, _sha) in _NODE24_ARCHS.items():
node_archive(
name = "nodejs24_" + _arch,
sha256 = _sha,
strip_prefix = "node-v{version}-linux-{suffix}/".format(version = _NODE24_VERSION, suffix = _suffix),
urls = ["https://nodejs.org/dist/v{version}/node-v{version}-linux-{suffix}.tar.gz".format(version = _NODE24_VERSION, suffix = _suffix)],
version = _NODE24_VERSION,
architecture = _arch,
control = "//nodejs:control",
)
|
🌳 🔄 Image Check This pull request has modified the following images: //nodejs:nodejs24_debug_nonroot_amd64_debian12
//nodejs:nodejs24_debug_root_amd64_debian12
//nodejs:nodejs24_nonroot_arm64_debian12
//nodejs:nodejs24_root_amd64_debian12
//nodejs:nodejs24_debug_nonroot_amd64_debian12
//nodejs:nodejs24_root_arm64_debian12
//nodejs:nodejs24_debug_nonroot_arm64_debian12
//nodejs:nodejs24_nonroot_arm64_debian12
//nodejs:nodejs24_root_s390x_debian12
//nodejs:nodejs24_root_arm64_debian12
//nodejs:nodejs24_root_s390x_debian12
//nodejs:nodejs24_debug_nonroot_arm64_debian12
//nodejs:nodejs24_nonroot_amd64_debian12
//nodejs:nodejs24_nonroot_amd64_debian12
//nodejs:nodejs24_nonroot_ppc64le_debian12
//nodejs:nodejs24_root_amd64_debian12
//nodejs:nodejs24_nonroot_s390x_debian12
//nodejs:nodejs24_debug_nonroot_s390x_debian12
//nodejs:nodejs24_root_amd64_debian13
//nodejs:nodejs24_root_arm64_debian13
//nodejs:nodejs24_debug_nonroot_ppc64le_debian12
//nodejs:nodejs24_debug_nonroot_arm64_debian13
//nodejs:nodejs24_debug_root_amd64_debian12
//nodejs:nodejs24_root_ppc64le_debian12
//nodejs:nodejs24_root_ppc64le_debian13
//nodejs:nodejs24_debug_root_arm64_debian13
//nodejs:nodejs24_nonroot_s390x_debian12
//nodejs:nodejs24_debug_root_arm64_debian12
//nodejs:nodejs24_nonroot_ppc64le_debian12
//nodejs:nodejs24_debug_nonroot_amd64_debian13
//nodejs:nodejs24_debug_root_s390x_debian12
//nodejs:nodejs24_debug_nonroot_ppc64le_debian12
//nodejs:nodejs24_debug_root_amd64_debian13
//nodejs:nodejs24_nonroot_ppc64le_debian13
//nodejs:nodejs24_debug_root_ppc64le_debian12
//nodejs:nodejs24_debug_root_s390x_debian12
//nodejs:nodejs24_nonroot_s390x_debian13
//nodejs:nodejs24_debug_nonroot_ppc64le_debian13
//nodejs:nodejs24_nonroot_arm64_debian13
//nodejs:nodejs24_root_ppc64le_debian12
//nodejs:nodejs24_root_s390x_debian13
//nodejs:nodejs24_debug_root_ppc64le_debian12
//nodejs:nodejs24_debug_root_arm64_debian12
//nodejs:nodejs24_debug_nonroot_s390x_debian12
//nodejs:nodejs24_nonroot_amd64_debian13
//nodejs:nodejs24_debug_root_s390x_debian13
//nodejs:nodejs24_debug_nonroot_s390x_debian13
//nodejs:nodejs24_debug_root_ppc64le_debian13You can check the details in the report here |
Signed-off-by: Distroless Bot [email protected]