publish java-base-debian13 #1940
Conversation
Summary of ChangesHello @loosebazooka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the flexibility of the Java base image build system by generalizing the distribution handling. Instead of being tied to a specific Debian version like Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
🌳 🔧 Config Check This pull request has modified the root BUILD --- /dev/fd/63 2025-12-03 18:23:20.665565939 +0000
+++ /dev/fd/62 2025-12-03 18:23:20.665565939 +0000
@@ -234,6 +234,26 @@
{REGISTRY}/{PROJECT_ID}/java-base-debian12:nonroot-arm64 //java:java_base_nonroot_arm64_debian12
{REGISTRY}/{PROJECT_ID}/java-base-debian12:nonroot-ppc64le //java:java_base_nonroot_ppc64le_debian12
{REGISTRY}/{PROJECT_ID}/java-base-debian12:nonroot-s390x //java:java_base_nonroot_s390x_debian12
+{REGISTRY}/{PROJECT_ID}/java-base-debian13:debug //java:java_base_debug_root_debian13
+{REGISTRY}/{PROJECT_ID}/java-base-debian13:debug-amd64 //java:java_base_debug_root_amd64_debian13
+{REGISTRY}/{PROJECT_ID}/java-base-debian13:debug-arm64 //java:java_base_debug_root_arm64_debian13
+{REGISTRY}/{PROJECT_ID}/java-base-debian13:debug-nonroot //java:java_base_debug_nonroot_debian13
+{REGISTRY}/{PROJECT_ID}/java-base-debian13:debug-nonroot-amd64 //java:java_base_debug_nonroot_amd64_debian13
+{REGISTRY}/{PROJECT_ID}/java-base-debian13:debug-nonroot-arm64 //java:java_base_debug_nonroot_arm64_debian13
+{REGISTRY}/{PROJECT_ID}/java-base-debian13:debug-nonroot-ppc64le //java:java_base_debug_nonroot_ppc64le_debian13
+{REGISTRY}/{PROJECT_ID}/java-base-debian13:debug-nonroot-s390x //java:java_base_debug_nonroot_s390x_debian13
+{REGISTRY}/{PROJECT_ID}/java-base-debian13:debug-ppc64le //java:java_base_debug_root_ppc64le_debian13
+{REGISTRY}/{PROJECT_ID}/java-base-debian13:debug-s390x //java:java_base_debug_root_s390x_debian13
+{REGISTRY}/{PROJECT_ID}/java-base-debian13:latest //java:java_base_root_debian13
+{REGISTRY}/{PROJECT_ID}/java-base-debian13:latest-amd64 //java:java_base_root_amd64_debian13
+{REGISTRY}/{PROJECT_ID}/java-base-debian13:latest-arm64 //java:java_base_root_arm64_debian13
+{REGISTRY}/{PROJECT_ID}/java-base-debian13:latest-ppc64le //java:java_base_root_ppc64le_debian13
+{REGISTRY}/{PROJECT_ID}/java-base-debian13:latest-s390x //java:java_base_root_s390x_debian13
+{REGISTRY}/{PROJECT_ID}/java-base-debian13:nonroot //java:java_base_nonroot_debian13
+{REGISTRY}/{PROJECT_ID}/java-base-debian13:nonroot-amd64 //java:java_base_nonroot_amd64_debian13
+{REGISTRY}/{PROJECT_ID}/java-base-debian13:nonroot-arm64 //java:java_base_nonroot_arm64_debian13
+{REGISTRY}/{PROJECT_ID}/java-base-debian13:nonroot-ppc64le //java:java_base_nonroot_ppc64le_debian13
+{REGISTRY}/{PROJECT_ID}/java-base-debian13:nonroot-s390x //java:java_base_nonroot_s390x_debian13
{REGISTRY}/{PROJECT_ID}/java-base:debug //java:java_base_debug_root_amd64_debian12
{REGISTRY}/{PROJECT_ID}/java-base:debug-nonroot //java:java_base_debug_nonroot_amd64_debian12
{REGISTRY}/{PROJECT_ID}/java-base:latest //java:java_base_root_amd64_debian12 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to publish java-base images for debian13. The changes correctly generalize most of the image definitions in the BUILD file. However, I found a critical issue in one of the dictionary comprehensions where the loop ordering is incorrect and architectures are hardcoded for debian12, which could lead to incorrect image builds. I've provided a specific comment with a suggested fix for this.
Signed-off-by: Appu Goundan <[email protected]>
loosebazooka
force-pushed
the
java-base-deb13
branch
from
3665bc1 to
7aa6f9e
Compare
|
🌳 🔄 Image Check This pull request has modified the following images: //java:java_base_root_amd64_debian13 (new)
//java:java_base_nonroot_amd64_debian13 (new)
//java:java_base_debug_root_amd64_debian13 (new)
//java:java_base_debug_nonroot_amd64_debian13 (new)
//java:java_base_root_arm64_debian13 (new)
//java:java_base_nonroot_arm64_debian13 (new)
//java:java_base_debug_root_arm64_debian13 (new)
//java:java_base_debug_nonroot_arm64_debian13 (new)
//java:java_base_root_s390x_debian13 (new)
//java:java_base_nonroot_s390x_debian13 (new)
//java:java_base_debug_root_s390x_debian13 (new)
//java:java_base_debug_nonroot_s390x_debian13 (new)
//java:java_base_root_ppc64le_debian13 (new)
//java:java_base_nonroot_ppc64le_debian13 (new)
//java:java_base_debug_root_ppc64le_debian13 (new)
//java:java_base_debug_nonroot_ppc64le_debian13 (new)
//java:java_base_root_debian13 (new)
//java:java_base_nonroot_debian13 (new)
//java:java_base_debug_root_debian13 (new)
//java:java_base_debug_nonroot_debian13 (new)You can check the details in the report here |
2 participants
No description provided.