First python3-debian13 images for testing#1970
Conversation
Summary of ChangesHello @loosebazooka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces initial support for Python 3.13 on Debian 13 (Trixie) within the distroless image ecosystem. It involves updating the build configurations to generate new Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
🌳 🔧 Config Check This pull request has modified the root BUILD --- /dev/fd/63 2026-01-14 19:04:20.551589261 +0000
+++ /dev/fd/62 2026-01-14 19:04:20.551589261 +0000
@@ -566,6 +566,18 @@
{REGISTRY}/{PROJECT_ID}/python3-debian12:nonroot //python3:python3_nonroot_debian12
{REGISTRY}/{PROJECT_ID}/python3-debian12:nonroot-amd64 //python3:python3_nonroot_amd64_debian12
{REGISTRY}/{PROJECT_ID}/python3-debian12:nonroot-arm64 //python3:python3_nonroot_arm64_debian12
+{REGISTRY}/{PROJECT_ID}/python3-debian13:debug //python3:python3_debug_root_debian13
+{REGISTRY}/{PROJECT_ID}/python3-debian13:debug-amd64 //python3:python3_debug_root_amd64_debian13
+{REGISTRY}/{PROJECT_ID}/python3-debian13:debug-arm64 //python3:python3_debug_root_arm64_debian13
+{REGISTRY}/{PROJECT_ID}/python3-debian13:debug-nonroot //python3:python3_debug_nonroot_debian13
+{REGISTRY}/{PROJECT_ID}/python3-debian13:debug-nonroot-amd64 //python3:python3_debug_nonroot_amd64_debian13
+{REGISTRY}/{PROJECT_ID}/python3-debian13:debug-nonroot-arm64 //python3:python3_debug_nonroot_arm64_debian13
+{REGISTRY}/{PROJECT_ID}/python3-debian13:latest //python3:python3_root_debian13
+{REGISTRY}/{PROJECT_ID}/python3-debian13:latest-amd64 //python3:python3_root_amd64_debian13
+{REGISTRY}/{PROJECT_ID}/python3-debian13:latest-arm64 //python3:python3_root_arm64_debian13
+{REGISTRY}/{PROJECT_ID}/python3-debian13:nonroot //python3:python3_nonroot_debian13
+{REGISTRY}/{PROJECT_ID}/python3-debian13:nonroot-amd64 //python3:python3_nonroot_amd64_debian13
+{REGISTRY}/{PROJECT_ID}/python3-debian13:nonroot-arm64 //python3:python3_nonroot_arm64_debian13
{REGISTRY}/{PROJECT_ID}/python3:debug //python3:python3_debug_root_debian12
{REGISTRY}/{PROJECT_ID}/python3:debug-amd64 //python3:python3_debug_root_amd64_debian12
{REGISTRY}/{PROJECT_ID}/python3:debug-arm64 //python3:python3_debug_root_arm64_debian12 |
loosebazooka
force-pushed
the
python3-deb13
branch
from
32c914b to
c0bd409
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces initial support for Python 3.13 on Debian 13, alongside refactoring the package management for Python images to be more dynamic and distro-specific. It successfully removes the distutils dependency and integrates venv as intended. The changes are well-structured and improve maintainability by centralizing package definitions.
I am having trouble creating individual review comments. Click here to see my feedback.
private/repos/deb/bookworm_python.lock.json (3-13)
The dash package was removed from the bookworm_python.lock.json. While the PR description mentions removing distutils and adding venv, it doesn't explicitly state the removal of dash. Please confirm if this removal is intentional and if dash is no longer a required dependency for Debian 12 Python images, or if this was an unintended side effect.
private/repos/deb/bookworm_python.lock.json (278-288)
The libc-bin package (amd64) was removed from the bookworm_python.lock.json. Similar to dash, please confirm if this removal is intentional and if libc-bin is no longer a required dependency for Debian 12 Python images.
private/repos/deb/bookworm_python.lock.json (290-299)
The dash package (arm64) was removed from the bookworm_python.lock.json. Please confirm if this removal is intentional and if dash is no longer a required dependency for Debian 12 Python images.
private/repos/deb/bookworm_python.lock.json (564-574)
The libc-bin package (arm64) was removed from the bookworm_python.lock.json. Please confirm if this removal is intentional and if libc-bin is no longer a required dependency for Debian 12 Python images.
private/repos/deb/bookworm_python.yaml (17)
The dash package was removed from the bookworm_python.yaml. This aligns with the .lock.json changes. Please confirm this removal is intentional and does not impact existing Debian 12 Python images.
private/repos/deb/bookworm_python.yaml (42)
The libc-bin package was removed from the bookworm_python.yaml. This aligns with the .lock.json changes. Please confirm this removal is intentional and does not impact existing Debian 12 Python images.
python3/testdata/debian13.yaml (47)
The comment i thought distutils was gone? for _distutils_system_mod in the skip_modules list for Debian 13 is a bit concerning. If distutils is intended to be fully removed, this module should ideally not be present or its presence should be explicitly understood and documented. Could you clarify why this module might still be appearing or why it's being skipped?
hrmm modified incorrectly it looks like |
loosebazooka
force-pushed
the
python3-deb13
branch
from
c0bd409 to
2ddb0ad
Compare
|
🌳 🔄 Image Check This pull request has modified the following images: //python3:python3_root_amd64_debian13 (new)
//python3:python3_nonroot_amd64_debian13 (new)
//python3:python3_debug_root_amd64_debian13 (new)
//python3:python3_debug_nonroot_amd64_debian13 (new)
//python3:python3_root_arm64_debian13 (new)
//python3:python3_nonroot_arm64_debian13 (new)
//python3:python3_debug_root_arm64_debian13 (new)
//python3:python3_nonroot_debian13 (new)
//python3:python3_root_debian13 (new)
//python3:python3_debug_nonroot_arm64_debian13 (new)
//python3:python3_debug_root_debian13 (new)
//python3:python3_debug_nonroot_debian13 (new)You can check the details in the report here |
loosebazooka
force-pushed
the
python3-deb13
branch
from
2ddb0ad to
f70e150
Compare
- Remove distutils dep and add venv. I'm not sure this is sufficient for all python users, but hopefully it will be. - Not too many changes otherwise Signed-off-by: Appu Goundan <appu@google.com>
loosebazooka
force-pushed
the
python3-deb13
branch
from
f70e150 to
5f935e9
Compare
2 participants
Uh oh!
There was an error while loading. Please reload this page.