chore: bumping up docker cli to address CVE-2025-15558#10008
Open
Darien-Lin wants to merge 1 commit intoGoogleContainerTools:mainfrom
Open
chore: bumping up docker cli to address CVE-2025-15558#10008Darien-Lin wants to merge 1 commit intoGoogleContainerTools:mainfrom
Darien-Lin wants to merge 1 commit intoGoogleContainerTools:mainfrom
Conversation
Contributor
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on critical dependency updates and feature enhancements. It includes a security-driven bump of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request primarily involves bumping the docker/cli dependency and other related packages, which has resulted in a large number of changes within the vendor directory. To accommodate these upgrades, a workaround has been implemented in pkg/skaffold/docker/auth.go to translate between different AuthConfig types. While this is a necessary change, I've found a potential issue in the new conversion function that could lead to authentication failures. My specific feedback is detailed in the comment below.
…e the types between docker/docker registry and docker/cli until all packages are upgraded appropriately in our dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now, have a workaround to translate the types between docker/docker registry and docker/cli until all docker packages are upgraded appropriately in our dependencies.
When that happens there will be substantial changes that need to be made in skaffold.
To determine the set of dependencies that are not using the right moby path:
The clitypes: https://pkg.go.dev/github.com/docker/cli@v29.2.1+incompatible/cli/config/types
The registry type: https://pkg.go.dev/github.com/docker/docker@v28.5.2+incompatible/api/types/registry#AuthConfig