feat(cluster): Add labels to cluster config #9553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Suleiman Dibirov <[email protected]>
Signed-off-by: Suleiman Dibirov <[email protected]>
Signed-off-by: Suleiman Dibirov <[email protected]>
Contributor
Author
|
Hi @ericzzzzzzz |
Contributor
|
Hi @idsulik Thanks for the pr, due to org structure change, I'm no longer working on skaffold, please use |
Contributor
Author
|
hi @ericzzzzzzz, okay, thank you!) |
Contributor
Author
|
@plumpy hi! Could you please check the PR?) |
Contributor
Author
|
@ericzzzzzzz hi! Could you please write me on linkedin, I want to ask something. I'm writing here, because I couldn't find anything to find you, I'll delete this message |
Contributor
|
Hi @idsulik , I don't use linkedin, please send me an email for your questions, [email protected] |
katiexzhang
reviewed
Nov 15, 2024
plumpy
added a commit
to plumpy/skaffold
that referenced
this pull request
Nov 20, 2024
…ools#9553)" This reverts commit e55f954.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9549
Description
Add
build.cluster:labelsconfig so user can specify labels for podUser facing changes
Before: no way to specify labels
After: there is a way to specify labels