fix: Continue deployment even if ContainerRemove call returns error #9561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some situations Podman will report that the previous container is no longer present: "no container with ID or name ..." This condition should not prevent redeployment to continue. Fixes: GoogleContainerTools#9560
mnk
changed the title
mattsanta
approved these changes
Nov 15, 2024
plumpy
added a commit
to plumpy/skaffold
that referenced
this pull request
Nov 20, 2024
… error (GoogleContainerTools#9561)" This reverts commit df305b3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some situations Podman will report that the previous container is no longer present: "no container with ID or name ..." This condition should not prevent redeployment to continue.
Fixes: #9560
Description
See issue linked above for description of the problem this PR is intended to solve.
The PR also replaces usage of deprecated type: ContainerRemoveOptions.