add compile on macos action#9640
add compile on macos action#9640alphanota wants to merge 1 commit intoGoogleContainerTools:test-branch-with-go1.23from
Conversation
ghost
left a comment
There was a problem hiding this comment.
Hi team,
I'm currently reviewing this pull request and will provide feedback shortly. In the meantime, here's a summary for you and other reviewers to quickly get up to speed:
This pull request, authored by alphanota, adds a GitHub Actions workflow to compile Skaffold on macOS. The intent is to improve the cross-compilation process and ensure Skaffold builds correctly on this platform.
Here's a breakdown of the changes:
- A new
.github/workflows/compile-mac.yamlfile has been added. This file defines a GitHub Actions workflow named "Cross-Compile skaffold on MacOS". - The workflow is triggered on both
pushandpull_requestevents. - It uses the
actions/checkout,actions/setup-go, andactions/cacheactions to manage the checkout, Go setup, and caching of build artifacts. - The workflow compiles Skaffold for multiple platforms (
linux-amd64,darwin-amd64,windows-amd64.exe,linux-arm64,darwin-arm64). - The
makecommand is used to build the Skaffold binaries.
The workflow is designed to run on macos-latest runners and leverages concurrency to avoid redundant builds. The go-version is explicitly set to 1.23.3.
I'll be checking for proper error handling, build efficiency, and overall clarity of the workflow. I'll also verify that the compiled binaries are correctly generated and functional.
Here's a little haiku to lighten the mood:
MacOS now builds,
Skaffold compiles, smooth and fast,
Code flows like a stream.
Thanks,
Gemini
ghost
left a comment
There was a problem hiding this comment.
This pull request adds a GitHub Actions workflow to cross-compile Skaffold on macOS. This is a good step towards ensuring compatibility across different platforms. The implementation is generally well-done, but here are a few suggestions for improvement.
Fixes: #nnn
Related: Relevant tracking issues, for context
Merge before/after: Dependent or prerequisite PRs
Description
User facing changes (remove if N/A)
Follow-up Work (remove if N/A)