chore: Skaffold 2.17 release #9912
Conversation
Summary of ChangesHello @mattsanta, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on preparing for the Skaffold v2.17.0 release by updating the changelog and refreshing various dependencies across different example projects. These updates ensure compatibility with newer versions of Go and Ruby libraries, maintaining the stability and currency of the project's examples. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request prepares for the v2.17.0 release by updating the changelog and bumping dependency versions in some example projects. The changes are mostly straightforward. I've provided a couple of suggestions for improving consistency in the changelog's installation instructions and in a go.mod file.
| **Linux amd64** | ||
| `curl -Lo skaffold https://storage.googleapis.com/skaffold/releases/v2.17.0/skaffold-linux-amd64 && chmod +x skaffold && sudo mv skaffold /usr/local/bin` | ||
|
|
||
| **Linux arm64** | ||
| `curl -Lo skaffold https://storage.googleapis.com/skaffold/releases/v2.17.0/skaffold-linux-arm64 && chmod +x skaffold && sudo mv skaffold /usr/local/bin` | ||
|
|
||
| **macOS amd64** | ||
| `curl -Lo skaffold https://storage.googleapis.com/skaffold/releases/v2.17.0/skaffold-darwin-amd64 && chmod +x skaffold && sudo mv skaffold /usr/local/bin` | ||
|
|
||
| **macOS arm64** | ||
| `curl -Lo skaffold https://storage.googleapis.com/skaffold/releases/v2.17.0/skaffold-darwin-arm64 && chmod +x skaffold && sudo mv skaffold /usr/local/bin` |
There was a problem hiding this comment.
The installation commands in this changelog use chmod +x ... && sudo mv .... For consistency with the project's official installation documentation and for better practice, it's recommended to use sudo install instead. The install command is more suitable for this purpose as it handles setting permissions correctly, making the separate chmod +x step unnecessary.
For example, the Linux amd64 installation command should be:
curl -Lo skaffold https://storage.googleapis.com/skaffold/releases/v2.17.0/skaffold-linux-amd64 && sudo install skaffold /usr/local/binThis change should be applied to all similar installation commands in this block.
| module github.com/GoogleContainerTools/skaffold/v2/integration/examples/grpc-e2e-tests/cloud-spanner-bootstrap | ||
|
|
||
| go 1.19 | ||
| go 1.23.0 |
There was a problem hiding this comment.
The Go version 1.23.0 is unconventional. The standard Go toolchain uses the format x.y for go.mod files (e.g., go 1.23). While 1.23.0 is technically valid, using the standard format improves consistency across the project and aligns with Go's tooling conventions.
| go 1.23.0 | |
| go 1.23 |
2 participants
No description provided.