Skip to content

Conversation

@mattsanta
Copy link
Contributor

dependabot bot and others added 5 commits January 7, 2026 18:43
…rTools#9917)

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.43.0 to 0.45.0.
- [Commits](golang/crypto@v0.43.0...v0.45.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-version: 0.45.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
GoogleContainerTools#9934)

Bumps the github-actions group with 3 updates in the / directory: [actions/checkout](https://github.com/actions/checkout), [actions/cache](https://github.com/actions/cache) and [actions/upload-artifact](https://github.com/actions/upload-artifact).


Updates `actions/checkout` from 5 to 6
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v5...v6)

Updates `actions/cache` from 4 to 5
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@v4...v5)

Updates `actions/upload-artifact` from 5 to 6
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v5...v6)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github-actions
- dependency-name: actions/cache
  dependency-version: '5'
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github-actions
- dependency-name: actions/upload-artifact
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github-actions
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…permissions issue and fix github workflow (GoogleContainerTools#9943)

disabling kaniko integration tests due to kaniko service accountpermissioning issue and fix github workflow

Co-authored-by: Darien-Lin <[email protected]>
* Upgrade github.com/google/ko to v0.18.1

* Upgrade github.com/google/ko to v0.18.1 continue

* fix a issue in docker/auth.go

* fix go version issue in test

* revert go version changes in test

* update docker cli vendor files

* Trigger GitHub Actions
@mattsanta mattsanta marked this pull request as ready for review January 7, 2026 18:48
@mattsanta mattsanta requested a review from a team as a code owner January 7, 2026 18:48
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @mattsanta, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on essential maintenance, including a significant upgrade of the Go language version and numerous dependency updates to ensure the project remains current and secure. Additionally, it addresses a critical CI issue by temporarily disabling problematic Kaniko integration tests, ensuring the stability of the build pipeline. A large portion of the cloud.google.com/go/spanner vendor directory has been removed, streamlining the project's dependency footprint.

Highlights

  • GoLang Upgrade: The project's Go version has been upgraded to 1.25.5, affecting both the go.mod file and the Dockerfile.deps.
  • Dependency Bumps: Several key dependencies have been updated, including golang.org/x/crypto (from 0.43.0 to 0.46.0), github-actions group, github.com/google/ko (to v0.18.1), github.com/docker/cli, go.opentelemetry.io/otel, and various google.golang.org and k8s.io modules.
  • CI/CD Fixes: Kaniko integration tests have been temporarily disabled due to service account permission issues, and the GitHub workflow has been adjusted accordingly.
  • Vendor Directory Cleanup: A significant number of files related to cloud.google.com/go/spanner and its sub-packages have been removed from the vendor directory, indicating a potential shift in dependency management or a major update to how these modules are handled.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (8)
    • .github/workflows/codeql-analysis.yml
    • .github/workflows/integration-linux.yml
    • .github/workflows/linters-checks.yml
    • .github/workflows/scorecards.yml
    • .github/workflows/unit-tests-darwin.yml
    • .github/workflows/unit-tests-linux.yml
    • .github/workflows/unit-tests-windows.yml
    • .github/workflows/verify-examples.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a cherry-pick of several changes, primarily focused on updating dependencies, including Go itself, and temporarily disabling some integration tests. The changes seem reasonable for maintenance purposes. I've added a couple of suggestions to improve code maintainability by adding comments that provide context for future developers.


replace k8s.io/kube-openapi => k8s.io/kube-openapi v0.0.0-20250628140032-d90c4fd18f59

replace github.com/docker/cli => github.com/docker/cli v28.5.2+incompatible
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better maintainability, it would be helpful to add a comment explaining why github.com/docker/cli is being pinned to v28.5.2+incompatible using a replace directive, especially since the require block was updated to a newer version. This context will be valuable for future dependency management.

dir: "testdata/kaniko-microservices",
deployments: []string{"leeroy-app", "leeroy-web"},
},
// Currently disable kaniko integration tests due to kaniko service account issues.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While disabling tests is sometimes necessary to unblock CI, it's important to track this and re-enable them. Please add a TODO comment with a link to a tracking issue for the service account problem. This will ensure the issue is not forgotten.

Suggested change
// Currently disable kaniko integration tests due to kaniko service account issues.
// TODO(#issue-number): Re-enable kaniko integration tests once the service account issue is resolved.
// Currently disable kaniko integration tests due to kaniko service account issues.

@mattsanta mattsanta merged commit ec7f882 into GoogleContainerTools:release/v2.17 Jan 7, 2026
10 checks passed
@mattsanta mattsanta deleted the cherrypick branch January 7, 2026 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants