-
Notifications
You must be signed in to change notification settings - Fork 1.7k
cherrypick #9946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cherrypick #9946
Conversation
mattsanta
commented
Jan 7, 2026
- chore: bump golang.org/x/crypto from 0.43.0 to 0.45.0 (chore: bump golang.org/x/crypto from 0.43.0 to 0.45.0 #9917)
- chore: bump the github-actions group across 1 directory with 3 updates (chore: bump the github-actions group across 1 directory with 3 updates #9934)
- ci: disabling kaniko integration tests due to kaniko service account permissions issue and fix github workflow (disabling kaniko integration tests due to kaniko service account permissions issue #9943)
- chore: upgrade golang to 1.25.5 (chore: upgrade golang to 1.25.5 #9944)
- Upgrade github.com/google/ko to v0.18.1 (Upgrade github.com/google/ko to v0.18.1 #9939)
…rTools#9917) Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.43.0 to 0.45.0. - [Commits](golang/crypto@v0.43.0...v0.45.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-version: 0.45.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
GoogleContainerTools#9934) Bumps the github-actions group with 3 updates in the / directory: [actions/checkout](https://github.com/actions/checkout), [actions/cache](https://github.com/actions/cache) and [actions/upload-artifact](https://github.com/actions/upload-artifact). Updates `actions/checkout` from 5 to 6 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v5...v6) Updates `actions/cache` from 4 to 5 - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v4...v5) Updates `actions/upload-artifact` from 5 to 6 - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v5...v6) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions - dependency-name: actions/cache dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions - dependency-name: actions/upload-artifact dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…permissions issue and fix github workflow (GoogleContainerTools#9943) disabling kaniko integration tests due to kaniko service accountpermissioning issue and fix github workflow Co-authored-by: Darien-Lin <[email protected]>
* Upgrade github.com/google/ko to v0.18.1 * Upgrade github.com/google/ko to v0.18.1 continue * fix a issue in docker/auth.go * fix go version issue in test * revert go version changes in test * update docker cli vendor files * Trigger GitHub Actions
Summary of ChangesHello @mattsanta, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on essential maintenance, including a significant upgrade of the Go language version and numerous dependency updates to ensure the project remains current and secure. Additionally, it addresses a critical CI issue by temporarily disabling problematic Kaniko integration tests, ensuring the stability of the build pipeline. A large portion of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is a cherry-pick of several changes, primarily focused on updating dependencies, including Go itself, and temporarily disabling some integration tests. The changes seem reasonable for maintenance purposes. I've added a couple of suggestions to improve code maintainability by adding comments that provide context for future developers.
|
|
||
| replace k8s.io/kube-openapi => k8s.io/kube-openapi v0.0.0-20250628140032-d90c4fd18f59 | ||
|
|
||
| replace github.com/docker/cli => github.com/docker/cli v28.5.2+incompatible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| dir: "testdata/kaniko-microservices", | ||
| deployments: []string{"leeroy-app", "leeroy-web"}, | ||
| }, | ||
| // Currently disable kaniko integration tests due to kaniko service account issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While disabling tests is sometimes necessary to unblock CI, it's important to track this and re-enable them. Please add a TODO comment with a link to a tracking issue for the service account problem. This will ensure the issue is not forgotten.
| // Currently disable kaniko integration tests due to kaniko service account issues. | |
| // TODO(#issue-number): Re-enable kaniko integration tests once the service account issue is resolved. | |
| // Currently disable kaniko integration tests due to kaniko service account issues. |
ec7f882
into
GoogleContainerTools:release/v2.17