cherrypick #9978
Merged
cherrypick #9978
+3,226
−2,018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Darien-Lin
commented
Feb 12, 2026
Darien-Lin
commented
- chore: bump github.com/sigstore/cosign/v2 from 2.6.1 to 2.6.2 (chore: bump github.com/sigstore/cosign/v2 from 2.6.1 to 2.6.2 #9948)
- cicd: bazel github presubmit flow fixes for recent bazel 9.0.0 release (cicd: bazel github presubmit flow fixes for recent bazel 9.0.0 release #9961)
- chore: bump github.com/sigstore/sigstore from 1.10.3 to 1.10.4 (chore: bump github.com/sigstore/sigstore from 1.10.3 to 1.10.4 #9957)
- chore: bump github.com/sigstore/rekor from 1.4.3 to 1.5.0 (chore: bump github.com/sigstore/rekor from 1.4.3 to 1.5.0 #9956)
- chore: bump github.com/theupdateframework/go-tuf/v2 from 2.3.0 to 2.4.1 (chore: bump github.com/theupdateframework/go-tuf/v2 from 2.3.0 to 2.4.1 #9962)
- test(integration): Update busybox and alpine:3 to use the mirror to avoid docker rate hub limit errors (test(integration): Update busybox and alpine:3 to use the mirror to avoid docker rate hub limit errors #9966)
- chore: bump github.com/go-git/go-git/v5 from 5.16.3 to 5.16.5 (chore: bump github.com/go-git/go-git/v5 from 5.16.3 to 5.16.5 #9971)
- chore: bump golang.org/x/oauth2 from 0.7.0 to 0.27.0 in /examples/grpc-e2e-tests/service (chore: bump golang.org/x/oauth2 from 0.7.0 to 0.27.0 in /examples/grpc-e2e-tests/service #9918)
- chore: bump golang.org/x/crypto from 0.36.0 to 0.45.0 in /hack/tools (chore: bump golang.org/x/crypto from 0.36.0 to 0.45.0 in /hack/tools #9916)
- Use mirror in Dockerfiles for integration tests to prevent docker hub rate limits (Use mirror in Dockerfiles for integration tests to prevent docker hub rate limits #9970)
- chore: upgrade golang to 1.25.7 (chore: upgrade golang to 1.25.7 #9973)
- Updated Dockerfile to try to fix vuln bug (Updated Dockerfile to try to fix vuln bug #9974)
- Updated the node version to fix error (Updated the node version to fix error #9976)
- chore: fixing docs due to upgrade in Hugo (chore: fixing docs due to upgrade in Hugo #9977)
…ContainerTools#9948) Bumps [github.com/sigstore/cosign/v2](https://github.com/sigstore/cosign) from 2.6.1 to 2.6.2. - [Release notes](https://github.com/sigstore/cosign/releases) - [Changelog](https://github.com/sigstore/cosign/blob/main/CHANGELOG.md) - [Commits](sigstore/cosign@v2.6.1...v2.6.2) --- updated-dependencies: - dependency-name: github.com/sigstore/cosign/v2 dependency-version: 2.6.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
GoogleContainerTools#9961) bazel build fixes for recent bazel 9.0.0 release
…eContainerTools#9957) Bumps [github.com/sigstore/sigstore](https://github.com/sigstore/sigstore) from 1.10.3 to 1.10.4. - [Release notes](https://github.com/sigstore/sigstore/releases) - [Commits](sigstore/sigstore@v1.10.3...v1.10.4) --- updated-dependencies: - dependency-name: github.com/sigstore/sigstore dependency-version: 1.10.4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ainerTools#9956) Bumps [github.com/sigstore/rekor](https://github.com/sigstore/rekor) from 1.4.3 to 1.5.0. - [Release notes](https://github.com/sigstore/rekor/releases) - [Changelog](https://github.com/sigstore/rekor/blob/main/CHANGELOG.md) - [Commits](sigstore/rekor@v1.4.3...v1.5.0) --- updated-dependencies: - dependency-name: github.com/sigstore/rekor dependency-version: 1.5.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
….1 (GoogleContainerTools#9962) Bumps [github.com/theupdateframework/go-tuf/v2](https://github.com/theupdateframework/go-tuf) from 2.3.0 to 2.4.1. - [Release notes](https://github.com/theupdateframework/go-tuf/releases) - [Commits](theupdateframework/go-tuf@v2.3.0...v2.4.1) --- updated-dependencies: - dependency-name: github.com/theupdateframework/go-tuf/v2 dependency-version: 2.4.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…void docker rate hub limit errors (GoogleContainerTools#9966) test(integration): mirror busybox and alpine:3 images to gcr.io
…ContainerTools#9971) Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.16.3 to 5.16.5. - [Release notes](https://github.com/go-git/go-git/releases) - [Commits](go-git/go-git@v5.16.3...v5.16.5) --- updated-dependencies: - dependency-name: github.com/go-git/go-git/v5 dependency-version: 5.16.5 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…c-e2e-tests/service (GoogleContainerTools#9918) chore: bump golang.org/x/oauth2 in /examples/grpc-e2e-tests/service Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2) from 0.7.0 to 0.27.0. - [Commits](golang/oauth2@v0.7.0...v0.27.0) --- updated-dependencies: - dependency-name: golang.org/x/oauth2 dependency-version: 0.27.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…oogleContainerTools#9916) Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.36.0 to 0.45.0. - [Commits](golang/crypto@v0.36.0...v0.45.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-version: 0.45.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
… rate limits (GoogleContainerTools#9970) * use mirror in Dockerfiles for integration tests * use argument prefix instead * fix for multi stage * more fixes * fix buildx-bin error * Bring back comments * missed a comment
Co-authored-by: Darien-Lin <[email protected]>
* Updated Dockerfile to try to fix vuln bug * Addressed the gemini-code-assist comments * Fixed the dockerfile so it runs using docker build -f deploy/webhook-v2/Dockerfile .
* Updated Dockerfile to try to fix vuln bug * Addressed the gemini-code-assist comments * Fixed the dockerfile so it runs using docker build -f deploy/webhook-v2/Dockerfile . * Updated node version to try and fix error
fixing docs due to upgrade in Hugo
Contributor
Summary of ChangesHello @Darien-Lin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request consolidates a series of maintenance and stability improvements. The primary focus is on updating core Go dependencies and their corresponding checksums, ensuring the project leverages the latest stable versions. Significant changes include standardizing base image sources in Dockerfiles to improve build reliability and addressing compatibility issues arising from Hugo upgrades in the documentation build pipeline. These changes collectively enhance the project's robustness, security, and development environment consistency. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request is a cherry-pick of several commits, including dependency updates, documentation fixes, and CI improvements. The changes to use a Docker image mirror are a good improvement to avoid rate limiting issues. However, this change was not applied consistently across all relevant Dockerfiles. I've left comments on the files where the image mirror prefix is missing. Other changes, such as documentation fixes and dependency bumps, look good.
| @@ -1 +1,2 @@ | |||
| ARG BASE_PREFIX=mirror.gcr.io/library/ | |||
| FROM nginx:stable | |||
Contributor
There was a problem hiding this comment.
To avoid Docker Hub rate limits, this FROM instruction should also use the BASE_PREFIX argument, similar to other Dockerfiles in this pull request.
FROM ${BASE_PREFIX}nginx:stable
| @@ -1,3 +1,4 @@ | |||
| ARG BASE_PREFIX=mirror.gcr.io/library/ | |||
| FROM node:14.9-alpine | |||
Contributor
There was a problem hiding this comment.
To avoid Docker Hub rate limits, this FROM instruction should also use the BASE_PREFIX argument, similar to other Dockerfiles in this pull request.
FROM ${BASE_PREFIX}node:14.9-alpine
| @@ -1,3 +1,4 @@ | |||
| ARG BASE_PREFIX=mirror.gcr.io/library/ | |||
| FROM python:3.9-alpine | |||
Contributor
There was a problem hiding this comment.
To avoid Docker Hub rate limits, this FROM instruction should also use the BASE_PREFIX argument, similar to other Dockerfiles in this pull request.
FROM ${BASE_PREFIX}python:3.9-alpine
| @@ -1,3 +1,4 @@ | |||
| ARG BASE_PREFIX=mirror.gcr.io/library/ | |||
| FROM node:14.9-alpine | |||
Contributor
There was a problem hiding this comment.
To avoid Docker Hub rate limits, this FROM instruction should also use the BASE_PREFIX argument, similar to other Dockerfiles in this pull request.
FROM ${BASE_PREFIX}node:14.9-alpine
| @@ -1,3 +1,4 @@ | |||
| ARG BASE_PREFIX=mirror.gcr.io/library/ | |||
| FROM node:14.9-alpine | |||
Contributor
There was a problem hiding this comment.
To avoid Docker Hub rate limits, this FROM instruction should also use the BASE_PREFIX argument, similar to other Dockerfiles in this pull request.
FROM ${BASE_PREFIX}node:14.9-alpine
| @@ -1,3 +1,4 @@ | |||
| ARG BASE_PREFIX=mirror.gcr.io/library/ | |||
| FROM node:14.9-alpine | |||
Contributor
There was a problem hiding this comment.
To avoid Docker Hub rate limits, this FROM instruction should also use the BASE_PREFIX argument, similar to other Dockerfiles in this pull request.
FROM ${BASE_PREFIX}node:14.9-alpine
| @@ -1,3 +1,4 @@ | |||
| ARG BASE_PREFIX=mirror.gcr.io/library/ | |||
| FROM node:14.9-alpine | |||
Contributor
There was a problem hiding this comment.
To avoid Docker Hub rate limits, this FROM instruction should also use the BASE_PREFIX argument, similar to other Dockerfiles in this pull request.
FROM ${BASE_PREFIX}node:14.9-alpine
| @@ -1,3 +1,4 @@ | |||
| ARG BASE_PREFIX=mirror.gcr.io/library/ | |||
| FROM node:14.9-alpine | |||
Contributor
There was a problem hiding this comment.
To avoid Docker Hub rate limits, this FROM instruction should also use the BASE_PREFIX argument, similar to other Dockerfiles in this pull request.
FROM ${BASE_PREFIX}node:14.9-alpine
| @@ -1,3 +1,4 @@ | |||
| ARG BASE_PREFIX=mirror.gcr.io/library/ | |||
| FROM ruby:2.7 | |||
Contributor
There was a problem hiding this comment.
To avoid Docker Hub rate limits, this FROM instruction should also use the BASE_PREFIX argument, similar to other Dockerfiles in this pull request.
FROM ${BASE_PREFIX}ruby:2.7
| @@ -1,3 +1,4 @@ | |||
| ARG BASE_PREFIX=mirror.gcr.io/library/ | |||
| FROM node:14.9-alpine | |||
Contributor
There was a problem hiding this comment.
To avoid Docker Hub rate limits, this FROM instruction should also use the BASE_PREFIX argument, similar to other Dockerfiles in this pull request.
FROM ${BASE_PREFIX}node:14.9-alpine
mattsanta
approved these changes
Feb 12, 2026
Darien-Lin
merged commit cb2a7c0
into
GoogleContainerTools:release/v2.17
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.