Skip to content

Block: minor bug fixes for WP 6.8 #14066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swissspidy merged 3 commits into from
Mar 24, 2025
+14 −6
Merged

Block: minor bug fixes for WP 6.8 #14066

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8cf0eca
Block: use stable array to avoid re-renders
swissspidy Mar 24, 2025
d5de0b5
Add some missing `__next40pxDefaultSize` attrs
swissspidy Mar 24, 2025
d457ac4
Update patch file
swissspidy Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/stories-block/src/block/block-types/single-story/embedControls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ const EmbedControls = (props) => {
value={title || ''}
onChange={(value) => setAttributes({ title: value })}
__nextHasNoMarginBottom
__next40pxDefaultSize
/>
</BaseControl>
</PanelRow>
Expand Down Expand Up @@ -188,6 +189,7 @@ const EmbedControls = (props) => {
setAttributes({ width: Number.parseInt(value) })
}
__nextHasNoMarginBottom
__next40pxDefaultSize
/>
<TextControl
type="number"
Expand All @@ -202,6 +204,7 @@ const EmbedControls = (props) => {
})
}
__nextHasNoMarginBottom
__next40pxDefaultSize
/>
</div>
</BaseControl>
Expand Down
2 changes: 2 additions & 0 deletions packages/stories-block/src/block/block-types/single-story/embedControlsInLoop.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ const EmbedControlsInLoop = (props) => {
setAttributes({ width: Number.parseInt(value) })
}
__nextHasNoMarginBottom
__next40pxDefaultSize
/>
<TextControl
type="number"
Expand All @@ -86,6 +87,7 @@ const EmbedControlsInLoop = (props) => {
})
}
__nextHasNoMarginBottom
__next40pxDefaultSize
/>
</div>
</BaseControl>
Expand Down
1 change: 1 addition & 0 deletions packages/stories-block/src/block/components/storiesInspectorControls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,7 @@ const StoriesInspectorControls = (props) => {
}
className="web-stories-settings-archive-link"
__nextHasNoMarginBottom
__next40pxDefaultSize
/>
)}
</PanelBody>
Expand Down
8 changes: 5 additions & 3 deletions packages/stories-block/src/block/components/storyPicker/selectStories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,9 +122,11 @@ KeywordSearch.propTypes = {
onChange: PropTypes.func,
};

const STABLE_ARRAY = [];

function SelectStories({
stories = [],
selectedStories = [],
stories = STABLE_ARRAY,
selectedStories = STABLE_ARRAY,
setSelectedStories,
hasAllStories,
isLoading,
Expand All @@ -150,7 +152,7 @@ function SelectStories({
};
return {
// Only load users when capability has been fetched already.
authors: capabilities ? getUsers(query) : [],
authors: capabilities ? getUsers(query) : STABLE_ARRAY,
};
},
[authorKeyword]
Expand Down
6 changes: 3 additions & 3 deletions patches/@types+glider-js+1.7.11.patch → patches/@types+glider-js+1.7.12.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
diff --git a/node_modules/@types/glider-js/index.d.ts b/node_modules/@types/glider-js/index.d.ts
index 35a953d..655ded6 100644
index 2be4c56..1b838c6 100644
--- a/node_modules/@types/glider-js/index.d.ts
+++ b/node_modules/@types/glider-js/index.d.ts
@@ -97,7 +97,7 @@ declare namespace Glider {
Expand All @@ -11,7 +11,7 @@ index 35a953d..655ded6 100644

/**
* This prevents resizing items to fit when `slidesToShow` is set to
@@ -242,13 +242,13 @@ declare class Glider<T extends HTMLElement = HTMLDivElement> {
@@ -247,13 +247,13 @@ declare class Glider<T extends HTMLElement = HTMLDivElement> {
* @param slideIndexs string | number
* @param isActuallyDotIndex boolean
*/
Expand All @@ -27,7 +27,7 @@ index 35a953d..655ded6 100644

/**
* Overrides options set during initialization. If called when a
@@ -271,6 +271,10 @@ declare class Glider<T extends HTMLElement = HTMLDivElement> {
@@ -276,6 +276,10 @@ declare class Glider<T extends HTMLElement = HTMLDivElement> {
resize(): void;

init(): void;
Expand Down
Loading