Open
Conversation
subiabre
requested changes
Oct 31, 2023
subiabre
approved these changes
Nov 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Allow project owner to change the type of the project.
The two types of project that the owner can choose are:
Campaign is the classical type of project held in Goteo. It works using rounds and is an All-or-nothing model. The permanent campaign allows the project to have a project that does not end.
This decision was made by the admins of the platform, but with this PR the owners can decide this for themselves.
📌 Related Issues
This PR is inside the the Recurring campaigns project.
Testing
Describe the best way to test or validate your PR.
Enter in the dashboard of a Project that has a state previous of 'In Campaign (3)'. Enter in the 'Campaign' module. Make sure that it can be modified by the project owner and as an admin.
Try the same with a project that has been published or already financed. Check that the whole module is not accessible by the project owner.
📷 Screenshots