Resurface five accidentally shadowed tests#4064
Merged
Conversation
The Monday weekstart test redefined test_basic_command and silenced the original calendar smoke test.
The invalid-argument case reused test_2015_argument and replaced the valid year test at import time.
TW #2386 coverage redefined test_project_spaces and silenced the spaces-focused test.
The dependency-cleanup scenario reused test_purge_children and replaced the earlier child-purge coverage.
Collaborator
|
Thanks!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following MR renames test methods that inadvertently shadowed other tests methods, thereby reducing the test suite.