Pass color settings to tables #730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauft
added a commit
to GothenburgBitFactory/libshared
that referenced
this pull request
Dec 6, 2025
Check for tty should be done in the application and passed to the table. Replace tty check with explicit setting for colored output. Relates to GothenburgBitFactory/timewarrior#727 GothenburgBitFactory/timewarrior#730 Signed-off-by: Thomas Lauf <thomas.lauf@tngtech.com>
lauft
added a commit
to GothenburgBitFactory/libshared
that referenced
this pull request
Dec 7, 2025
Check for tty should be done in the application and passed to the table. Replace tty check with explicit setting for colored output. Relates to GothenburgBitFactory/timewarrior#727 GothenburgBitFactory/timewarrior#730 Signed-off-by: Thomas Lauf <thomas.lauf@tngtech.com>
lauft
added a commit
to GothenburgBitFactory/libshared
that referenced
this pull request
Dec 7, 2025
Check for tty should be done in the application and passed to the table. Replace tty check with explicit setting for colored output. Relates to GothenburgBitFactory/timewarrior#727 GothenburgBitFactory/timewarrior#730 Signed-off-by: Thomas Lauf <thomas.lauf@tngtech.com>
lauft
added a commit
to GothenburgBitFactory/libshared
that referenced
this pull request
Dec 7, 2025
Check for tty should be done in the application and passed to the table. Replace tty check with explicit setting for colored output. Relates to GothenburgBitFactory/timewarrior#727 GothenburgBitFactory/timewarrior#730 Signed-off-by: Thomas Lauf <thomas.lauf@tngtech.com>
Signed-off-by: Thomas Lauf <thomas.lauf@tngtech.com>
lauft
force-pushed
the
issue/727
branch
2 times, most recently
from
7653dbf to
261e6ea
Compare
The builders of the tags and summary table did not pass the value of the color setting. Also, the 'Table' component had an internal TTY check which could interfere with the color setting of the main application. Add test for color hint Reapply command line hints after loading config files Closes #727 Signed-off-by: Thomas Lauf <thomas.lauf@tngtech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'Table' component from libshared has its own TTY check. To adhere to the color setting of the main calculation it has to be overridden.
Closes #727