Skip to content

Raise exception on socket disconnect #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
insideable wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Raise exception on socket disconnect #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pynats/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,9 @@ def _readline(self, *, size: int = None) -> bytes:
line = cast(bytes, self._socket_file.readline())
read.write(line)

if len(line) == 0:
raise ConnectionResetError(self)

if size is not None:
if read.tell() == size + len(_CRLF_):
break
Expand Down
12 changes: 12 additions & 0 deletions tests/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,3 +179,15 @@ def test_request_timeout(nats_url):
with NATSClient(nats_url, socket_timeout=2) as client:
with pytest.raises(socket.timeout):
client.request("test-subject")


def test_exception_on_disconnect(nats_url):
with NATSClient(nats_url, socket_timeout=2) as client:
client.subscribe(
"test-subject", callback=lambda x: x, queue="test-queue", max_messages=2
)

client._socket_file.readline = lambda: b""

with pytest.raises(ConnectionResetError):
client.wait()