Bug fix for gf-shell command 'pt -compute' and reactivating 'pt -transfer' #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tryMatch p (VConst _ _) env = match sig f eqs as0
Merged
hleiss
added a commit
to hleiss/gf-core
that referenced
this pull request
Sep 9, 2025
2 tabs \t in compiler/GF/Command/TreeOperations.hs introduced in PR GrammaticalFramework#174 blocked the options -nub and -funs of 'put_tree'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'pt -compute' did fail to consider further equations when a pattern did not match a constant (non-data)
'pt -transfer=f ' reactivates the 'simple-minded transfer' of gf-3.3 by applying the transfer function f:C -> D to all maximal subtrees of type C of a given tree e. When applied to strict subtrees of e, f ought to have type C -> C, otherwise the result can be type-incorrect. A type error should be reported in this case, but so far is not.