Skip to content

fix: Try to improve Ctrl+C and Esc key behavior#29

Open
Granddave wants to merge 1 commit intomasterfrom
improving-ctrlc-behavior
Open

fix: Try to improve Ctrl+C and Esc key behavior#29
Granddave wants to merge 1 commit intomasterfrom
improving-ctrlc-behavior

Conversation

@Granddave
Copy link
Owner

Here we have removed ctrlc crate, thread and the channel and instead use raw mode and set attributes and poll.

Fixes #28

@Granddave Granddave force-pushed the improving-ctrlc-behavior branch from 38b91ef to d78bb30 Compare March 13, 2026 21:42
Here we have removed ctrlc, thread and the channel and instead use raw
mode and set attributes and poll.
@Granddave Granddave force-pushed the improving-ctrlc-behavior branch from d78bb30 to 50202d4 Compare March 13, 2026 21:45
Copy link

@mtfurlan mtfurlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me <3

@Granddave
Copy link
Owner Author

Good to hear! Thanks for verifying.
I noticed that ctrl+c while selecting doesn't restore the cursor and the PR at the current state doesn't pass CI for Windows. So I will experiment when I get time to get it working before i merge anything.

@mtfurlan
Copy link

Alright, let me know if you want more testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0.5.0 leaves terminal in a bad state on exit

2 participants