Skip to content

Conversation

junikimm717
Copy link
Contributor

  • a separate bsp_tensor_t field is returned.

@willow-ahrens
Copy link

@BenBrock Here's the PR to add tensors to the spec, please review when you get the chance!

@BenBrock
Copy link
Contributor

BenBrock commented Apr 7, 2025

@junikimm717 @willow-ahrens Thanks for submitting the PR! At first glance everything looks generally good. I see two small problems:

  1. Missing SPDX headers on some of the new files (see example here)
  2. Incorrect path in testing infrastructure (see CI error here.).

I would also prefer to add a new flag ENABLE_TENSOR_TESTS or something like that to enable/disable the new tests (since they require Julia as an external dependency).

I'm also happy to fix these issues myself, but I have a busy week with a deadline coming up, so I probably won't be able to spend time on this until next week.

@willow-ahrens
Copy link

Currently, the tensor tests only run if Julia is installed. Is this sufficient?

@BenBrock
Copy link
Contributor

Yes, requiring Julia for the tensor tests is fine for now, as long as we can run the CI in GitHub actions. (That should be no problem.)

- name: Install Julia
run: curl -fsSL https://install.julialang.org | sh -s -- -y
- name: Disable Julia precompilation
run: julia -e 'using PrecompileTools, Preferences; set_preferences!(PrecompileTools, "precompile_workloads" => false; force=true)'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@willow-ahrens Does turning off precompilation in Julia like this make sense?

I'm doing this because precompilation takes a while, and it seems to me that the CI job ought to be faster overall without precompilation if we're installing and using the package once. (Julia will still JIT compute intensive portions, right?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the builds, it doesn't appear to actually turn off precompilation, and I'm not sure why. Let me know if you have any thoughts.

@BenBrock BenBrock merged commit a8c3ee3 into GraphBLAS:main Aug 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants