Skip to content

Allows numeric values to be parsed as GraphQLBools #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Allows numeric values to be parsed as GraphQLBools #156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Sources/GraphQL/Type/Scalars.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,11 @@ public let GraphQLBoolean = try! GraphQLScalarType(
if case let .bool(value) = inputValue {
return inputValue
}
// NOTE: We deviate from graphql-js and allow numeric conversions here because
// the MapCoder's round-trip conversion to NSObject for Bool converts to 0/1 numbers.
if case let .number(value) = inputValue {
return .bool(value.intValue != 0)
}
throw GraphQLError(
message: "Boolean cannot represent a non boolean value: \(inputValue)"
)
Expand Down
18 changes: 6 additions & 12 deletions Tests/GraphQLTests/TypeTests/ScalarTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,18 +300,12 @@ class ScalarTests: XCTestCase {
GraphQLBoolean.parseValue(.null),
"Boolean cannot represent a non boolean value: null"
)
try XCTAssertThrowsError(
GraphQLBoolean.parseValue(0),
"Boolean cannot represent a non boolean value: 0"
)
try XCTAssertThrowsError(
GraphQLBoolean.parseValue(1),
"Boolean cannot represent a non boolean value: 1"
)
try XCTAssertThrowsError(
GraphQLBoolean.parseValue(.double(Double.nan)),
"Boolean cannot represent a non boolean value: NaN"
)
// NOTE: We deviate from graphql-js and allow numeric conversions here because
// the MapCoder's round-trip conversion to NSObject for Bool converts to 0/1 numbers.
try XCTAssertNoThrow(GraphQLBoolean.parseValue(0))
try XCTAssertNoThrow(GraphQLBoolean.parseValue(1))
try XCTAssertNoThrow(GraphQLBoolean.parseValue(.double(Double.nan)))

try XCTAssertThrowsError(
GraphQLBoolean.parseValue(""),
#"Boolean cannot represent a non boolean value: """#
Expand Down
Loading