log and try loading file anyways if ACTION_VIEW MIME type is null, for app compatibility #411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 16, 2024 00:30
Some apps somehow end up giving us a pdf with a null MIME type. This makes us compatible with them instead of showing an invalid MIME type error. The error is still shown for MIME types that are not "application/pdf" and not null.
soupslurpr
force-pushed
the
compatibility-with-apps-that-report-null-mime-type
branch
from
85f9ba3 to
de576fb
Compare
soupslurpr
changed the title
soupslurpr
deleted the
compatibility-with-apps-that-report-null-mime-type
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some apps somehow end up giving us a pdf with a null MIME type. This makes us compatible with them instead of showing an invalid MIME type error. The error is still shown for MIME types that are both not "application/pdf" and not null.
This will probably resolve #387, but I haven't tried with the specific app reported in it. I had this issue with another app.