Skip to content

add release variant selection for installation process. This allows u…#1288

Open
cameronaaron wants to merge 1 commit intoGrapheneOS:mainfrom
cameronaaron:feature/webinstaller-release-variant
Open

add release variant selection for installation process. This allows u…#1288
cameronaaron wants to merge 1 commit intoGrapheneOS:mainfrom
cameronaaron:feature/webinstaller-release-variant

Conversation

@cameronaaron
Copy link
Copy Markdown

Allow Users to choose between stable and security preview releases.

…sers to choose between stable and security preview releases.
@cameronaaron cameronaaron marked this pull request as ready for review November 18, 2025 00:59
Copilot AI review requested due to automatic review settings November 18, 2025 00:59
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the ability for users to select between stable and security preview release variants during the GrapheneOS web installation process. The implementation includes UI controls for variant selection and logic to modify the release ID accordingly.

  • Adds radio button UI for users to choose between stable and security preview releases
  • Modifies release selection logic to transform release IDs for preview variants
  • Updates user-facing messages to indicate which variant is being downloaded/flashed

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
static/install/web.html Adds radio button controls for selecting release variant (stable or security preview)
static/js/web-install.js Implements getReleaseVariant() function, modifies getLatestRelease() to handle preview variants by transforming release IDs, and updates download/flash progress messages to display variant information

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread static/install/web.html
Comment thread static/install/web.html
Comment on lines +290 to +296
<label>
<input type="radio" name="release-variant" value="stable" checked="checked"/>
Stable release
</label>
<br/>
<label>
<input type="radio" name="release-variant" value="preview"/>
Copy link

Copilot AI Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The radio buttons lack proper identification attributes. Add 'id' attributes to the input elements and update the labels to use 'for' attributes that reference these IDs. For example: <input type=\"radio\" id=\"variant-stable\" name=\"release-variant\" .../> with <label for=\"variant-stable\">.

Suggested change
<label>
<input type="radio" name="release-variant" value="stable" checked="checked"/>
Stable release
</label>
<br/>
<label>
<input type="radio" name="release-variant" value="preview"/>
<label for="release-variant-stable">
<input type="radio" id="release-variant-stable" name="release-variant" value="stable" checked="checked"/>
Stable release
</label>
<br/>
<label for="release-variant-preview">
<input type="radio" id="release-variant-preview" name="release-variant" value="preview"/>

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn thats actually not a bad suggestion

Comment thread static/js/web-install.js
if (releaseId.endsWith("00")) {
releaseId = releaseId.slice(0, -2) + "01";
} else {
throw new Error("Unable to determine security preview release ID from stable release");
Copy link

Copilot AI Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error message doesn't provide actionable information for users or developers about why the conversion failed. Consider including the actual releaseId value in the error message, such as: throw new Error(Unable to determine security preview release ID from stable release: ${releaseId} does not end with '00');

Suggested change
throw new Error("Unable to determine security preview release ID from stable release");
throw new Error(`Unable to determine security preview release ID from stable release: ${releaseId} does not end with '00'`);

Copilot uses AI. Check for mistakes.
@thestinger thestinger force-pushed the main branch 3 times, most recently from 1308572 to fad75d8 Compare November 24, 2025 17:15
@thestinger thestinger force-pushed the main branch 4 times, most recently from 67ed9e5 to 9b9de3f Compare December 5, 2025 03:16
@thestinger thestinger force-pushed the main branch 9 times, most recently from 2118467 to 7e60dbd Compare December 15, 2025 07:15
@thestinger thestinger force-pushed the main branch 7 times, most recently from d97c2bd to 029d722 Compare December 24, 2025 19:10
@thestinger thestinger force-pushed the main branch 5 times, most recently from 654b8f1 to f531688 Compare January 28, 2026 23:05
@thestinger thestinger force-pushed the main branch 12 times, most recently from ef1436c to b4d7a8a Compare February 7, 2026 16:56
@thestinger thestinger force-pushed the main branch 4 times, most recently from aaddf37 to 87e56b0 Compare February 22, 2026 23:05
@thestinger thestinger force-pushed the main branch 2 times, most recently from 59ef0ae to 7d872a6 Compare March 4, 2026 19:01
@thestinger thestinger force-pushed the main branch 2 times, most recently from b05f646 to a219266 Compare March 27, 2026 18:28
@thestinger thestinger force-pushed the main branch 3 times, most recently from 020f8bc to 78da890 Compare May 1, 2026 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants