Merged
Conversation
thestinger
force-pushed
the
main
branch
11 times, most recently
from
3e40fe5 to
54c1c06
Compare
Member
|
Needs to be rebased because I retroactively fixed a comment to avoid propagating inaccurate information about BBIX BGP community support. |
thestinger
force-pushed
the
main
branch
3 times, most recently
from
5e9d1c6 to
fad8a3a
Compare
Contributor
Author
|
That should have worked. What about the attestation.app domain? Should I also add the records for it? |
Member
|
Yes, but note the addresses for it are different for knowing which someone was donating to. |
Contributor
Author
|
Yeah, I acknowledged that in my initial comment/PR description. |
Contributor
Author
|
Done. I also made 2 PRs to add the OpenAlias addresses to https://grapheneos.org/donate and https://attestation.app/donate |
thestinger
force-pushed
the
main
branch
5 times, most recently
from
6657a56 to
fa240f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue (#11) only requested an OpenAlias for Monero, but I went ahead and added the record for Bitcoin as well, since there isn't really any downside to having it around. I went for the Taproot address, since that's marked as being the preferred one on https://grapheneos.org/donate#bitcoin
Also, I guess any wallet new enough to support OpenAlias should definitely also support Taproot. So I think the compatibility concerns here are negligible.
I only set the OpenAlias TXT records for grapheneos.org and omitted them for the other domains owned by GrapheneOS Foundation, since I didn't see the point. But this can easily be added if it is deemed necessary.
I noticed that the donation page for attestation.app uses different BTC and XMR addresses. Should I also add OpenAlias records for that domain with the corresponding addresses?
Fixes #11