Remove superfluous const keyword from function declarations. Fixes #107

Author: deccer

src/Cpp/1-getting-started/1-1-2-HelloD3D11/HelloD3D11Application.hpp

@@ -18,8 +18,8 @@ class HelloD3D11Application final : public Application
     bool Initialize() override;
     bool Load() override;
     void OnResize(
-        const int32_t width,
-        const int32_t height) override;
+        int32_t width,
+        int32_t height) override;
     void Update() override;
     void Render() override;
 

src/Cpp/1-getting-started/1-1-3-HelloTriangle-Refactored/DeviceContext.cpp

@@ -10,7 +10,7 @@ DeviceContext::DeviceContext(WRL::ComPtr<ID3D11DeviceContext>&& deviceContext)
 
 void DeviceContext::Clear(
     ID3D11RenderTargetView* renderTarget,
-    const float clearColor[4]) const
+    float clearColor[4]) const
 {
     _deviceContext->ClearRenderTargetView(renderTarget, clearColor);
     _deviceContext->OMSetRenderTargets(1, &renderTarget, nullptr);

src/Cpp/1-getting-started/1-1-3-HelloTriangle-Refactored/DeviceContext.hpp

@@ -15,7 +15,7 @@ class DeviceContext
 
     void Clear(
         ID3D11RenderTargetView* renderTarget,
-        const float clearColor[4]) const;
+        float clearColor[4]) const;
     void SetPipeline(const Pipeline* pipeline);
     void SetVertexBuffer(
         ID3D11Buffer* triangleVertices,

src/Cpp/1-getting-started/1-1-3-HelloTriangle-Refactored/HelloTriangleApplication.cpp

@@ -211,7 +211,7 @@ void HelloTriangleApplication::Update()
 
 void HelloTriangleApplication::Render()
 {
-    constexpr float clearColor[] = { 0.1f, 0.1f, 0.1f, 1.0f };
+    float clearColor[] = { 0.1f, 0.1f, 0.1f, 1.0f };
     constexpr uint32_t vertexOffset = 0;
 
     _deviceContext->Clear(_renderTarget.Get(), clearColor);

src/Cpp/1-getting-started/1-1-3-HelloTriangle-Refactored/HelloTriangleApplication.hpp

@@ -21,8 +21,8 @@ class HelloTriangleApplication final : public Application
     bool Initialize() override;
     bool Load() override;
     void OnResize(
-        const int32_t width,
-        const int32_t height) override;
+        int32_t width,
+        int32_t height) override;
     void Update() override;
     void Render() override;
 

src/Cpp/1-getting-started/1-1-3-HelloTriangle-Refactored/Pipeline.hpp

@@ -13,10 +13,10 @@ class Pipeline
     friend class DeviceContext;
 
     void SetViewport(
-        const float left,
-        const float top,
-        const float width,
-        const float height);
+        float left,
+        float top,
+        float width,
+        float height);
 
 private:
     WRL::ComPtr<ID3D11VertexShader> _vertexShader = nullptr;

src/Cpp/1-getting-started/1-1-3-HelloTriangle-Refactored/PipelineFactory.hpp

@@ -33,7 +33,7 @@ class PipelineFactory
     [[nodiscard]] WRL::ComPtr<ID3D11PixelShader> CreatePixelShader(const std::wstring& filePath) const;
 
     bool CreateInputLayout(
-        const VertexType layoutInfo,
+        VertexType layoutInfo,
         const WRL::ComPtr<ID3DBlob>& vertexBlob,
         WRL::ComPtr<ID3D11InputLayout>& inputLayout);
 

src/Cpp/1-getting-started/1-1-3-HelloTriangle/HelloTriangleApplication.cpp

@@ -184,9 +184,9 @@ bool HelloTriangleApplication::Load()
 
 
 bool HelloTriangleApplication::CompileShader(
-    const std::wstring_view fileName,
-    const std::string_view entryPoint,
-    const std::string_view profile,
+    const std::wstring& fileName,
+    const std::string& entryPoint,
+    const std::string& profile,
     ComPtr<ID3DBlob>& shaderBlob) const
 {
     constexpr uint32_t compileFlags = D3DCOMPILE_ENABLE_STRICTNESS;
@@ -218,7 +218,7 @@ bool HelloTriangleApplication::CompileShader(
 }
 
 HelloTriangleApplication::ComPtr<ID3D11VertexShader> HelloTriangleApplication::CreateVertexShader(
-    const std::wstring_view fileName,
+    const std::wstring& fileName,
     ComPtr<ID3DBlob>& vertexShaderBlob) const
 {
     if (!CompileShader(fileName, "Main", "vs_5_0", vertexShaderBlob))
@@ -240,7 +240,7 @@ HelloTriangleApplication::ComPtr<ID3D11VertexShader> HelloTriangleApplication::C
     return vertexShader;
 }
 
-HelloTriangleApplication::ComPtr<ID3D11PixelShader> HelloTriangleApplication::CreatePixelShader(const std::wstring_view fileName) const
+HelloTriangleApplication::ComPtr<ID3D11PixelShader> HelloTriangleApplication::CreatePixelShader(const std::wstring& fileName) const
 {
     ComPtr<ID3DBlob> pixelShaderBlob = nullptr;
     if (!CompileShader(fileName, "Main", "ps_5_0", pixelShaderBlob))

src/Cpp/1-getting-started/1-1-3-HelloTriangle/HelloTriangleApplication.hpp

@@ -18,8 +18,8 @@ class HelloTriangleApplication final : public Application
     bool Initialize() override;
     bool Load() override;
     void OnResize(
-        const int32_t width,
-        const int32_t height) override;
+        int32_t width,
+        int32_t height) override;
     void Update() override;
     void Render() override;
 
@@ -28,14 +28,14 @@ class HelloTriangleApplication final : public Application
     void DestroySwapchainResources();
 
     bool CompileShader(
-        const std::wstring_view fileName,
-        const std::string_view entryPoint,
-        const std::string_view profile,
+        const std::wstring& fileName,
+        const std::string& entryPoint,
+        const std::string& profile,
         ComPtr<ID3DBlob>& shaderBlob) const;
     [[nodiscard]] ComPtr<ID3D11VertexShader> CreateVertexShader(
-        const std::wstring_view fileName,
+        const std::wstring& fileName,
         ComPtr<ID3DBlob>& vertexShaderBlob) const;
-    [[nodiscard]] ComPtr<ID3D11PixelShader> CreatePixelShader(std::wstring_view fileName) const;
+    [[nodiscard]] ComPtr<ID3D11PixelShader> CreatePixelShader(const std::wstring& fileName) const;
 
     ComPtr<ID3D11Device> _device = nullptr;
     ComPtr<ID3D11DeviceContext> _deviceContext = nullptr;

src/Cpp/1-getting-started/1-2-2-DebugLayer/DebugLayerApplication.cpp

@@ -223,7 +223,7 @@ void DebugLayerApplication::Update()
 
 void DebugLayerApplication::Render()
 {
-    constexpr float clearColor[] = { 0.1f, 0.1f, 0.1f, 1.0f };
+    float clearColor[] = { 0.1f, 0.1f, 0.1f, 1.0f };
     constexpr uint32_t vertexOffset = 0;
 
     _deviceContext->Clear(_renderTarget.Get(), clearColor);