Skip to content

Conversation

@0HyperCube
Copy link
Contributor

@0HyperCube 0HyperCube commented Nov 9, 2025

Closes #3340

@Keavon
Copy link
Member

Keavon commented Nov 11, 2025

Awesome! I'm especially a fan of the lines-of-code reduction, thank you for cleaning that up. I tested this extensively for you and only found a few minor things needing a fixup before we merge this:

  • There seems to be a regression where holding Ctrl for snapping to pixel increments (you'll want to zoom in to about 1000% to see) when using G no longer works, but it does work on master (demonstrated for you in this video):
capture_8_.mp4
  • When zoomed at a non-100% scale, the displacement visualization overlays move at the wrong rate for G translation, shown in this video taken from this branch:
asdf.mp4
  • Similarly to the previous point, this also seems to affect when the viewport is tilted and using G in unconstrained and locally X/Y constrained modes:
capture_11_.mp4
  • When translating with G locked along the local X or Y axis, we'd like the overlay to display the distance moved along that local axis (including any number typed by the user) rather than the X and Y components in document space (at the end of the video below, we see how I type numbers like 50, 150, 100, 500, etc. and it misleadingly shows that for the X and Y components instead of the diagonal/hypotenuse). That way it also matches the visualization of S local scaling for consistency (shown briefly at the local angle's diagonal at the beginning of the video below). See this video taken from this branch:
capture_10_.mp4

Hopefully these are quick fixes. Looking forward to merging this soon, thanks for helping with this!

@0HyperCube 0HyperCube marked this pull request as draft November 11, 2025 16:49
@0HyperCube 0HyperCube closed this Nov 11, 2025
@0HyperCube 0HyperCube reopened this Nov 24, 2025
@0HyperCube 0HyperCube force-pushed the bttr-local-grab branch 2 times, most recently from 2e78ff8 to 55bd8c0 Compare November 24, 2025 23:10
@0HyperCube
Copy link
Contributor Author

Thanks for taking the time to record these high quality video files @Keavon.

  1. I have now rounded in document coordinates even when you are relative to the viewport / local space
  2. I forgot to divide a thing by the viewport scale so it was broken
  3. ^
  4. Visualisations are part of Local-axis grab (G key) visualization is misaligned #3341 and so out of scope for my PR.

@0HyperCube 0HyperCube marked this pull request as ready for review November 24, 2025 23:11
@Keavon
Copy link
Member

Keavon commented Nov 25, 2025

!build

@github-actions
Copy link

📦 Build Complete for f9885a7
https://b79fb39d.graphite.pages.dev

Copy link
Member

@Keavon Keavon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Keavon Keavon changed the title Better local grab Fix regressions with G/R/S Nov 25, 2025
@Keavon Keavon merged commit 117ce30 into GraphiteEditor:master Nov 25, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Local-axis grab (G key) doesn't work on groups

2 participants