-
-
Notifications
You must be signed in to change notification settings - Fork 989
Fix regressions with G/R/S #3355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1bc25bf to
d9a89ab
Compare
|
Awesome! I'm especially a fan of the lines-of-code reduction, thank you for cleaning that up. I tested this extensively for you and only found a few minor things needing a fixup before we merge this:
capture_8_.mp4
asdf.mp4
capture_11_.mp4
capture_10_.mp4Hopefully these are quick fixes. Looking forward to merging this soon, thanks for helping with this! |
2e78ff8 to
55bd8c0
Compare
|
Thanks for taking the time to record these high quality video files @Keavon.
|
55bd8c0 to
f9885a7
Compare
|
!build |
|
Keavon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Closes #3340