Add basic thumbnail extraction to Rawkit #2659
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0HyperCube
reviewed
May 27, 2025
Contributor
0HyperCube
left a comment
0HyperCube
left a comment
There was a problem hiding this comment.
Thanks for the contribution.
The code looks good (although I don't really understand the RAW formats very well). From what I can tell the transform -> orientation rename is probably beneficial for clarity.
| #[derive(Debug, PartialEq, Eq, Clone, Copy, IntoPrimitive, TryFromPrimitive)] | ||
| #[repr(u16)] | ||
| #[allow(non_camel_case_types)] | ||
| pub enum CompressionValue { |
Contributor
There was a problem hiding this comment.
It might be nice to comment where these values have come from?
| let mut file = TiffRead::new(reader)?; | ||
| let ifd = Ifd::new_first_ifd(&mut file)?; | ||
|
|
||
| // TODO: ARW files Store the thumbnail offset and length in the first IFD. Add support for other file types in the future. |
Contributor
There was a problem hiding this comment.
Would it be worthwhile to do an assert on metadata::identify::identify_camera_model?
Keavon
force-pushed
the
master
branch
3 times, most recently
from
c7488cf to
1875779
Compare
Member
|
What's the latest status on this? Do the code review comments need to be actioned yet? Is it awaiting further code review? And I think I need to attend to the CI runner and update it so the failure is fixed.
|
Keavon
force-pushed
the
master
branch
4 times, most recently
from
ec51271 to
e025103
Compare
Member
|
@geom3trik just a reminder about my previous message in this thread :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.