Skip to content

Improve snapping performance #3067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 20, 2025
Merged

Improve snapping performance #3067

merged 4 commits into from
Aug 20, 2025

Conversation

TrueDoctor
Copy link
Member

@TrueDoctor TrueDoctor commented Aug 19, 2025 •
edited
Loading

Fixes snapping performance regressions introduced in #3036

  • Use a fat line algorithm to speed up cubic cubic intersection checks
  • Implement termination criteria for degenerate intersection check cases
  • Implement faster nearest point calculation
  • Loosen bounding boxes which are only used for pruning

@TrueDoctor TrueDoctor marked this pull request as ready for review August 20, 2025 07:27
@TrueDoctor TrueDoctor changed the title Use lyon_geom for intersection calculation of bezier segments Improve snapping performance Aug 20, 2025
@TrueDoctor TrueDoctor merged commit 7c30f61 into master Aug 20, 2025
4 checks passed
@TrueDoctor TrueDoctor deleted the faster-intersctions branch August 20, 2025 08:48
@TrueDoctor TrueDoctor mentioned this pull request Aug 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keavon Keavon Keavon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TrueDoctor @Keavon