Skip to content

Fix box selection regression where only intersected, not contained, objects get selected #3093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 27, 2025
Merged

Fix box selection regression where only intersected, not contained, objects get selected #3093

merged 5 commits into from
Aug 27, 2025

Conversation

indierusty
Copy link
Collaborator

@indierusty indierusty commented Aug 26, 2025 •
edited by Keavon
Loading

Regression from #3036.

Bug: Selection tool do not selects the target which is entirely within the selection path.
Fix: Fixed bezpath_is_inside_bezpath function incorrectly checking insideness.

Fixes https://discord.com/channels/731730685944922173/881073965047636018/1407746108498772062

@indierusty indierusty force-pushed the ir/refactor-click-targets branch from b0f99e2 to 7f74686 Compare August 26, 2025 03:28
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 26, 2025 •
edited
Loading

Performance Benchmark Results

🔧 Graph Compilation

compile_demo_art_iai::compile_group::compile_to_proto with_setup_0:load_from_name(isometric-fountain)
Instructions: 22,904,831 (master) → 27,726,182 (HEAD) : $$\color{red}+21.05\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                     287,771|    355,926         +23.68%
D1mw                      79,244|    119,325         +50.58%
DLmr                      28,574|     37,373         +30.79%
DLmw                      42,127|     54,746         +29.95%
Dr                     5,685,828|  6,726,828         +18.31%
Dw                     3,956,711|  4,755,320         +20.18%
EstimatedCycles       36,388,508| 44,100,340         +21.19%
I1mr                      56,757|     50,304         -11.37%
ILmr                         834|        874          +4.80%
Ir                    22,904,831| 27,726,182         +21.05%
L1hits                32,123,598| 38,682,775         +20.42%
LLhits                   352,237|    432,562         +22.80%
RamHits                   71,535|     92,993         +30.00%
TotalRW               32,547,370| 39,208,330         +20.47%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_1:load_from_name(painted-dreams)
Instructions: 12,178,300 (master) → 14,892,169 (HEAD) : $$\color{red}+22.28\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                     146,483|    183,598         +25.34%
D1mw                      41,599|     61,623         +48.14%
DLmr                         697|      1,569        +125.11%
DLmw                      14,067|     17,145         +21.88%
Dr                     3,009,605|  3,583,698         +19.08%
Dw                     2,094,080|  2,534,282         +21.02%
EstimatedCycles       18,609,779| 22,672,015         +21.83%
I1mr                      27,984|     24,348         -12.99%
ILmr                         687|        739          +7.57%
Ir                    12,178,300| 14,892,169         +22.28%
L1hits                17,065,919| 20,740,580         +21.53%
LLhits                   200,615|    250,116         +24.67%
RamHits                   15,451|     19,453         +25.90%
TotalRW               17,281,985| 21,010,149         +21.57%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_2:load_from_name(procedural-string-lights)
Instructions: 2,596,639 (master) → 3,132,255 (HEAD) : $$\color{red}+20.63\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                      30,982|     37,753         +21.85%
D1mw                       7,837|     12,153         +55.07%
DLmr                          15|         22         +46.67%
DLmw                       2,806|      3,254         +15.97%
Dr                       634,958|    750,129         +18.14%
Dw                       441,861|    529,647         +19.87%
EstimatedCycles        3,956,290|  4,752,499         +20.13%
I1mr                       5,729|      5,271          -7.99%
ILmr                         667|        716          +7.35%
Ir                     2,596,639|  3,132,255         +20.63%
L1hits                 3,628,910|  4,356,854         +20.06%
LLhits                    41,060|     51,185         +24.66%
RamHits                    3,488|      3,992         +14.45%
TotalRW                3,673,458|  4,412,031         +20.11%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_3:load_from_name(parametric-dunescape)
Instructions: 12,309,805 (master) → 14,970,492 (HEAD) : $$\color{red}+21.61\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                     160,565|    197,338         +22.90%
D1mw                      44,775|     68,381         +52.72%
DLmr                          81|        139         +71.60%
DLmw                      14,782|     14,482          -2.03%
Dr                     3,012,421|  3,600,655         +19.53%
Dw                     2,119,847|  2,572,173         +21.34%
EstimatedCycles       18,821,115| 22,752,384         +20.89%
I1mr                      22,068|     20,477          -7.21%
ILmr                         784|        855          +9.06%
Ir                    12,309,805| 14,970,492         +21.61%
L1hits                17,214,665| 20,857,124         +21.16%
LLhits                   211,761|    270,720         +27.84%
RamHits                   15,647|     15,476          -1.09%
TotalRW               17,442,073| 21,143,320         +21.22%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_4:load_from_name(red-dress)
Instructions: 27,610,694 (master) → 33,726,504 (HEAD) : $$\color{red}+22.15\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                     348,278|    431,266         +23.83%
D1mw                      93,015|    142,692         +53.41%
DLmr                      42,555|     53,127         +24.84%
DLmw                      61,137|     62,308          +1.92%
Dr                     6,824,615|  8,123,367         +19.03%
Dw                     4,753,163|  5,755,114         +21.08%
EstimatedCycles       44,341,038| 53,611,047         +20.91%
I1mr                      63,016|     55,240         -12.34%
ILmr                         819|        874          +6.72%
Ir                    27,610,694| 33,726,504         +22.15%
L1hits                38,684,163| 46,975,787         +21.43%
LLhits                   399,798|    512,889         +28.29%
RamHits                  104,511|    116,309         +11.29%
TotalRW               39,188,472| 47,604,985         +21.48%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_5:load_from_name(valley-of-spires)
Instructions: 17,591,041 (master) → 21,418,864 (HEAD) : $$\color{red}+21.76\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                     215,331|    269,451         +25.13%
D1mw                      55,212|     84,599         +53.23%
DLmr                      13,861|     19,785         +42.74%
DLmw                      29,607|     36,616         +23.67%
Dr                     4,369,696|  5,186,695         +18.70%
Dw                     3,035,002|  3,662,862         +20.69%
EstimatedCycles       27,575,581| 33,552,299         +21.67%
I1mr                      42,670|     37,792         -11.43%
ILmr                         765|        816          +6.67%
Ir                    17,591,041| 21,418,864         +21.76%
L1hits                24,682,526| 29,876,579         +21.04%
LLhits                   268,980|    334,625         +24.41%
RamHits                   44,233|     57,217         +29.35%
TotalRW               24,995,739| 30,268,421         +21.09%

🔄 Executor Update

update_executor_iai::update_group::update_executor with_setup_0:setup_update_executor(isometric-fountain)
Instructions: 41,190,245 (master) → 41,886,666 (HEAD) : $$\color{red}+1.69\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                     455,911|    476,071          +4.42%
D1mw                      99,656|    107,199          +7.57%
DLmr                       7,865|     17,975        +128.54%
DLmw                      27,623|     18,720         -32.23%
Dr                    10,456,877| 10,636,737          +1.72%
Dw                     7,080,977|  7,205,134          +1.75%
EstimatedCycles       62,162,633| 63,374,915          +1.95%
I1mr                      35,159|     51,372         +46.11%
ILmr                         233|        232          -0.43%
Ir                    41,190,245| 41,886,666          +1.69%
L1hits                58,137,373| 59,093,895          +1.65%
LLhits                   555,005|    597,715          +7.70%
RamHits                   35,721|     36,927          +3.38%
TotalRW               58,728,099| 59,728,537          +1.70%

update_executor_iai::update_group::update_executor with_setup_1:setup_update_executor(painted-dreams)
Instructions: 22,780,737 (master) → 23,074,627 (HEAD) : $$\color{red}+1.29\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                     238,346|    244,886          +2.74%
D1mw                      52,484|     54,772          +4.36%
DLmr                       1,034|        408         -60.54%
DLmw                      11,548|      8,087         -29.97%
Dr                     5,745,801|  5,818,462          +1.26%
Dw                     3,908,564|  3,956,652          +1.23%
EstimatedCycles       34,070,256| 34,419,353          +1.02%
I1mr                      22,056|     27,660         +25.41%
ILmr                         205|        183         -10.73%
Ir                    22,780,737| 23,074,627          +1.29%
L1hits                32,122,216| 32,522,423          +1.25%
LLhits                   300,099|    318,640          +6.18%
RamHits                   12,787|      8,678         -32.13%
TotalRW               32,435,102| 32,849,741          +1.28%

update_executor_iai::update_group::update_executor with_setup_2:setup_update_executor(procedural-string-lights)
Instructions: 4,761,808 (master) → 4,721,405 (HEAD) : $$\color{lime}-0.85\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                      46,372|     43,883          -5.37%
D1mw                      11,437|     12,327          +7.78%
DLmr                           2|          0        -100.00%
DLmw                         709|        758          +6.91%
Dr                     1,199,259|  1,186,229          -1.09%
Dw                       816,743|    809,126          -0.93%
EstimatedCycles        7,057,070|  7,001,996          -0.78%
I1mr                       5,166|      8,094         +56.68%
ILmr                         201|        176         -12.44%
Ir                     4,761,808|  4,721,405          -0.85%
L1hits                 6,714,835|  6,652,456          -0.93%
LLhits                    62,063|     63,370          +2.11%
RamHits                      912|        934          +2.41%
TotalRW                6,777,810|  6,716,760          -0.90%

update_executor_iai::update_group::update_executor with_setup_3:setup_update_executor(parametric-dunescape)
Instructions: 18,942,147 (master) → 18,958,547 (HEAD) : $$\color{red}+0.09\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                     186,223|    186,599          +0.20%
D1mw                      46,605|     48,074          +3.15%
DLmr                         145|         27         -81.38%
DLmw                       6,547|      4,632         -29.25%
Dr                     4,732,322|  4,758,897          +0.56%
Dw                     3,247,455|  3,275,096          +0.85%
EstimatedCycles       28,118,960| 28,152,490          +0.12%
I1mr                      14,861|     18,992         +27.80%
ILmr                         184|        184          +0.00%
Ir                    18,942,147| 18,958,547          +0.09%
L1hits                26,674,235| 26,738,875          +0.24%
LLhits                   240,813|    248,822          +3.33%
RamHits                    6,876|      4,843         -29.57%
TotalRW               26,921,924| 26,992,540          +0.26%

update_executor_iai::update_group::update_executor with_setup_4:setup_update_executor(red-dress)
Instructions: 51,172,187 (master) → 51,969,971 (HEAD) : $$\color{red}+1.56\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                     547,298|    586,521          +7.17%
D1mw                     125,809|    135,794          +7.94%
DLmr                      17,371|     33,408         +92.32%
DLmw                      46,973|     42,748          -8.99%
Dr                    13,140,262| 13,327,658          +1.43%
Dw                     9,013,415|  9,148,451          +1.50%
EstimatedCycles       78,114,486| 79,870,862          +2.25%
I1mr                      39,346|     59,478         +51.17%
ILmr                         283|        431         +52.30%
Ir                    51,172,187| 51,969,971          +1.56%
L1hits                72,613,411| 73,664,287          +1.45%
LLhits                   647,826|    705,206          +8.86%
RamHits                   64,627|     76,587         +18.51%
TotalRW               73,325,864| 74,446,080          +1.53%

update_executor_iai::update_group::update_executor with_setup_5:setup_update_executor(valley-of-spires)
Instructions: 32,771,247 (master) → 33,377,354 (HEAD) : $$\color{red}+1.85\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                     360,149|    374,194          +3.90%
D1mw                      78,460|     86,102          +9.74%
DLmr                       3,718|      9,298        +150.08%
DLmw                      19,971|     21,860          +9.46%
Dr                     8,333,823|  8,462,809          +1.55%
Dw                     5,655,174|  5,738,831          +1.48%
EstimatedCycles       49,344,754| 50,523,862          +2.39%
I1mr                      28,246|     40,751         +44.27%
ILmr                         214|        198          -7.48%
Ir                    32,771,247| 33,377,354          +1.85%
L1hits                46,293,389| 47,077,947          +1.69%
LLhits                   442,952|    469,691          +6.04%
RamHits                   23,903|     31,356         +31.18%
TotalRW               46,760,244| 47,578,994          +1.75%

🚀 Render: Cold Execution

run_once_iai::run_once_group::run_once with_setup_0:setup_run_once(isometric-fountain)
Instructions: 20,724,627 (master) → 20,662,835 (HEAD) : $$\color{lime}-0.30\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                     237,096|    235,445          -0.70%
D1mw                      50,141|     50,273          +0.26%
DLmr                       8,598|      3,312         -61.48%
DLmw                      15,481|     13,441         -13.18%
Dr                     5,279,997|  5,257,502          -0.43%
Dw                     3,530,717|  3,525,689          -0.14%
EstimatedCycles       32,008,423| 31,672,522          -1.05%
I1mr                     114,651|    109,881          -4.16%
ILmr                       4,772|      4,717          -1.15%
Ir                    20,724,627| 20,662,835          -0.30%
L1hits                29,133,453| 29,050,427          -0.28%
LLhits                   373,037|    374,129          +0.29%
RamHits                   28,851|     21,470         -25.58%
TotalRW               29,535,341| 29,446,026          -0.30%

run_once_iai::run_once_group::run_once with_setup_1:setup_run_once(painted-dreams)
Instructions: 76,733,578 (master) → 76,819,554 (HEAD) : $$\color{red}+0.11\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                     385,678|    386,751          +0.28%
D1mw                     179,364|    182,045          +1.49%
DLmr                       5,126|      4,925          -3.92%
DLmw                      46,172|     53,778         +16.47%
Dr                    18,126,256| 18,203,811          +0.43%
Dw                    12,145,757| 12,226,548          +0.67%
EstimatedCycles      111,632,007|112,091,919          +0.41%
I1mr                     154,042|    149,608          -2.88%
ILmr                       7,038|      6,910          -1.82%
Ir                    76,733,578| 76,819,554          +0.11%
L1hits               106,286,507|106,531,509          +0.23%
LLhits                   660,748|    652,791          -1.20%
RamHits                   58,336|     65,613         +12.47%
TotalRW              107,005,591|107,249,913          +0.23%

run_once_iai::run_once_group::run_once with_setup_2:setup_run_once(procedural-string-lights)
Instructions: 9,564,513 (master) → 9,926,047 (HEAD) : $$\color{red}+3.78\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                      38,195|     49,365         +29.24%
D1mw                      16,334|     16,663          +2.01%
DLmr                         235|        240          +2.13%
DLmw                       3,467|      3,974         +14.62%
Dr                     2,184,338|  2,276,903          +4.24%
Dw                     1,514,692|  1,574,925          +3.98%
EstimatedCycles       13,853,341| 14,411,385          +4.03%
I1mr                      34,473|     31,262          -9.31%
ILmr                       4,091|      3,931          -3.91%
Ir                     9,564,513|  9,926,047          +3.78%
L1hits                13,174,541| 13,680,585          +3.84%
LLhits                    81,209|     89,145          +9.77%
RamHits                    7,793|      8,145          +4.52%
TotalRW               13,263,543| 13,777,875          +3.88%

run_once_iai::run_once_group::run_once with_setup_3:setup_run_once(parametric-dunescape)
Instructions: 26,336,869 (master) → 26,414,183 (HEAD) : $$\color{red}+0.29\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                     122,293|    120,356          -1.58%
D1mw                      52,226|     53,075          +1.63%
DLmr                       1,600|        525         -67.19%
DLmw                      10,413|      8,602         -17.39%
Dr                     5,862,879|  5,915,119          +0.89%
Dw                     3,492,901|  3,547,529          +1.56%
EstimatedCycles       37,098,129| 37,191,811          +0.25%
I1mr                      62,026|     62,329          +0.49%
ILmr                       3,297|      3,271          -0.79%
Ir                    26,336,869| 26,414,183          +0.29%
L1hits                35,456,104| 35,641,071          +0.52%
LLhits                   221,235|    223,362          +0.96%
RamHits                   15,310|     12,398         -19.02%
TotalRW               35,692,649| 35,876,831          +0.52%

run_once_iai::run_once_group::run_once with_setup_4:setup_run_once(red-dress)
Instructions: 1,884,663,937 (master) → 1,884,180,331 (HEAD) : $$\color{lime}-0.03\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                   1,520,236|  1,523,112          +0.19%
D1mw                     690,713|    702,033          +1.64%
DLmr                     318,642|    310,110          -2.68%
DLmw                     456,722|    424,424          -7.07%
Dr                   437,507,045|436,931,825          -0.13%
Dw                   279,339,127|278,710,332          -0.23%
EstimatedCycles      2,636,714,859|2,633,532,194          -0.12%
I1mr                     736,826|    656,009         -10.97%
ILmr                       5,091|      4,969          -2.40%
Ir                   1,884,663,937|1,884,180,331          -0.03%
L1hits               2,598,562,334|2,596,941,334          -0.06%
LLhits                 2,167,320|  2,141,651          -1.18%
RamHits                  780,455|    739,503          -5.25%
TotalRW              2,601,510,109|2,599,822,488          -0.06%

run_once_iai::run_once_group::run_once with_setup_5:setup_run_once(valley-of-spires)
Instructions: 19,145,455 (master) → 19,032,364 (HEAD) : $$\color{lime}-0.59\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                     191,271|    190,179          -0.57%
D1mw                      43,892|     42,526          -3.11%
DLmr                       5,559|        639         -88.51%
DLmw                      12,252|      9,960         -18.71%
Dr                     4,674,966|  4,630,896          -0.94%
Dw                     3,101,166|  3,077,226          -0.77%
EstimatedCycles       28,857,175| 28,437,782          -1.45%
I1mr                      92,374|     89,544          -3.06%
ILmr                       3,037|      3,011          -0.86%
Ir                    19,145,455| 19,032,364          -0.59%
L1hits                26,594,050| 26,418,237          -0.66%
LLhits                   306,689|    308,639          +0.64%
RamHits                   20,848|     13,610         -34.72%
TotalRW               26,921,587| 26,740,486          -0.67%

⚡ Render: Cached Execution

run_cached_iai::run_cached_group::run_cached with_setup_0:setup_run_cached(isometric-fountain)
Instructions: 20,863,324 (master) → 20,783,351 (HEAD) : $$\color{lime}-0.38\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                     253,289|    253,626          +0.13%
D1mw                      45,623|     45,948          +0.71%
DLmr                       2,035|      2,861         +40.59%
DLmw                         534|        573          +7.30%
Dr                     5,386,559|  5,351,970          -0.64%
Dw                     3,565,710|  3,557,792          -0.22%
EstimatedCycles       31,550,549| 31,439,401          -0.35%
I1mr                     114,382|    110,208          -3.65%
ILmr                         157|        138         -12.10%
Ir                    20,863,324| 20,783,351          -0.38%
L1hits                29,402,299| 29,283,331          -0.40%
LLhits                   410,568|    406,210          -1.06%
RamHits                    2,726|      3,572         +31.03%
TotalRW               29,815,593| 29,693,113          -0.41%

run_cached_iai::run_cached_group::run_cached with_setup_1:setup_run_cached(painted-dreams)
Instructions: 26,326,896 (master) → 26,340,427 (HEAD) : $$\color{red}+0.05\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                     220,174|    215,148          -2.28%
D1mw                      54,260|     54,256          -0.01%
DLmr                       1,028|      3,504        +240.86%
DLmw                         918|      1,841        +100.54%
Dr                     6,487,359|  6,489,627          +0.03%
Dw                     4,426,672|  4,438,620          +0.27%
EstimatedCycles       38,685,559| 38,777,780          +0.24%
I1mr                      70,974|     66,825          -5.85%
ILmr                         154|        128         -16.88%
Ir                    26,326,896| 26,340,427          +0.05%
L1hits                36,895,519| 36,932,445          +0.10%
LLhits                   343,308|    330,756          -3.66%
RamHits                    2,100|      5,473        +160.62%
TotalRW               37,240,927| 37,268,674          +0.07%

run_cached_iai::run_cached_group::run_cached with_setup_2:setup_run_cached(procedural-string-lights)
Instructions: 9,240,106 (master) → 9,286,181 (HEAD) : $$\color{red}+0.50\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                      51,057|     51,323          +0.52%
D1mw                      14,082|     15,763         +11.94%
DLmr                           9|          5         -44.44%
DLmw                          98|         95          -3.06%
Dr                     2,127,417|  2,205,916          +3.69%
Dw                     1,470,253|  1,556,150          +5.84%
EstimatedCycles       13,233,688| 13,439,761          +1.56%
I1mr                      31,889|     29,105          -8.73%
ILmr                         153|        125         -18.30%
Ir                     9,240,106|  9,286,181          +0.50%
L1hits                12,740,748| 12,952,056          +1.66%
LLhits                    96,768|     95,966          -0.83%
RamHits                      260|        225         -13.46%
TotalRW               12,837,776| 13,048,247          +1.64%

run_cached_iai::run_cached_group::run_cached with_setup_3:setup_run_cached(parametric-dunescape)
Instructions: 16,201,850 (master) → 16,131,399 (HEAD) : $$\color{lime}-0.43\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                     106,584|    104,945          -1.54%
D1mw                      37,507|     37,774          +0.71%
DLmr                          43|         23         -46.51%
DLmw                       1,243|        811         -34.75%
Dr                     3,681,323|  3,662,383          -0.51%
Dw                     2,444,413|  2,435,918          -0.35%
EstimatedCycles       23,047,700| 22,929,588          -0.51%
I1mr                      25,430|     25,188          -0.95%
ILmr                         115|        108          -6.09%
Ir                    16,201,850| 16,131,399          -0.43%
L1hits                22,158,065| 22,061,793          -0.43%
LLhits                   168,120|    166,965          -0.69%
RamHits                    1,401|        942         -32.76%
TotalRW               22,327,586| 22,229,700          -0.44%

run_cached_iai::run_cached_group::run_cached with_setup_4:setup_run_cached(red-dress)
Instructions: 280,097,876 (master) → 279,749,616 (HEAD) : $$\color{lime}-0.12\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                   1,422,474|  1,419,809          -0.19%
D1mw                     459,188|    458,804          -0.08%
DLmr                     493,719|    470,912          -4.62%
DLmw                     232,215|    201,752         -13.12%
Dr                    68,076,523| 67,840,078          -0.35%
Dw                    48,900,379| 48,607,909          -0.60%
EstimatedCycles      429,103,978|426,364,461          -0.64%
I1mr                     651,568|    588,024          -9.75%
ILmr                       3,942|      4,013          +1.80%
Ir                   280,097,876|279,749,616          -0.12%
L1hits               394,541,548|393,730,966          -0.21%
LLhits                 1,803,354|  1,789,960          -0.74%
RamHits                  729,876|    676,677          -7.29%
TotalRW              397,074,778|396,197,603          -0.22%

run_cached_iai::run_cached_group::run_cached with_setup_5:setup_run_cached(valley-of-spires)
Instructions: 19,407,868 (master) → 19,319,114 (HEAD) : $$\color{lime}-0.46\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                     207,260|    205,559          -0.82%
D1mw                      40,398|     40,519          +0.30%
DLmr                         240|        146         -39.17%
DLmw                         650|      1,046         +60.92%
Dr                     4,786,558|  4,763,167          -0.49%
Dw                     3,135,621|  3,135,497          -0.00%
EstimatedCycles       28,733,251| 28,613,734          -0.42%
I1mr                      95,388|     93,041          -2.46%
ILmr                         144|        124         -13.89%
Ir                    19,407,868| 19,319,114          -0.46%
L1hits                26,987,001| 26,878,659          -0.40%
LLhits                   342,012|    337,803          -1.23%
RamHits                    1,034|      1,316         +27.27%
TotalRW               27,330,047| 27,217,778          -0.41%

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 26, 2025 •
edited
Loading

Performance Benchmark Results

🔧 Graph Compilation

compile_demo_art_iai::compile_group::compile_to_proto with_setup_0:load_from_name(isometric-fountain)
Instructions: 22,909,117 (master) → 27,725,580 (HEAD) : $$\color{red}+21.02\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                     287,751|    356,090         +23.75%
D1mw                      79,279|    119,340         +50.53%
DLmr                      28,574|     37,374         +30.80%
DLmw                      42,134|     54,740         +29.92%
Dr                     5,686,424|  6,726,797         +18.30%
Dw                     3,956,704|  4,755,371         +20.19%
EstimatedCycles       36,393,653| 44,097,632         +21.17%
I1mr                      56,757|     49,646         -12.53%
ILmr                         834|        872          +4.56%
Ir                    22,909,117| 27,725,580         +21.02%
L1hits                32,128,458| 38,682,672         +20.40%
LLhits                   352,245|    432,090         +22.67%
RamHits                   71,542|     92,986         +29.97%
TotalRW               32,552,245| 39,207,748         +20.45%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_1:load_from_name(painted-dreams)
Instructions: 12,179,391 (master) → 14,889,929 (HEAD) : $$\color{red}+22.26\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                     146,518|    183,774         +25.43%
D1mw                      41,626|     61,725         +48.28%
DLmr                         697|      1,567        +124.82%
DLmw                      14,053|     17,144         +22.00%
Dr                     3,009,725|  3,583,355         +19.06%
Dw                     2,094,076|  2,534,231         +21.02%
EstimatedCycles       18,610,780| 22,668,849         +21.80%
I1mr                      27,983|     23,982         -14.30%
ILmr                         686|        736          +7.29%
Ir                    12,179,391| 14,889,929         +22.26%
L1hits                17,067,065| 20,738,034         +21.51%
LLhits                   200,691|    250,034         +24.59%
RamHits                   15,436|     19,447         +25.98%
TotalRW               17,283,192| 21,007,515         +21.55%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_2:load_from_name(procedural-string-lights)
Instructions: 2,596,388 (master) → 3,132,315 (HEAD) : $$\color{red}+20.64\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                      30,965|     37,795         +22.06%
D1mw                       7,833|     12,161         +55.25%
DLmr                          15|         21         +40.00%
DLmw                       2,808|      3,253         +15.85%
Dr                       634,882|    750,231         +18.17%
Dw                       441,829|    529,729         +19.89%
EstimatedCycles        3,955,907|  4,752,583         +20.14%
I1mr                       5,729|      5,196          -9.30%
ILmr                         667|        716          +7.35%
Ir                     2,596,388|  3,132,315         +20.64%
L1hits                 3,628,572|  4,357,123         +20.08%
LLhits                    41,037|     51,162         +24.67%
RamHits                    3,490|      3,990         +14.33%
TotalRW                3,673,099|  4,412,275         +20.12%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_3:load_from_name(parametric-dunescape)
Instructions: 12,308,457 (master) → 14,970,388 (HEAD) : $$\color{red}+21.63\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                     160,625|    197,243         +22.80%
D1mw                      44,772|     68,413         +52.80%
DLmr                          81|        137         +69.14%
DLmw                      14,784|     14,481          -2.05%
Dr                     3,012,250|  3,600,652         +19.53%
Dw                     2,119,877|  2,572,223         +21.34%
EstimatedCycles       18,819,914| 22,751,081         +20.89%
I1mr                      22,068|     20,251          -8.23%
ILmr                         784|        855          +9.06%
Ir                    12,308,457| 14,970,388         +21.63%
L1hits                17,213,119| 20,857,356         +21.17%
LLhits                   211,816|    270,434         +27.67%
RamHits                   15,649|     15,473          -1.12%
TotalRW               17,440,584| 21,143,263         +21.23%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_4:load_from_name(red-dress)
Instructions: 27,610,488 (master) → 33,731,453 (HEAD) : $$\color{red}+22.17\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                     348,435|    431,276         +23.78%
D1mw                      92,989|    142,518         +53.26%
DLmr                      42,555|     53,121         +24.83%
DLmw                      61,168|     62,316          +1.88%
Dr                     6,824,670|  8,124,048         +19.04%
Dw                     4,753,260|  5,755,195         +21.08%
EstimatedCycles       44,342,472| 53,613,276         +20.91%
I1mr                      63,017|     54,511         -13.50%
ILmr                         820|        875          +6.71%
Ir                    27,610,488| 33,731,453         +22.17%
L1hits                38,683,977| 46,982,391         +21.45%
LLhits                   399,898|    511,993         +28.03%
RamHits                  104,543|    116,312         +11.26%
TotalRW               39,188,418| 47,610,696         +21.49%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_5:load_from_name(valley-of-spires)
Instructions: 17,590,561 (master) → 21,416,671 (HEAD) : $$\color{red}+21.75\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                     215,360|    269,355         +25.07%
D1mw                      55,238|     84,567         +53.10%
DLmr                      13,861|     19,778         +42.69%
DLmw                      29,594|     36,614         +23.72%
Dr                     4,369,694|  5,186,549         +18.69%
Dw                     3,035,061|  3,662,986         +20.69%
EstimatedCycles       27,574,988| 33,547,374         +21.66%
I1mr                      42,670|     37,250         -12.70%
ILmr                         765|        824          +7.71%
Ir                    17,590,561| 21,416,671         +21.75%
L1hits                24,682,048| 29,875,034         +21.04%
LLhits                   269,048|    333,956         +24.13%
RamHits                   44,220|     57,216         +29.39%
TotalRW               24,995,316| 30,266,206         +21.09%

🔄 Executor Update

update_executor_iai::update_group::update_executor with_setup_0:setup_update_executor(isometric-fountain)
Instructions: 41,172,482 (master) → 41,927,230 (HEAD) : $$\color{red}+1.83\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                     454,645|    472,629          +3.96%
D1mw                      98,734|    107,734          +9.12%
DLmr                       7,781|     18,560        +138.53%
DLmw                      27,923|     23,957         -14.20%
Dr                    10,453,334| 10,643,897          +1.82%
Dw                     7,072,992|  7,205,368          +1.87%
EstimatedCycles       62,129,406| 63,452,341          +2.13%
I1mr                      34,713|     17,966         -48.24%
ILmr                         237|        234          -1.27%
Ir                    41,172,482| 41,927,230          +1.83%
L1hits                58,110,716| 59,178,166          +1.84%
LLhits                   552,151|    555,578          +0.62%
RamHits                   35,941|     42,751         +18.95%
TotalRW               58,698,808| 59,776,495          +1.84%

update_executor_iai::update_group::update_executor with_setup_1:setup_update_executor(painted-dreams)
Instructions: 22,784,024 (master) → 23,083,836 (HEAD) : $$\color{red}+1.32\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                     238,935|    244,767          +2.44%
D1mw                      53,336|     55,573          +4.19%
DLmr                       1,023|        344         -66.37%
DLmw                      12,056|      8,499         -29.50%
Dr                     5,746,609|  5,820,432          +1.28%
Dw                     3,908,003|  3,958,413          +1.29%
EstimatedCycles       34,092,470| 34,367,563          +0.81%
I1mr                      21,535|      8,163         -62.09%
ILmr                         208|        186         -10.58%
Ir                    22,784,024| 23,083,836          +1.32%
L1hits                32,124,830| 32,554,178          +1.34%
LLhits                   300,519|    299,474          -0.35%
RamHits                   13,287|      9,029         -32.05%
TotalRW               32,438,636| 32,862,681          +1.31%

update_executor_iai::update_group::update_executor with_setup_2:setup_update_executor(procedural-string-lights)
Instructions: 4,739,465 (master) → 4,714,388 (HEAD) : $$\color{lime}-0.53\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                      45,316|     44,619          -1.54%
D1mw                      11,480|     12,606          +9.81%
DLmr                           2|          0        -100.00%
DLmw                         390|        670         +71.79%
Dr                     1,193,083|  1,184,128          -0.75%
Dw                       812,148|    807,080          -0.62%
EstimatedCycles        7,010,820|  6,976,288          -0.49%
I1mr                       5,295|      4,148         -21.66%
ILmr                         200|        170         -15.00%
Ir                     4,739,465|  4,714,388          -0.53%
L1hits                 6,682,605|  6,644,223          -0.57%
LLhits                    61,499|     60,533          -1.57%
RamHits                      592|        840         +41.89%
TotalRW                6,744,696|  6,705,596          -0.58%

update_executor_iai::update_group::update_executor with_setup_3:setup_update_executor(parametric-dunescape)
Instructions: 18,952,911 (master) → 18,964,155 (HEAD) : $$\color{red}+0.06\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                     186,402|    187,346          +0.51%
D1mw                      46,366|     47,454          +2.35%
DLmr                         142|         31         -78.17%
DLmw                       6,583|      5,002         -24.02%
Dr                     4,734,282|  4,760,204          +0.55%
Dw                     3,249,863|  3,278,283          +0.87%
EstimatedCycles       28,134,802| 28,121,668          -0.05%
I1mr                      14,836|      5,859         -60.51%
ILmr                         186|        180          -3.23%
Ir                    18,952,911| 18,964,155          +0.06%
L1hits                26,689,452| 26,761,983          +0.27%
LLhits                   240,693|    235,446          -2.18%
RamHits                    6,911|      5,213         -24.57%
TotalRW               26,937,056| 27,002,642          +0.24%

update_executor_iai::update_group::update_executor with_setup_4:setup_update_executor(red-dress)
Instructions: 51,186,815 (master) → 51,972,073 (HEAD) : $$\color{red}+1.53\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                     549,421|    575,355          +4.72%
D1mw                     124,799|    134,722          +7.95%
DLmr                      17,619|     33,727         +91.42%
DLmw                      45,826|     45,534          -0.64%
Dr                    13,143,383| 13,325,583          +1.39%
Dw                     9,022,211|  9,143,591          +1.35%
EstimatedCycles       78,122,303| 79,747,285          +2.08%
I1mr                      40,241|     18,915         -53.00%
ILmr                         290|        408         +40.69%
Ir                    51,186,815| 51,972,073          +1.53%
L1hits                72,637,948| 73,712,255          +1.48%
LLhits                   650,726|    649,323          -0.22%
RamHits                   63,735|     79,669         +25.00%
TotalRW               73,352,409| 74,441,247          +1.48%

update_executor_iai::update_group::update_executor with_setup_5:setup_update_executor(valley-of-spires)
Instructions: 32,755,325 (master) → 33,394,414 (HEAD) : $$\color{red}+1.95\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                     359,701|    379,180          +5.42%
D1mw                      78,781|     87,641         +11.25%
DLmr                       3,740|      9,365        +150.40%
DLmw                      19,616|     20,160          +2.77%
Dr                     8,330,895|  8,467,138          +1.64%
Dw                     5,655,336|  5,743,193          +1.55%
EstimatedCycles       49,315,872| 50,417,111          +2.23%
I1mr                      28,337|     13,408         -52.68%
ILmr                         212|        190         -10.38%
Ir                    32,755,325| 33,394,414          +1.95%
L1hits                46,274,737| 47,124,516          +1.84%
LLhits                   443,251|    450,514          +1.64%
RamHits                   23,568|     29,715         +26.08%
TotalRW               46,741,556| 47,604,745          +1.85%

🚀 Render: Cold Execution

run_once_iai::run_once_group::run_once with_setup_0:setup_run_once(isometric-fountain)
Instructions: 20,720,274 (master) → 20,639,436 (HEAD) : $$\color{lime}-0.39\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                     236,393|    234,245          -0.91%
D1mw                      49,839|     49,837          -0.00%
DLmr                       8,536|      3,327         -61.02%
DLmw                      15,411|     13,359         -13.32%
Dr                     5,277,146|  5,250,941          -0.50%
Dw                     3,528,248|  3,521,319          -0.20%
EstimatedCycles       31,990,500| 31,631,978          -1.12%
I1mr                     114,591|    110,571          -3.51%
ILmr                       4,771|      4,703          -1.43%
Ir                    20,720,274| 20,639,436          -0.39%
L1hits                29,124,845| 29,017,043          -0.37%
LLhits                   372,105|    373,264          +0.31%
RamHits                   28,718|     21,389         -25.52%
TotalRW               29,525,668| 29,411,696          -0.39%

run_once_iai::run_once_group::run_once with_setup_1:setup_run_once(painted-dreams)
Instructions: 76,709,793 (master) → 76,795,245 (HEAD) : $$\color{red}+0.11\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                     385,587|    385,233          -0.09%
D1mw                     179,612|    182,093          +1.38%
DLmr                       5,196|      4,847          -6.72%
DLmw                      47,110|     53,949         +14.52%
Dr                    18,118,700| 18,173,793          +0.30%
Dw                    12,139,071| 12,194,457          +0.46%
EstimatedCycles      111,626,028|112,030,453          +0.36%
I1mr                     154,337|    156,716          +1.54%
ILmr                       7,038|      6,897          -2.00%
Ir                    76,709,793| 76,795,245          +0.11%
L1hits               106,248,028|106,439,453          +0.18%
LLhits                   660,192|    658,349          -0.28%
RamHits                   59,344|     65,693         +10.70%
TotalRW              106,967,564|107,163,495          +0.18%

run_once_iai::run_once_group::run_once with_setup_2:setup_run_once(procedural-string-lights)
Instructions: 9,752,202 (master) → 9,762,377 (HEAD) : $$\color{red}+0.10\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                      44,223|     45,246          +2.31%
D1mw                      16,464|     16,630          +1.01%
DLmr                         238|        227          -4.62%
DLmw                       3,476|      3,990         +14.79%
Dr                     2,234,110|  2,230,639          -0.16%
Dw                     1,546,691|  1,545,703          -0.06%
EstimatedCycles       14,147,893| 14,164,563          +0.12%
I1mr                      34,498|     33,700          -2.31%
ILmr                       4,091|      3,901          -4.64%
Ir                     9,752,202|  9,762,377          +0.10%
L1hits                13,437,818| 13,443,143          +0.04%
LLhits                    87,380|     87,458          +0.09%
RamHits                    7,805|      8,118          +4.01%
TotalRW               13,533,003| 13,538,719          +0.04%

run_once_iai::run_once_group::run_once with_setup_3:setup_run_once(parametric-dunescape)
Instructions: 26,344,181 (master) → 26,369,118 (HEAD) : $$\color{red}+0.09\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                     121,450|    118,474          -2.45%
D1mw                      52,172|     51,795          -0.72%
DLmr                       1,615|        539         -66.63%
DLmw                      10,562|      8,522         -19.31%
Dr                     5,865,281|  5,891,577          +0.45%
Dw                     3,494,380|  3,526,780          +0.93%
EstimatedCycles       37,110,540| 37,089,029          -0.06%
I1mr                      61,990|     62,832          +1.36%
ILmr                       3,298|      3,244          -1.64%
Ir                    26,344,181| 26,369,118          +0.09%
L1hits                35,468,230| 35,554,374          +0.24%
LLhits                   220,137|    220,796          +0.30%
RamHits                   15,475|     12,305         -20.48%
TotalRW               35,703,842| 35,787,475          +0.23%

run_once_iai::run_once_group::run_once with_setup_4:setup_run_once(red-dress)
Instructions: 1,884,558,361 (master) → 1,884,081,768 (HEAD) : $$\color{lime}-0.03\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                   1,520,406|  1,516,671          -0.25%
D1mw                     690,644|    691,318          +0.10%
DLmr                     321,454|    313,052          -2.61%
DLmw                     457,095|    424,292          -7.18%
Dr                   437,398,715|436,842,300          -0.13%
Dw                   279,230,326|278,688,087          -0.19%
EstimatedCycles      2,636,492,292|2,633,681,237          -0.11%
I1mr                     737,340|    741,469          +0.56%
ILmr                       5,162|      5,031          -2.54%
Ir                   1,884,558,361|1,884,081,768          -0.03%
L1hits               2,598,239,012|2,596,662,697          -0.06%
LLhits                 2,164,679|  2,207,083          +1.96%
RamHits                  783,711|    742,375          -5.27%
TotalRW              2,601,187,402|2,599,612,155          -0.06%

run_once_iai::run_once_group::run_once with_setup_5:setup_run_once(valley-of-spires)
Instructions: 19,120,010 (master) → 19,032,595 (HEAD) : $$\color{lime}-0.46\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                     192,218|    191,742          -0.25%
D1mw                      44,197|     42,674          -3.45%
DLmr                       5,539|        585         -89.44%
DLmw                      12,264|      9,993         -18.52%
Dr                     4,669,277|  4,633,542          -0.77%
Dw                     3,096,937|  3,078,995          -0.58%
EstimatedCycles       28,826,774| 28,452,814          -1.30%
I1mr                      92,400|     90,797          -1.73%
ILmr                       3,040|      2,983          -1.88%
Ir                    19,120,010| 19,032,595          -0.46%
L1hits                26,557,409| 26,419,919          -0.52%
LLhits                   307,972|    311,652          +1.19%
RamHits                   20,843|     13,561         -34.94%
TotalRW               26,886,224| 26,745,132          -0.52%

⚡ Render: Cached Execution

run_cached_iai::run_cached_group::run_cached with_setup_0:setup_run_cached(isometric-fountain)
Instructions: 20,834,616 (master) → 20,774,712 (HEAD) : $$\color{lime}-0.29\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                     251,204|    252,956          +0.70%
D1mw                      45,428|     45,019          -0.90%
DLmr                       2,083|      2,583         +24.00%
DLmw                         727|        637         -12.38%
Dr                     5,380,473|  5,343,640          -0.68%
Dw                     3,562,023|  3,551,573          -0.29%
EstimatedCycles       31,510,596| 31,406,115          -0.33%
I1mr                     114,494|    110,910          -3.13%
ILmr                         156|        135         -13.46%
Ir                    20,834,616| 20,774,712          -0.29%
L1hits                29,365,986| 29,261,040          -0.36%
LLhits                   408,160|    405,530          -0.64%
RamHits                    2,966|      3,355         +13.12%
TotalRW               29,777,112| 29,669,925          -0.36%

run_cached_iai::run_cached_group::run_cached with_setup_1:setup_run_cached(painted-dreams)
Instructions: 26,323,203 (master) → 26,333,370 (HEAD) : $$\color{red}+0.04\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                     218,807|    215,963          -1.30%
D1mw                      54,367|     54,129          -0.44%
DLmr                         890|      3,242        +264.27%
DLmw                         501|      1,798        +258.88%
Dr                     6,477,188|  6,480,206          +0.05%
Dw                     4,417,154|  4,428,559          +0.26%
EstimatedCycles       38,640,157| 38,774,767          +0.35%
I1mr                      70,884|     74,351          +4.89%
ILmr                         155|        122         -21.29%
Ir                    26,323,203| 26,333,370          +0.04%
L1hits                36,873,487| 36,897,692          +0.07%
LLhits                   342,512|    339,281          -0.94%
RamHits                    1,546|      5,162        +233.89%
TotalRW               37,217,545| 37,242,135          +0.07%

run_cached_iai::run_cached_group::run_cached with_setup_2:setup_run_cached(procedural-string-lights)
Instructions: 9,083,333 (master) → 9,464,955 (HEAD) : $$\color{red}+4.20\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                      45,316|     56,577         +24.85%
D1mw                      15,169|     15,447          +1.83%
DLmr                           9|          7         -22.22%
DLmw                         129|        201         +55.81%
Dr                     2,134,624|  2,245,927          +5.21%
Dw                     1,497,204|  1,577,075          +5.33%
EstimatedCycles       13,094,071| 13,712,793          +4.73%
I1mr                      32,060|     31,680          -1.19%
ILmr                         153|        126         -17.65%
Ir                     9,083,333|  9,464,955          +4.20%
L1hits                12,622,616| 13,184,253          +4.45%
LLhits                    92,254|    103,370         +12.05%
RamHits                      291|        334         +14.78%
TotalRW               12,715,161| 13,287,957          +4.50%

run_cached_iai::run_cached_group::run_cached with_setup_3:setup_run_cached(parametric-dunescape)
Instructions: 16,229,333 (master) → 16,062,604 (HEAD) : $$\color{lime}-1.03\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                     105,911|    101,997          -3.70%
D1mw                      37,150|     33,740          -9.18%
DLmr                          45|         11         -75.56%
DLmw                       1,215|        503         -58.60%
Dr                     3,707,000|  3,623,988          -2.24%
Dw                     2,471,430|  2,400,829          -2.86%
EstimatedCycles       23,123,107| 22,751,607          -1.61%
I1mr                      25,455|     25,652          +0.77%
ILmr                         116|        107          -7.76%
Ir                    16,229,333| 16,062,604          -1.03%
L1hits                22,239,247| 21,926,032          -1.41%
LLhits                   167,140|    160,768          -3.81%
RamHits                    1,376|        621         -54.87%
TotalRW               22,407,763| 22,087,421          -1.43%

run_cached_iai::run_cached_group::run_cached with_setup_4:setup_run_cached(red-dress)
Instructions: 280,308,455 (master) → 279,687,739 (HEAD) : $$\color{lime}-0.22\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                   1,427,608|  1,414,448          -0.92%
D1mw                     460,970|    457,648          -0.72%
DLmr                     489,267|    469,861          -3.97%
DLmw                     228,429|    207,128          -9.32%
Dr                    68,196,331| 67,767,655          -0.63%
Dw                    49,014,828| 48,607,266          -0.83%
EstimatedCycles      429,329,028|426,707,332          -0.61%
I1mr                     651,558|    681,767          +4.64%
ILmr                       3,933|      3,985          +1.32%
Ir                   280,308,455|279,687,739          -0.22%
L1hits               394,979,478|393,508,797          -0.37%
LLhits                 1,818,507|  1,872,889          +2.99%
RamHits                  721,629|    680,974          -5.63%
TotalRW              397,519,614|396,062,660          -0.37%

run_cached_iai::run_cached_group::run_cached with_setup_5:setup_run_cached(valley-of-spires)
Instructions: 19,424,522 (master) → 19,321,213 (HEAD) : $$\color{lime}-0.53\%$$

Detailed metrics 
Baselines:                master|       HEAD
D1mr                     206,302|    204,827          -0.71%
D1mw                      40,175|     39,837          -0.84%
DLmr                         229|        182         -20.52%
DLmw                       1,021|        897         -12.14%
Dr                     4,801,675|  4,763,604          -0.79%
Dw                     3,150,805|  3,136,839          -0.44%
EstimatedCycles       28,785,552| 28,612,234          -0.60%
I1mr                      95,213|     93,958          -1.32%
ILmr                         143|        124         -13.29%
Ir                    19,424,522| 19,321,213          -0.53%
L1hits                27,035,312| 26,883,034          -0.56%
LLhits                   340,297|    337,419          -0.85%
RamHits                    1,393|      1,203         -13.64%
TotalRW               27,377,002| 27,221,656          -0.57%

@Keavon Keavon force-pushed the ir/refactor-click-targets branch from 7f74686 to 7b5505f Compare August 26, 2025 04:15
Keavon
Keavon reviewed Aug 27, 2025
View reviewed changes
@Keavon Keavon changed the title Fix the Select tool not selecting the target which is entirely within the selection shape Fix box selection regression where only intersected, not contained, objects were selected Aug 27, 2025
@Keavon Keavon changed the title Fix box selection regression where only intersected, not contained, objects were selected Fix box selection regression where only intersected, not contained, objects get selected Aug 27, 2025
@Keavon Keavon enabled auto-merge (squash) August 27, 2025 21:05
@Keavon Keavon merged commit 57853f7 into master Aug 27, 2025
4 checks passed
@Keavon Keavon deleted the ir/refactor-click-targets branch August 27, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keavon Keavon Keavon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@indierusty @Keavon