Skip to content

Conversation

Firestar99
Copy link
Collaborator

@Firestar99 Firestar99 commented Aug 28, 2025

See cargo bug rust-lang/cargo#15890

Disabling proc-macros testing is required for shaders to pass testing.

@Firestar99 Firestar99 changed the title editor: remove unused ron feature CI: better feature unification experiment Aug 28, 2025
@Firestar99 Firestar99 force-pushed the ci-editor-feature-unification branch 2 times, most recently from 1546fdd to 501de9f Compare August 28, 2025 13:32
@Firestar99 Firestar99 changed the title CI: better feature unification experiment Disable proc-macros crate from being tested due to cargo bug Aug 28, 2025
@Firestar99 Firestar99 force-pushed the ci-editor-feature-unification branch from 501de9f to 0d81b4e Compare August 28, 2025 13:39
@Firestar99 Firestar99 marked this pull request as ready for review August 28, 2025 14:48
@Firestar99
Copy link
Collaborator Author

The rust-gpu build in #3097 is passing, this is ready to merge!

@Firestar99 Firestar99 enabled auto-merge (squash) August 28, 2025 14:48
Copy link
Member

@TrueDoctor TrueDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main disadvantage is that we now build non default targets for everyone, but I hope we'll get bug reports reasonably quickly if this causes issues for other developers

@Firestar99 Firestar99 merged commit ce1cd17 into master Aug 29, 2025
4 checks passed
@Firestar99 Firestar99 deleted the ci-editor-feature-unification branch August 29, 2025 10:25
@Firestar99
Copy link
Collaborator Author

Could you define "non default targets" for me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants