Skip to content

Conversation

@bluelinden
Copy link
Contributor

@bluelinden bluelinden commented Nov 3, 2025

This PR adds a major/minor grid line system that allows for better usability of precise grids when zoomed farther out.

The implementation is inspired by Inkscape's.

*note: this PR contains a few segments initially written using AI and then iterated upon and fixed by me, a human. I take responsibility for any and all bugs found in the updated portions of the grid rendering code, and I am confident that the work is human-quality.

@Keavon
Copy link
Member

Keavon commented Nov 3, 2025

!build

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

📦 Build Complete for 489ca95
https://d8d0d724.graphite.pages.dev

@Keavon
Copy link
Member

Keavon commented Nov 3, 2025

!build

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

📦 Build Complete for 7732aca
https://6f67539d.graphite.pages.dev

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Keavon what this will also need to be moved to the branding repo right?
How should we handle this for now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Keavon this needs to be added to the branding repo

@timon-schelling
Copy link
Member

!build

@github-actions
Copy link

📦 Build Complete for 5c6ab75
https://a325dc94.graphite.pages.dev

@timon-schelling
Copy link
Member

!build

@github-actions
Copy link

📦 Build Complete for e5e3e5a
https://c089fa70.graphite.pages.dev

@Keavon
Copy link
Member

Keavon commented Nov 17, 2025

!build

@github-actions
Copy link

📦 Build Complete for c560ba6
https://b2a337b8.graphite.pages.dev

@timon-schelling
Copy link
Member

!build

@github-actions
Copy link

📦 Build Complete for eaa4ffe
https://ead5f7ea.graphite.pages.dev

@timon-schelling
Copy link
Member

Sorry for taking so long to take a look, Code looks good in general.
We need to rebase though.
(And the dot may be moved to the branding repo, not because it's copyrightable, but to keep all icons in one place. @Keavon)

I may have noticed one logic bug, lines and dots don't match the same pattern here.

image image

And If I remember correctly I somehow got into a state where the second color selection element would not disappear with 1 1 1, but I'm not able to reproduce that, not a blocker in my opinion.

@bluelinden bluelinden reopened this Jan 10, 2026
refactoring (widget_holder → widget_instance, SeparatorType →
SeparatorStyle)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants