-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Add major/minor grid lines to grids popover #3334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
!build |
|
|
!build |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Keavon what this will also need to be moved to the branding repo right?
How should we handle this for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Keavon this needs to be added to the branding repo
|
!build |
|
|
!build |
|
|
!build |
|
|
!build |
|
|
Sorry for taking so long to take a look, Code looks good in general. I may have noticed one logic bug, lines and dots don't match the same pattern here.
And If I remember correctly I somehow got into a state where the second color selection element would not disappear with 1 1 1, but I'm not able to reproduce that, not a blocker in my opinion. |
124235a to
a42cad8
Compare
refactoring (widget_holder → widget_instance, SeparatorType → SeparatorStyle)


This PR adds a major/minor grid line system that allows for better usability of precise grids when zoomed farther out.
The implementation is inspired by Inkscape's.
*note: this PR contains a few segments initially written using AI and then iterated upon and fixed by me, a human. I take responsibility for any and all bugs found in the updated portions of the grid rendering code, and I am confident that the work is human-quality.