Skip to content

Fix Enter fails to confirm in the New Document dialog after editing values #3615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abdoshbr3322 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix Enter fails to confirm in the New Document dialog after editing values #3615

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
109055b
Fix enter button not working while focusing on input fields in the ne…
abdoshbr3322 Jan 8, 2026
a6b178e
select the pop element using it's data attribute
abdoshbr3322 Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions frontend/src/components/floating-menus/Dialog.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,14 @@
// Focus the button which is marked as emphasized, or otherwise the first button, in the popup
const emphasizedOrFirstButton = (self?.div?.()?.querySelector("[data-emphasized]") || self?.div?.()?.querySelector("[data-text-button]") || undefined) as HTMLButtonElement | undefined;
emphasizedOrFirstButton?.focus();

// Add an event to handle enter press on all focusable fields(inputs) inside the popup
const pop = (self?.div?.()?.querySelector("[data-floating-menu-content]") || self?.div?.()?.querySelector("[data-floating-menu-content]") || undefined) as HTMLButtonElement | undefined;
pop?.addEventListener("keydown", function (event) {
if (event.key == "Enter") {
emphasizedOrFirstButton?.click();
}
})
});
</script>

Expand Down