Fix Exports having 0 layers #3618
Draft
+34
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto fix/no-layer-exports
0HyperCube
suggested changes
Jan 10, 2026
Comment on lines
+1198
to
+1210
| let non_layer_export_bounds = self | ||
| .document_network() | ||
| .exports | ||
| .iter() | ||
| .filter_map(|export| { | ||
| if let NodeInput::Node { node_id, .. } = export { | ||
| if !self.is_layer(node_id, &[]) { | ||
| return self.document_metadata().bounding_box_document(LayerNodeIdentifier::new_unchecked(*node_id)); | ||
| } | ||
| } | ||
| None | ||
| }) | ||
| .reduce(Quad::combine_bounds); |
Contributor
There was a problem hiding this comment.
This doesn't do anything since only layers are put into the bounding box. This is always None.
| .reduce(Quad::combine_bounds) | ||
| .reduce(Quad::combine_bounds); | ||
|
|
||
| let root_artwork_bounds = self.document_metadata().bounding_box_document(LayerNodeIdentifier::ROOT_PARENT); |
Contributor
There was a problem hiding this comment.
The transform_to_viewport doesn't work for the LayerNodeIdentifier::ROOT_PARENT for legacy reasons. This causes the bounds here to be incorrect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3422
Preview:
cursorful-video-1767970758932.mp4
Since we dont have any layer to export, only an infinite canvas is left though which we can calculate the bounding box.
I tried to create bounding box around extreme drawing points, but still as you can see the final exported image in preview is weird, is it ok ?or what i am thinking is when export mode is all-artwork i can apply 10% (or more) padding to it.