Conversation
janheise
force-pushed
the
documentation
branch
from
51eef5b to
14fbfbf
Compare
bernd
reviewed
Oct 15, 2025
Member
bernd
left a comment
bernd
left a comment
There was a problem hiding this comment.
Please update JUnit to version 6 before we merge this.
Contributor
|
@bernd updated, thanks! |
bernd
requested changes
Oct 15, 2025
src/main/java/com/github/joschi/jadconfig/documentation/ConfigurationDocsGenerator.java
Outdated
Show resolved
Hide resolved
src/main/java/com/github/joschi/jadconfig/documentation/ConfigurationDocsGenerator.java
Outdated
Show resolved
Hide resolved
todvora
force-pushed
the
documentation
branch
from
be294ea to
6664b02
Compare
bernd
approved these changes
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the documentation annotations used in https://github.com/Graylog2/graylog2-server into JadConfig for broader use.
I also updated JUnit to version 5 to accommodate moved tests.
Notes for Reviewers