Add MicroK8s instructions to CONTRIBUTING.md#17
Conversation
|
@monrax Great instructions! My feedback:
|
- README: Added setting default storageclass to install section before install command to help prevent issues at first install and subsequent upgrades. - NOTES: Changed root password update command to use local chart instead of non-existent repo. Once our official `graylog/graylog` repo is created we should change it back though. Signed-off-by: William Trelawny <22324745+williamtrelawny@users.noreply.github.com>
|
Thank you @williamtrelawny ! OK, one by one:
Please, let me know if this sounds right. |
All sounds good to me! Thanks @monrax |
|
Sorry, forgot to mention it: don't delete the Also, please remember to rebase/squash before merging with |
|
Sorry, got carried away clicking all the Github buttons. I knew you meant to not delete the branch but that blasted button was calling my name... But I didn't think about rebasing so thanks for that, I'll be more careful going forward 😅 |
Add MicroK8s instructions to
CONTRIBUTING.mdfor testing locally with both Linux and macOS.In addition, this PR introduces the
updates/docsbranch. The idea is to have one place where we can modifyREADME.md,CONTRIBUTING.md, and other docs in one place before merging withmain.We should always rebase before merging. Thus, the workflow would be:
Then,
Of course, let's say an urgent last-minute modification to the README is due, admins can always bypass all of this and push directly to main. Other contributors would have to go to the procedure specified above.