Revamp/server input pagination by kodjo-anipah · Pull Request #24057 · Graylog2/graylog2-server

kodjo-anipah · 2025-10-30T07:20:00Z

Description

/jpd https://github.com/Graylog2/graylog-plugin-enterprise/pull/12538

Refactored Input and InputService to remove usage of the deprecated PersistedServiceImpl and Persisted interface.
Added a pagination endpoint for inputs.

Related E2E fix https://github.com/Graylog2/e2e-tests/pull/1394

Motivation and Context

Relates to Graylog2/graylog-plugin-enterprise#12248
The current input page lacks sufficient overview, so we are adding pagination to improve the usability of the screen.

How Has This Been Tested?

Locally

Input creation, update & deletion
Input import via content pack
Adding & removing static fields
Adding & removing extractors

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Refactoring (non-breaking change)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have requested a documentation update.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.

* Implement entity data table for Inputs * Update InputsDotBadge with cluster endpoint * Delete graylog2-web-interface/src/components/inputs/InputsOveriew/cells/.#ThroughputCell.tsx * add Expanded Title section to show config and static fields * remove InputList and InputListItem - format files * make row clickable and have a single expanded section - remove unnecessary components * fix linter * fix lint * fix lint * refactor imports * fix review --------- Co-authored-by: Laura Bergenthal-Grotlüschen <laura.bergenthalgrotlueschen@graylog.com>

Co-authored-by: Gary Bot <garybot2@graylog.com>

Bumps `auto-value.version` from 1.11.0 to 1.11.1. Updates `com.google.auto.value:auto-value-annotations` from 1.11.0 to 1.11.1 - [Release notes](https://github.com/google/auto/releases) - [Commits](google/auto@auto-value-1.11.0...auto-value-1.11.1) Updates `com.google.auto.value:auto-value` from 1.11.0 to 1.11.1 - [Release notes](https://github.com/google/auto/releases) - [Commits](google/auto@auto-value-1.11.0...auto-value-1.11.1) --- updated-dependencies: - dependency-name: com.google.auto.value:auto-value-annotations dependency-version: 1.11.1 dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: com.google.auto.value:auto-value dependency-version: 1.11.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [io.modelcontextprotocol.sdk:mcp-bom](https://github.com/modelcontextprotocol/java-sdk) from 0.15.0 to 0.16.0. - [Release notes](https://github.com/modelcontextprotocol/java-sdk/releases) - [Commits](modelcontextprotocol/java-sdk@v0.15.0...v0.16.0) --- updated-dependencies: - dependency-name: io.modelcontextprotocol.sdk:mcp-bom dependency-version: 0.16.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [org.hibernate.validator:hibernate-validator](https://github.com/hibernate/hibernate-validator) from 9.0.1.Final to 9.1.0.Final. - [Release notes](https://github.com/hibernate/hibernate-validator/releases) - [Changelog](https://github.com/hibernate/hibernate-validator/blob/main/changelog.txt) - [Commits](hibernate/hibernate-validator@9.0.1.Final...9.1.0.Final) --- updated-dependencies: - dependency-name: org.hibernate.validator:hibernate-validator dependency-version: 9.1.0.Final dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [software.amazon.msk:aws-msk-iam-auth](https://github.com/aws/aws-msk-iam-auth) from 2.3.4 to 2.3.5. - [Release notes](https://github.com/aws/aws-msk-iam-auth/releases) - [Commits](aws/aws-msk-iam-auth@v2.3.4...v2.3.5) --- updated-dependencies: - dependency-name: software.amazon.msk:aws-msk-iam-auth dependency-version: 2.3.5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Refactor ClusterStateApi to use os3 client * fix empty properties indices * fix conflict * better index deletion handling for unavailable indices * fix deletion of indices * code cleanup * better record name and javadoc

…_pagination # Conflicts: # graylog-storage-opensearch3/src/test/java/org/graylog/storage/opensearch3/cluster/ClusterStateApiIT.java # graylog2-web-interface/src/components/inputs/InputsOveriew/cells/StateCell.tsx # graylog2-web-interface/src/components/inputs/InputsOveriew/cells/TypeCell.tsx

* add additional columns - add InputActions test * add expanded section actions * use product name * fix lint * fix lint --------- Co-authored-by: Laura Bergenthal-Grotlüschen <laura.bergenthalgrotlueschen@graylog.com>

kodjo-anipah · 2025-11-26T09:05:41Z

Things I noticed during testing:

The per node input overview page now displays inputs from all nodes. Need to filter or query for the specific node.

Inputs installed from content pack do not set field desired_state. This doesn't cause any issues in master. Running the PR branch, it leads to exceptions during startup. E.g.:
2025-11-21 16:32:37,869 WARN : org.graylog2.inputs.PersistedInputsImpl - Cannot instantiate persisted input. Exception caught: 
java.lang.NullPointerException: Cannot invoke "org.graylog2.plugin.IOState$Type.equals(Object)" because "newDesiredState" is null
	at org.graylog2.plugin.inputs.MessageInput.setDesiredState(MessageInput.java:287)
	at org.graylog2.inputs.InputServiceImpl.getMessageInput(InputServiceImpl.java:571)
	at org.graylog2.inputs.PersistedInputsImpl.iterator(PersistedInputsImpl.java:50)
	at org.graylog2.shared.inputs.InputLauncher.launchAllPersisted(InputLauncher.java:137)
On master, these inputs end up running. In the PR branch they end up stopped.

Thanks for catching that, weird enough if desired state is null, we send back the running state. I kept the same behaviour

patrickmann

BE looks good.

…ove input creation (#24283) * add Inputs notifications for failed, setup and stopped state * fix lint * improve input creation - open wizard after saving input * remove navigation * remove filter copy * adjust to upstream changes * Update InputsPage.tsx * Update graylog2-web-interface/src/util/DocsHelper.ts Co-authored-by: Laura Bergenthal-Grotlüschen <laura.bergenthalgrotlueschen@graylog.com> * reset field after opening wizard * fix typo * add column width --------- Co-authored-by: Mohamed OULD HOCINE <106236152+gally47@users.noreply.github.com> Co-authored-by: Laura Bergenthal-Grotlüschen <laura.bergenthalgrotlueschen@graylog.com>

linuspahl · 2025-12-11T08:37:02Z

graylog2-web-interface/src/components/inputs/InputsOveriew/cells/ThroughputCell.tsx

+      ref={spanRef}
+      title={`${throughputSectionIsOpen ? 'Hide' : 'Show'} metrics`}
+      onClick={toggleTrafficSection}>
+      {!isNaN(incomingMessages) ? formatCount(incomingMessages) : 0} msg/s Last Minute


@ousmaneo One small thing I noticed while working on the tables. We also have a throughput cell for the streams overview, but it displays the information slightly different. We do not format the number via numeral(count).format('0,0'). We also don't display "Last Minute" or something similar.

It would be nice to unify how these cells display the throughput, maybe even via a shared component.

kodjo-anipah and others added 30 commits October 28, 2025 19:58

first iteration of pagination

f474925

commit state

6f1f230

Merge branch 'master' into revamp/server_input_pagination

090d3f1

fix import and add license header

575c706

fix import

03fd18d

Merge branch 'master' into revamp/server_input_pagination

51a019d

fix compliation issues

35d87e5

Merge branch 'master' into revamp/server_input_pagination

ab64019

fix static field deserilization

1e45691

Merge branch 'master' into revamp/server_input_pagination

f80714b

Merge branch 'master' into revamp/server_input_pagination

2553d77

Merge branch 'master' into revamp/server_input_pagination

00d0cd2

Merge branch 'master' into revamp/server_input_pagination

7971160

Merge branch 'master' into revamp/server_input_pagination

3f1303d

continue refactoring

4463d9c

Remove unused CatApi impl (#24215)

818e59f

Position leftCol component to the left in ModalSubmit (#24111)

213638d

Updating yarn lockfile (#24217)

1b1891b

Co-authored-by: Gary Bot <garybot2@graylog.com>

Refactor ClusterStateApi to use os3 client (#24196)

8c30e58

* Refactor ClusterStateApi to use os3 client * fix empty properties indices * fix conflict * better index deletion handling for unavailable indices * fix deletion of indices * code cleanup * better record name and javadoc

commit compiling state

2ca5ffa

switch pagination

5675bca

fix removed class

0d882f7

fix encrypted values

b550010

fix extractors

93681a0

patrickmann and others added 10 commits November 25, 2025 10:17

linter fixes

afbdb8c

add node filter when node is set

7153007

clean up input to use set pattern on builder

9469b50

remove not needed prop

b9cf9c7

Merge branch 'master' into revamp/server_input_pagination

3c5ccbb

Add additional column to inputs page (#24268)

08fae8c

* add additional columns - add InputActions test * add expanded section actions * use product name * fix lint * fix lint --------- Co-authored-by: Laura Bergenthal-Grotlüschen <laura.bergenthalgrotlueschen@graylog.com>

fix lint errors

518ff86

Merge branch 'master' into revamp/server_input_pagination

b28ffeb

fix desired state and buildFromMap

bf3039a

make returned list immutable again

e390549

kodjo-anipah requested a review from patrickmann November 26, 2025 09:04

ousmaneo added e2e-tests Run PR build with e2e tests. and removed e2e-tests Run PR build with e2e tests. labels Nov 26, 2025

ousmaneo added 2 commits November 26, 2025 14:43

Update InputsOverview.tsx

b9264db

Merge branch 'master' into revamp/server_input_pagination

3939ec2

patrickmann approved these changes Nov 26, 2025

View reviewed changes

kodjo-anipah and others added 8 commits November 27, 2025 10:05

Merge branch 'master' into revamp/server_input_pagination

8cbc1ad

Merge branch 'master' into revamp/server_input_pagination

2df2d16

Merge branch 'master' into revamp/server_input_pagination

774269a

Merge branch 'master' into revamp/server_input_pagination

de8c1c6

Merge branch 'master' into revamp/server_input_pagination

96d1d40

Merge branch 'master' into revamp/server_input_pagination

f1b9835

Merge branch 'master' into revamp/server_input_pagination

0f1c11a

kodjo-anipah merged commit bd3719c into master Dec 1, 2025
24 checks passed

kodjo-anipah deleted the revamp/server_input_pagination branch December 1, 2025 06:47

danotorrey mentioned this pull request Dec 2, 2025

Look up final input before returning summary #24421

Merged

linuspahl reviewed Dec 11, 2025

View reviewed changes

fpetersen-gl mentioned this pull request Jan 23, 2026

Add static fields from input again #24821

Closed

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revamp/server input pagination#24057

Revamp/server input pagination#24057
kodjo-anipah merged 79 commits intomasterfrom
revamp/server_input_pagination

kodjo-anipah commented Oct 30, 2025 •

edited by ousmaneo

Loading

Uh oh!

kodjo-anipah commented Nov 26, 2025

Uh oh!

patrickmann left a comment

Uh oh!

Uh oh!

linuspahl Dec 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Conversation

kodjo-anipah commented Oct 30, 2025 • edited by ousmaneo Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

Uh oh!

kodjo-anipah commented Nov 26, 2025

Uh oh!

patrickmann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

linuspahl Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

kodjo-anipah commented Oct 30, 2025 •

edited by ousmaneo

Loading