add Inputs notifications for failed, setup and stopped state and improve input creation by ousmaneo · Pull Request #24283 · Graylog2/graylog2-server

ousmaneo · 2025-11-19T14:35:54Z

/nocl
fix Graylog2/graylog-plugin-enterprise#12245

/jpd https://github.com/Graylog2/graylog-plugin-enterprise/pull/12538

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Refactoring (non-breaking change)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have requested a documentation update.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.

…fication

- open wizard after saving input

…fication

laura-b-g

Looking good, tested and it works 👍

graylog2-web-interface/src/util/DocsHelper.ts

Co-authored-by: Laura Bergenthal-Grotlüschen <laura.bergenthalgrotlueschen@graylog.com>

…fication

gally47

Looking good, wrote few nitpicks/comments below

gally47 · 2025-11-27T11:05:57Z

graylog2-web-interface/src/components/inputs/InputsNotifications.tsx

+      <Col md={12}>
+        {hasFailedInputs && (
+          <StyledAlert bsStyle="danger" title="Some inputs are in failed state.">
+            One or more inputs are currently failed state. Failed or failing inputs will not receive traffic until


typo: ...are currently in a failed state...

gally47 · 2025-11-27T11:14:01Z

graylog2-web-interface/src/components/inputs/InputsNotifications.tsx

+    if (isLoading || !inputs || !inputStates) return null;
+
+    return {
+      hasStoppedInputs: inputs.some((input) => !inputStates[input.id]),


is it more accurate to name it hasMissingInputStates ? since state STOPPED does exist ?

Input in stopped stated are not sent by the backend this means missing are stopped ones.

gally47 · 2025-11-27T11:22:27Z

graylog2-web-interface/src/stores/inputs/InputsStore.ts

  get: (id: string) => Promise<Input>;
  getOptional: (id: string, showError: boolean) => Promise<Input>;
-  create: (input: ConfiguredInput) => Promise<void>;
+  create: (input: ConfiguredInput) => Promise<{ id: string }>;


Do we also need to change the create fetch promise return, to make sure it is not a void and it is returning the id?

The backend return the id on the create fetch Promise since we are returning the promise we can be sure that if it resolve it will have the id

gally47 · 2025-11-27T11:47:46Z

graylog2-web-interface/src/components/inputs/CreateInputControl.tsx

+    return {
+      id: createdInputId,
+      title: createdInputData.title,
+      type: selectedInput,


selectedInput will always be undefined after resetFields() no ?

…fication

* first iteration of pagination * commit state * fix import and add license header * fix import * fix compliation issues * fix static field deserilization * Move inputsList to PaginatedEntityDataTable (#24113) * Implement entity data table for Inputs * Update InputsDotBadge with cluster endpoint * Delete graylog2-web-interface/src/components/inputs/InputsOveriew/cells/.#ThroughputCell.tsx * add Expanded Title section to show config and static fields * remove InputList and InputListItem - format files * make row clickable and have a single expanded section - remove unnecessary components * fix linter * fix lint * fix lint * refactor imports * fix review --------- Co-authored-by: Laura Bergenthal-Grotlüschen <laura.bergenthalgrotlueschen@graylog.com> * continue refactoring * Remove unused CatApi impl (#24215) * Position leftCol component to the left in ModalSubmit (#24111) * Updating yarn lockfile (#24217) Co-authored-by: Gary Bot <garybot2@graylog.com> * Bump auto-value.version from 1.11.0 to 1.11.1 (#24201) Bumps `auto-value.version` from 1.11.0 to 1.11.1. Updates `com.google.auto.value:auto-value-annotations` from 1.11.0 to 1.11.1 - [Release notes](https://github.com/google/auto/releases) - [Commits](google/auto@auto-value-1.11.0...auto-value-1.11.1) Updates `com.google.auto.value:auto-value` from 1.11.0 to 1.11.1 - [Release notes](https://github.com/google/auto/releases) - [Commits](google/auto@auto-value-1.11.0...auto-value-1.11.1) --- updated-dependencies: - dependency-name: com.google.auto.value:auto-value-annotations dependency-version: 1.11.1 dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: com.google.auto.value:auto-value dependency-version: 1.11.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump io.modelcontextprotocol.sdk:mcp-bom from 0.15.0 to 0.16.0 (#24211) Bumps [io.modelcontextprotocol.sdk:mcp-bom](https://github.com/modelcontextprotocol/java-sdk) from 0.15.0 to 0.16.0. - [Release notes](https://github.com/modelcontextprotocol/java-sdk/releases) - [Commits](modelcontextprotocol/java-sdk@v0.15.0...v0.16.0) --- updated-dependencies: - dependency-name: io.modelcontextprotocol.sdk:mcp-bom dependency-version: 0.16.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump org.hibernate.validator:hibernate-validator (#24173) Bumps [org.hibernate.validator:hibernate-validator](https://github.com/hibernate/hibernate-validator) from 9.0.1.Final to 9.1.0.Final. - [Release notes](https://github.com/hibernate/hibernate-validator/releases) - [Changelog](https://github.com/hibernate/hibernate-validator/blob/main/changelog.txt) - [Commits](hibernate/hibernate-validator@9.0.1.Final...9.1.0.Final) --- updated-dependencies: - dependency-name: org.hibernate.validator:hibernate-validator dependency-version: 9.1.0.Final dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump software.amazon.msk:aws-msk-iam-auth from 2.3.4 to 2.3.5 (#24157) Bumps [software.amazon.msk:aws-msk-iam-auth](https://github.com/aws/aws-msk-iam-auth) from 2.3.4 to 2.3.5. - [Release notes](https://github.com/aws/aws-msk-iam-auth/releases) - [Commits](aws/aws-msk-iam-auth@v2.3.4...v2.3.5) --- updated-dependencies: - dependency-name: software.amazon.msk:aws-msk-iam-auth dependency-version: 2.3.5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Refactor ClusterStateApi to use os3 client (#24196) * Refactor ClusterStateApi to use os3 client * fix empty properties indices * fix conflict * better index deletion handling for unavailable indices * fix deletion of indices * code cleanup * better record name and javadoc * commit compiling state * switch pagination * fix removed class * fix encrypted values * fix extractors * add missing headers * remove import * fix forbidden api call * fix test * fix forbidden api failure * Update InputsOverview.tsx * fix updating input * add back validation * add changelog * fix lint * ignore os java client (#24285) * Refector data_node_status (#24267) * refector data_node_status * Revert "refector data_node_status" This reverts commit 29c78d4. * Refector data_node_status to datanode_status --------- Co-authored-by: Matthias Oesterheld <33032967+moesterheld@users.noreply.github.com> * add more test cases * fix imports * linter fixes * linter fixes * add node filter when node is set * clean up input to use set pattern on builder * remove not needed prop * Add additional column to inputs page (#24268) * add additional columns - add InputActions test * add expanded section actions * use product name * fix lint * fix lint --------- Co-authored-by: Laura Bergenthal-Grotlüschen <laura.bergenthalgrotlueschen@graylog.com> * fix lint errors * fix desired state and buildFromMap * make returned list immutable again * Update InputsOverview.tsx * add Inputs notifications for failed, setup and stopped state and improve input creation (#24283) * add Inputs notifications for failed, setup and stopped state * fix lint * improve input creation - open wizard after saving input * remove navigation * remove filter copy * adjust to upstream changes * Update InputsPage.tsx * Update graylog2-web-interface/src/util/DocsHelper.ts Co-authored-by: Laura Bergenthal-Grotlüschen <laura.bergenthalgrotlueschen@graylog.com> * reset field after opening wizard * fix typo * add column width --------- Co-authored-by: Mohamed OULD HOCINE <106236152+gally47@users.noreply.github.com> Co-authored-by: Laura Bergenthal-Grotlüschen <laura.bergenthalgrotlueschen@graylog.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Ousmane SAMBA <ousmane@graylog.com> Co-authored-by: Laura Bergenthal-Grotlüschen <laura.bergenthalgrotlueschen@graylog.com> Co-authored-by: Tomas Dvorak <tomas.dvorak@graylog.com> Co-authored-by: Maksym Yadlovskyi <maksym.yadlovskyi@graylog.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Gary Bot <garybot2@graylog.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ousmane Samba <ousmane.samba@graylog.com> Co-authored-by: Matthias Oesterheld <33032967+moesterheld@users.noreply.github.com> Co-authored-by: Mohamed OULD HOCINE <106236152+gally47@users.noreply.github.com> Co-authored-by: Patrick Mann <patrickmann@users.noreply.github.com> Co-authored-by: patrickmann <patrick.mann@graylog.com>

add Inputs notifications for failed, setup and stopped state

3a49999

ousmaneo requested review from gally47 and laura-b-g November 19, 2025 14:36

ousmaneo added the ready-for-review label Nov 19, 2025

ousmaneo changed the base branch from revamp/server_input_pagination to revamp/additional-column November 19, 2025 15:41

ousmaneo changed the base branch from revamp/additional-column to revamp/server_input_pagination November 19, 2025 15:42

ousmaneo and others added 4 commits November 19, 2025 16:56

Merge branch 'revamp/server_input_pagination' into revamp/inputs-noti…

9e4d9bb

…fication

fix lint

ae8b6e3

Merge branch 'revamp/server_input_pagination' into revamp/inputs-noti…

33995e9

…fication

improve input creation

56f667b

- open wizard after saving input

ousmaneo changed the title ~~add Inputs notifications for failed, setup and stopped state~~ add Inputs notifications for failed, setup and stopped state and improve input creation Nov 21, 2025

ousmaneo and others added 7 commits November 21, 2025 12:41

remove navigation

5f38cca

remove filter copy

ef34ea8

Merge branch 'revamp/server_input_pagination' into revamp/inputs-noti…

ca80962

…fication

Merge branch 'revamp/server_input_pagination' into revamp/inputs-noti…

1b0200d

…fication

Merge branch 'revamp/server_input_pagination' into revamp/inputs-noti…

19bf1bd

…fication

adjust to upstream changes

1070476

Update InputsPage.tsx

133d711

laura-b-g approved these changes Nov 27, 2025

View reviewed changes

graylog2-web-interface/src/util/DocsHelper.ts Outdated Show resolved Hide resolved

ousmaneo and others added 2 commits November 27, 2025 15:40

Update graylog2-web-interface/src/util/DocsHelper.ts

5a853a8

Co-authored-by: Laura Bergenthal-Grotlüschen <laura.bergenthalgrotlueschen@graylog.com>

Merge branch 'revamp/server_input_pagination' into revamp/inputs-noti…

9ee0543

…fication

gally47 reviewed Nov 27, 2025

View reviewed changes

ousmaneo and others added 4 commits November 28, 2025 06:48

reset field after opening wizard

41cc33a

fix typo

a1558b3

Merge branch 'revamp/server_input_pagination' into revamp/inputs-noti…

9719cf4

…fication

add column width

dd9cc82

kodjo-anipah merged commit 1e3c713 into revamp/server_input_pagination Nov 28, 2025
24 checks passed

kodjo-anipah deleted the revamp/inputs-notification branch November 28, 2025 15:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add Inputs notifications for failed, setup and stopped state and improve input creation#24283

add Inputs notifications for failed, setup and stopped state and improve input creation#24283
kodjo-anipah merged 18 commits intorevamp/server_input_paginationfrom
revamp/inputs-notification

ousmaneo commented Nov 19, 2025 •

edited

Loading

Uh oh!

laura-b-g left a comment

Uh oh!

Uh oh!

gally47 left a comment

Uh oh!

gally47 Nov 27, 2025

Uh oh!

gally47 Nov 27, 2025

Uh oh!

ousmaneo Nov 28, 2025

Uh oh!

gally47 Nov 27, 2025

Uh oh!

ousmaneo Nov 28, 2025

Uh oh!

gally47 Nov 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

ousmaneo commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Types of changes

Checklist:

Uh oh!

laura-b-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gally47 left a comment

Choose a reason for hiding this comment

Uh oh!

gally47 Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

gally47 Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

ousmaneo Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

gally47 Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

ousmaneo Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

gally47 Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ousmaneo commented Nov 19, 2025 •

edited

Loading