Merged
Conversation
If a session auth context is provided during authentication, we will now always store it to a session. If no session exists at this point, we will create a session because we can treat the presence of a SessionAuthContext as a sufficient indicator that the creation of a session is expected/required. Previously, we were only storing the auth context in the session if the session existed. Most likely because of a refactoring of the SessionCreator in 5cdac60, the listener that persists the data is now called before the session is created.
thll
force-pushed
the
fix/session-context-storage
branch
from
d3aaf6e to
84659c1
Compare
bernd
requested changes
Nov 28, 2025
graylog2-server/src/main/java/org/graylog2/shared/security/PersistSessionDataListener.java
Show resolved
Hide resolved
bernd
approved these changes
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a session auth context is provided during authentication, we will now always store it to a session. If no session exists at this point, we will create a session because we can treat the presence of a SessionAuthContext as a sufficient indicator that the creation of a session is expected/required.
Previously, we were only storing the auth context in the session if the session existed. Most likely because of a refactoring of the SessionCreator in 5cdac60, the listener that persists the data is now called before the session is created.
/nocl